emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tftpd: show help if stdin is not a socket

Browse Source
This commit is contained in:
Denis Vlasenko 2008-11-01 00:22:24 +00:00
parent 44d5dcebc6
commit 5a89763fb7
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
networking/tftp.c
View File

@ -653,8 +653,15 @@ int tftpd_main(int argc UNUSED_PARAM, char **argv)
INIT_G(); INIT_G();
our_lsa = get_sock_lsa(STDIN_FILENO); our_lsa = get_sock_lsa(STDIN_FILENO);
if (!our_lsa) if (!our_lsa) {
bb_perror_msg_and_die("stdin is not a socket"); /* This is confusing:
*bb_error_msg_and_die("stdin is not a socket");
* Better: */
bb_show_usage();
/* Help text says that tftpd must be used as inetd service,
* which is by far the most usual cause of get_sock_lsa
* failure */
}
peer_lsa = xzalloc(LSA_LEN_SIZE + our_lsa->len); peer_lsa = xzalloc(LSA_LEN_SIZE + our_lsa->len);
peer_lsa->len = our_lsa->len; peer_lsa->len = our_lsa->len;