emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

unzip: fix xstrndup bug (xstrndup(s,n) can allocate less than n bytes!)

Browse Source
This commit is contained in:
Denis Vlasenko 2007-03-31 10:17:24 +00:00
parent 7b881c7168
commit 666c40c9fc
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
archival/unzip.c
View File

@ -134,7 +134,8 @@ int unzip_main(int argc, char **argv)
break;
case 1 : /* The zip file */
src_fn = xstrndup(optarg, strlen(optarg)+4);
src_fn = xmalloc(strlen(optarg)+4);
strcpy(src_fn, optarg);
opt_range++;
break;
@ -195,7 +196,7 @@ int unzip_main(int argc, char **argv)
src_fd = open(src_fn, O_RDONLY);
}
if (src_fd == -1) {
src_fn[orig_src_fn_len] = 0;
src_fn[orig_src_fn_len] = '\0';
bb_error_msg_and_die("cannot open %s, %s.zip, %s.ZIP", src_fn, src_fn, src_fn);
}
}