emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

httpd: Don't add Date header to response

Browse Source 
RFC 2616 sec. 14.18 says that server MUST send Date header.
But in fact the header make sense only for Cache-Control and can be omitted.
In the same time the Date eats power, CPU and network resources which are critical for embedded systems.

Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Sergey Ponomarev 2020-08-09 01:23:32 +03:00 committed by Denys Vlasenko
parent b414cdf5b4
commit 68f75bb9ce
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
networking/httpd.c
View File

@ -214,6 +214,14 @@
//config: help //config: help
//config: Makes httpd send files using GZIP content encoding if the //config: Makes httpd send files using GZIP content encoding if the
//config: client supports it and a pre-compressed <file>.gz exists. //config: client supports it and a pre-compressed <file>.gz exists.
//config:
//config:config FEATURE_HTTPD_DATE
//config: bool "Add Date header to response"
//config: default y
//config: depends on HTTPD
//config: help
//config: RFC2616 says that server MUST add Date header to response.
//config: But it is almost useless and can be omitted.
//applet:IF_HTTPD(APPLET(httpd, BB_DIR_USR_SBIN, BB_SUID_DROP)) //applet:IF_HTTPD(APPLET(httpd, BB_DIR_USR_SBIN, BB_SUID_DROP))
@ -1071,14 +1079,20 @@ static void send_headers(unsigned responseNum)
* always fit into those kbytes. * always fit into those kbytes.
*/ */
#if ENABLE_FEATURE_HTTPD_DATE
strftime(date_str, sizeof(date_str), RFC1123FMT, gmtime_r(&timer, &tm)); strftime(date_str, sizeof(date_str), RFC1123FMT, gmtime_r(&timer, &tm));
/* ^^^ using gmtime_r() instead of gmtime() to not use static data */ /* ^^^ using gmtime_r() instead of gmtime() to not use static data */
#endif
len = sprintf(iobuf, len = sprintf(iobuf,
"HTTP/1.1 %u %s\r\n" "HTTP/1.1 %u %s\r\n"
#if ENABLE_FEATURE_HTTPD_DATE
"Date: %s\r\n" "Date: %s\r\n"
#endif
"Connection: close\r\n", "Connection: close\r\n",
responseNum, responseString, responseNum, responseString
date_str #if ENABLE_FEATURE_HTTPD_DATE
,date_str
#endif
); );
if (responseNum != HTTP_OK || found_mime_type) { if (responseNum != HTTP_OK || found_mime_type) {