emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Audit bb_common_bufsiz usage, add script which looks for misuse.

Browse Source 
tr: stop using globals needlessly.
code: -103 bytes
This commit is contained in:
Denis Vlasenko
2007-06-04 10:16:52 +00:00
parent 4e5f82c76f
commit 74324c8666
21 changed files with 141 additions and 135 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
networking/nc.c
View File

@ -174,11 +174,10 @@ int nc_main(int argc, char **argv)
if (select(FD_SETSIZE, &testfds, NULL, NULL, NULL) < 0)
bb_perror_msg_and_die("select");
#define iobuf bb_common_bufsiz1
for (fd = 0; fd < FD_SETSIZE; fd++) {
if (FD_ISSET(fd, &testfds)) {
nread = safe_read(fd, bb_common_bufsiz1,
sizeof(bb_common_bufsiz1));
nread = safe_read(fd, iobuf, sizeof(iobuf));
if (fd == cfd) {
if (nread < 1)
exit(0);
@ -192,8 +191,7 @@ int nc_main(int argc, char **argv)
}
ofd = cfd;
}
xwrite(ofd, bb_common_bufsiz1, nread);
xwrite(ofd, iobuf, nread);
if (delay > 0) sleep(delay);
}
}