emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ubi tools: ubiupdatevol supports "-" input and actually respects -s SIZE

Browse Source 
Decided to not make any flash applets NOEXEC.
Minor robustifications here and there. Better error messages. Save on strings:

function                                             old     new   delta
ubi_tools_main                                      1235    1288     +53
ubi_get_volid_by_name                                125     133      +8
ubirename_main                                       198     204      +6
get_num_from_file                                     90      94      +4
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 4/0 up/down: 71/0)               Total: 71 bytes
   text	   data	    bss	    dec	    hex	filename
 915696	    485	   6880	 923061	  e15b5	busybox_old
 915670	    485	   6880	 923035	  e159b	busybox_unstripped

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko
2017-08-07 16:00:25 +02:00
parent b34eb4a591
commit 798b94518e
7 changed files with 59 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
NOFORK_NOEXEC.lst
View File

@@ -123,10 +123,10 @@ fgconsole - noexec. leaks: get_console_fd_or_die() may open a new fd, or return
fgrep - longterm runner ("CMD | fgrep ..." may run indefinitely, better to exec to conserve memory)
find - noexec. runner
findfs - suid
flash_eraseall
flash_lock
flash_unlock
flashcp - needs ^C. flash writing may be slow, better to free memory by execing
flash_eraseall - could be noexec, but I feel flash ops are risky (prone to hw/fw/sw bugs)
flash_lock - could be noexec, but I feel flash ops are risky (prone to hw/fw/sw bugs)
flash_unlock - could be noexec, but I feel flash ops are risky (prone to hw/fw/sw bugs)
flashcp - needs ^C. could be noexec, but I feel flash ops are risky (prone to hw/fw/sw bugs)
flock - spawner, changes state (file locks), let's play safe and not be noexec
fold - noexec. runner
free - nofork candidate(struct globals, needs to close /proc/meminfo fd)
@@ -366,13 +366,13 @@ tty - NOFORK
ttysize - NOFORK
tunctl - noexec
tune2fs - noexec. leaks: open+xfunc
ubiattach
ubidetach
ubimkvol
ubirename
ubirmvol
ubirsvol
ubiupdatevol
ubiattach - could be noexec, but I feel flash ops are risky (prone to hw/fw/sw bugs)
ubidetach - could be noexec, but I feel flash ops are risky (prone to hw/fw/sw bugs)
ubimkvol - could be noexec, but I feel flash ops are risky (prone to hw/fw/sw bugs)
ubirename - could be noexec, but I feel flash ops are risky (prone to hw/fw/sw bugs)
ubirmvol - could be noexec, but I feel flash ops are risky (prone to hw/fw/sw bugs)
ubirsvol - could be noexec, but I feel flash ops are risky (prone to hw/fw/sw bugs)
ubiupdatevol - could be noexec, but I feel flash ops are risky (prone to hw/fw/sw bugs)
udhcpc - daemon
udhcpd - daemon
udpsvd - daemon