From 834aba3b72cb0e45153b95fed991522f7f1986c9 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Fri, 4 Nov 2016 14:13:58 +0100 Subject: [PATCH] comment and readme updates Signed-off-by: Denys Vlasenko --- libbb/common_bufsiz.c | 9 +++++++++ loginutils/README | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/libbb/common_bufsiz.c b/libbb/common_bufsiz.c index 1a3585169..2847eb57d 100644 --- a/libbb/common_bufsiz.c +++ b/libbb/common_bufsiz.c @@ -54,6 +54,15 @@ char bb_common_bufsiz1[COMMON_BUFSIZE] ALIGNED(sizeof(long long)); #else # ifndef setup_common_bufsiz +/* For now, this is never used: + * scripts/generate_BUFSIZ.sh never generates "malloced" bufsiz1: + * enum { COMMON_BUFSIZE = 1024 }; + * extern char *const bb_common_bufsiz1; + * void setup_common_bufsiz(void); + * This has proved to be worse than the approach of defining + * larger bb_common_bufsiz1[] array. + */ + /* * It is not defined as a dummy macro. * It means we have to provide this function. diff --git a/loginutils/README b/loginutils/README index ce8851097..847b371b3 100644 --- a/loginutils/README +++ b/loginutils/README @@ -23,7 +23,7 @@ Getty should establish a new session and process group, and ensure that tty is a ctty. ??? Should getty ensure that other processes which might have opened -fds to this tty be dusconnected? agetty has a -R option which makes +fds to this tty be disconnected? agetty has a -R option which makes agetty call vhangup() after tty is opened. (Then agetty opens it again, since it probably vhangup'ed its own fd too).