last_patch89 from vodz:
Manuel, I rewrite bb_getopt_ulflags() function for more universal usage. My version support now: - options with arguments (optional arg as GNU extension also) - complementaly and/or incomplementaly and/or incongruously and/or list options - long_opt (all applets may have long option, add supporting is trivial) This realisation full compatibile from your version. Code size grow 480 bytes, but only coreutils/* over compensate this size after using new function. Last patch reduced over 800 bytes and not full applied to all. "mkdir" and "mv" applets have long_opt now for demonstrate trivial addition support long_opt with usage new bb_getopt_ulflags(). Complementaly and/or incomplementaly and/or incongruously and/or list options logic is not trivial, but new "cut" and "grep" applets using this logic for examples with full demostrating. New "grep" applet reduced over 300 bytes. Mark, Also. I removed bug from "grep" applet. $ echo a b | busybox grep -e a b a b a b But right is printing one only. --w vodz
This commit is contained in:
@@ -122,6 +122,17 @@ static int addgroup(const char *filename, char *group, gid_t gid, const char *us
|
||||
return 0;
|
||||
}
|
||||
|
||||
#ifndef CONFIG_ADDUSER
|
||||
static inline void if_i_am_not_root(void)
|
||||
{
|
||||
if (geteuid()) {
|
||||
bb_error_msg_and_die( "Only root may add a user or group to the system.");
|
||||
}
|
||||
}
|
||||
#else
|
||||
extern void if_i_am_not_root(void);
|
||||
#endif
|
||||
|
||||
/*
|
||||
* addgroup will take a login_name as its first parameter.
|
||||
*
|
||||
@@ -131,21 +142,13 @@ static int addgroup(const char *filename, char *group, gid_t gid, const char *us
|
||||
* ________________________________________________________________________ */
|
||||
int addgroup_main(int argc, char **argv)
|
||||
{
|
||||
int opt;
|
||||
char *group;
|
||||
char *user;
|
||||
gid_t gid = 0;
|
||||
|
||||
/* get remaining args */
|
||||
while ((opt = getopt (argc, argv, "g:")) != -1) {
|
||||
switch (opt) {
|
||||
case 'g':
|
||||
gid = strtol(optarg, NULL, 10);
|
||||
break;
|
||||
default:
|
||||
bb_show_usage();
|
||||
break;
|
||||
}
|
||||
if(bb_getopt_ulflags(argc, argv, "g:", &group)) {
|
||||
gid = strtol(group, NULL, 10);
|
||||
}
|
||||
|
||||
if (optind < argc) {
|
||||
@@ -161,14 +164,8 @@ int addgroup_main(int argc, char **argv)
|
||||
} else {
|
||||
user = "";
|
||||
}
|
||||
|
||||
if (geteuid() != 0) {
|
||||
bb_error_msg_and_die
|
||||
("Only root may add a group to the system.");
|
||||
}
|
||||
if_i_am_not_root();
|
||||
|
||||
/* werk */
|
||||
return addgroup(bb_path_group_file, group, gid, user);
|
||||
}
|
||||
|
||||
/* $Id: addgroup.c,v 1.10 2003/03/19 09:12:20 mjn3 Exp $ */
|
||||
|
Reference in New Issue
Block a user