emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tar: improve comments, add FIXMEs. no code changes

Browse Source 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2021-10-08 19:34:20 +02:00
parent 049775b2ef
commit b198e9aa93
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
archival/libarchive/get_header_tar.c
View File

@ -332,7 +332,6 @@ char FAST_FUNC get_header_tar(archive_handle_t *archive_handle)
} }
/* Set bits 12-15 of the files mode */ /* Set bits 12-15 of the files mode */
/* (typeflag was not trashed because chksum does not use getOctal) */
switch (tar_typeflag) { switch (tar_typeflag) {
case '1': /* hardlink */ case '1': /* hardlink */
/* we mark hardlinks as regular files with zero size and a link name */ /* we mark hardlinks as regular files with zero size and a link name */
@ -341,7 +340,7 @@ char FAST_FUNC get_header_tar(archive_handle_t *archive_handle)
* ... For tar archives written by pre POSIX.1-1988 * ... For tar archives written by pre POSIX.1-1988
* implementations, the size field usually contains the size of * implementations, the size field usually contains the size of
* the file and needs to be ignored as no data may follow this * the file and needs to be ignored as no data may follow this
* header type. For POSIX.1- 1988 compliant archives, the size * header type. For POSIX.1-1988 compliant archives, the size
* field needs to be 0. For POSIX.1-2001 compliant archives, * field needs to be 0. For POSIX.1-2001 compliant archives,
* the size field may be non zero, indicating that file data is * the size field may be non zero, indicating that file data is
* included in the archive. * included in the archive.
@ -390,6 +389,7 @@ char FAST_FUNC get_header_tar(archive_handle_t *archive_handle)
/* free: paranoia: tar with several consecutive longnames */ /* free: paranoia: tar with several consecutive longnames */
free(p_longname); free(p_longname);
/* For paranoia reasons we allocate extra NUL char */ /* For paranoia reasons we allocate extra NUL char */
//FIXME: disallow huge sizes:
p_longname = xzalloc(file_header->size + 1); p_longname = xzalloc(file_header->size + 1);
/* We read ASCIZ string, including NUL */ /* We read ASCIZ string, including NUL */
xread(archive_handle->src_fd, p_longname, file_header->size); xread(archive_handle->src_fd, p_longname, file_header->size);
@ -400,6 +400,7 @@ char FAST_FUNC get_header_tar(archive_handle_t *archive_handle)
goto again; goto again;
case 'K': case 'K':
free(p_linkname); free(p_linkname);
//FIXME: disallow huge sizes:
p_linkname = xzalloc(file_header->size + 1); p_linkname = xzalloc(file_header->size + 1);
xread(archive_handle->src_fd, p_linkname, file_header->size); xread(archive_handle->src_fd, p_linkname, file_header->size);
archive_handle->offset += file_header->size; archive_handle->offset += file_header->size;