emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

renice: add comment about getpwnam/NOFORK interaction

Browse Source 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2018-01-14 19:40:00 +01:00
parent 9967978551
commit c4144ca3a5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
util-linux/renice.c
View File

@ -6,7 +6,6 @@
* *
* Licensed under GPLv2 or later, see file LICENSE in this source tree. * Licensed under GPLv2 or later, see file LICENSE in this source tree.
*/ */
/* Notes: /* Notes:
* Setting an absolute priority was obsoleted in SUSv2 and removed * Setting an absolute priority was obsoleted in SUSv2 and removed
* in SUSv3. However, the common linux version of renice does * in SUSv3. However, the common linux version of renice does
@ -95,6 +94,7 @@ int renice_main(int argc UNUSED_PARAM, char **argv)
/* Process an ID arg. */ /* Process an ID arg. */
if (which == PRIO_USER) { if (which == PRIO_USER) {
struct passwd *p; struct passwd *p;
/* NB: use of getpwnam makes it risky to be NOFORK, switch to getpwnam_r? */
p = getpwnam(arg); p = getpwnam(arg);
if (!p) { if (!p) {
bb_error_msg("unknown user %s", arg); bb_error_msg("unknown user %s", arg);