emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libbb: fix bb_ask() to flush input before prompt, not after. Closes 7190

Browse Source 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2014-07-01 13:20:22 +02:00
parent 184b266917
commit d32fc647d7
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libbb/bb_askpass.c
View File

@ -30,9 +30,12 @@ char* FAST_FUNC bb_ask(const int fd, int timeout, const char *prompt)
struct sigaction sa, oldsa; struct sigaction sa, oldsa;
struct termios tio, oldtio; struct termios tio, oldtio;
tcflush(fd, TCIFLUSH);
/* Was buggy: was printing prompt *before* flushing input,
* which was upsetting "expect" based scripts of some users.
*/
fputs(prompt, stdout); fputs(prompt, stdout);
fflush_all(); fflush_all();
tcflush(fd, TCIFLUSH);
tcgetattr(fd, &oldtio); tcgetattr(fd, &oldtio);
tio = oldtio; tio = oldtio;