emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

msh: style fixes

Browse Source 
shell/README - a place to record things about busybox shells
This commit is contained in:
Denis Vlasenko 2007-04-14 15:08:41 +00:00
parent 5f9468e996
commit e471275813
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
shell/README Normal file
View File

@ -0,0 +1,6 @@
Various bits of what is known about busybox shells, in no particular order.
2007-04-14
lash, hush: both do setsid() and as a result don't have ctty!
Ctrl-C doesn't work for any child (try rm -i), etc...
lash: bare ">file" doesn't create a file (hush works)

10
shell/msh.c
View File

@ -2117,7 +2117,6 @@ static struct op *newtp(void)
static struct op *namelist(struct op *t) static struct op *namelist(struct op *t)
{ {
DBGPRINTF7(("NAMELIST: enter, t=%p, type %s, iolist=%p\n", t, DBGPRINTF7(("NAMELIST: enter, t=%p, type %s, iolist=%p\n", t,
T_CMD_NAMES[t->type], iolist)); T_CMD_NAMES[t->type], iolist));
@ -2658,7 +2657,7 @@ static int execute(struct op *t, int *pin, int *pout, int act)
}; };
broken: broken:
t->words = wp2; t->words = wp2;
isbreak = 0; isbreak = 0;
freehere(areanum); freehere(areanum);
@ -2681,13 +2680,13 @@ static int execute(struct op *t, int *pin, int *pout, int act)
typedef int (*builtin_func_ptr)(struct op *); typedef int (*builtin_func_ptr)(struct op *);
static builtin_func_ptr inbuilt(const char *s) { static builtin_func_ptr inbuilt(const char *s)
{
const struct builtincmd *bp; const struct builtincmd *bp;
for (bp = builtincmds; bp->name; bp++) for (bp = builtincmds; bp->name; bp++)
if (strcmp(bp->name, s) == 0) if (strcmp(bp->name, s) == 0)
return bp->builtinfunc; return bp->builtinfunc;
return NULL; return NULL;
} }
@ -4379,8 +4378,7 @@ static struct wdblock *addword(char *wd, struct wdblock *wb)
return wb; return wb;
} }
static static char **getwords(struct wdblock *wb)
char **getwords(struct wdblock *wb)
{ {
char **wd; char **wd;
int nb; int nb;