emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

udhcpc: do not use inet_addr() to parse -r REQ_IP, it's deprecated

Browse Source 
...and we did not error-check it, and this is the only use of it:

function                                             old     new   delta
inet_addr                                             37       -     -37

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2021-06-15 01:42:21 +02:00
parent 9e27fed6b9
commit ebe8c14d34
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
networking/udhcp/dhcpc.c
View File

@ -1284,7 +1284,8 @@ int udhcpc_main(int argc UNUSED_PARAM, char **argv)
memcpy(p + OPT_DATA + 3, str_F, len); /* do not store NUL byte */ memcpy(p + OPT_DATA + 3, str_F, len); /* do not store NUL byte */
} }
if (opt & OPT_r) if (opt & OPT_r)
requested_ip = inet_addr(str_r); if (!inet_aton(str_r, (void*)&requested_ip))
bb_show_usage();
#if ENABLE_FEATURE_UDHCP_PORT #if ENABLE_FEATURE_UDHCP_PORT
if (opt & OPT_P) { if (opt & OPT_P) {
CLIENT_PORT = xatou16(str_P); CLIENT_PORT = xatou16(str_P);