busybox

Author	SHA1	Message	Date
Ron Yorston	0b6ec06beb	kill: add '--' option to separate options from arguments Using a negative pid to send TERM to a process group results in an obscure error: $ ./busybox kill -12345 kill: bad signal name '12345' This is intended. Manpage says: ARGUMENTS pid Each pid can be one of four things: ... -n where n is larger than 1. All processes in process group n are signaled. When an argument of the form '-n' is given, and it is meant to denote a process group, either a signal must be specified first, or the argument must be preceded by a '--' option, otherwise it will be taken as the signal to send. However, we did not support "--". Add this capability to BusyBox. function old new delta kill_main 993 999 +6 Signed-off-by: Ron Yorston <rmy@pobox.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-28 14:03:13 +02:00
Ron Yorston	0ec0fac045	ps: fix build failure if FEATURE_PS_TIME is disabled The global seconds_since_boot is only defined if FEATURE_PS_TIME is enabled. Signed-off-by: Ron Yorston <rmy@pobox.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-22 15:39:13 +02:00
Kang-Che Sung	753c4045e4	ps: allow ps config options if minips is enabled Follow-up of commit `ab77e81a85` "klibc-utils: new applets: resume, nuke, minips" Also put FEATURE_PS_UNUSUAL_SYSTEMS to under FEATURE_PS_TIME in the menu. Signed-off-by: Kang-Che Sung <explorer09@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-22 11:00:32 +02:00
Denys Vlasenko	ab77e81a85	klibc-utils: new applets: resume, nuke, minips minips is a pure alias to ps, just in case someone needs 100% klibc-utils compat. nuke is a primitive version of "rm -rf" without options and error checks. ~30 bytes. resume is a tool for initramfs which resumes from a given block device. function old new delta resume_main - 582 +582 packed_usage 31640 31712 +72 nuke_main - 28 +28 xstrtoull - 24 +24 applet_names 2646 2665 +19 applet_main 1532 1544 +12 applet_suid 96 97 +1 applet_install_loc 192 193 +1 applet_flags 96 97 +1 ------------------------------------------------------------------------------ (add/remove: 5/0 grow/shrink: 6/0 up/down: 740/0) Total: 740 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-18 19:15:29 +02:00
Denys Vlasenko	e440b39416	*: stop using atexit in non-debug build: saves ~260 in bss with musl "builtin" below is atexit's 32-element global array of functions to call. function old new delta top_main 879 889 +10 launch_helper 185 193 +8 powertop_main 1555 1559 +4 sed_main 651 650 -1 slot 4 - -4 call 4 - -4 atexit 23 - -23 kill_helper 31 - -31 __funcs_on_exit 120 - -120 __cxa_atexit 168 - -168 builtin 260 - -260 ------------------------------------------------------------------------------ (add/remove: 0/8 grow/shrink: 3/1 up/down: 22/-611) Total: -589 bytes text data bss dec hex filename 912364 563 6132 919059 e0613 busybox_old 912035 563 5844 918442 e03aa busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-16 17:45:32 +02:00
Denys Vlasenko	d80302db99	top: switch to malloced "globals". This seems to be more efficient: function old new delta clearmems - 28 +28 display_process_list 1001 1018 +17 read_cpu_jiffy 171 177 +6 do_stats 194 198 +4 reset_term 20 23 +3 topmem_sort 63 65 +2 mult_lvl_cmp 44 45 +1 get_jiffy_counts 247 248 +1 display_topmem_process_list 549 546 -3 top_main 912 879 -33 handle_input 630 549 -81 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 7/3 up/down: 62/-117) Total: -55 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-16 11:40:10 +02:00
Denys Vlasenko	9c7c63b5c2	ps: improve TIME column for large times: showing "14453:50" is not good function old new delta format_time - 110 +110 func_time 59 50 -9 func_etime 67 53 -14 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 0/2 up/down: 110/-23) Total: 87 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-10 15:02:16 +02:00
Denys Vlasenko	9a6f62fd51	ps: make it NOEXEC Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-10 14:15:52 +02:00
Denys Vlasenko	1fd8e66203	ps: stop using AT_CLKTCK, there are more standard ways function old new delta ps_main 537 558 +21 func_time 66 59 -7 get_kernel_HZ 102 - -102 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 1/1 up/down: 21/-109) Total: -88 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-10 14:10:56 +02:00
Denys Vlasenko	22542eca18	getopt32: remove opt_complementary function old new delta vgetopt32 1318 1392 +74 runsvdir_main 703 713 +10 bb_make_directory 423 425 +2 collect_cpu 546 545 -1 opt_chars 3 - -3 opt_complementary 4 - -4 tftpd_main 567 562 -5 ntp_init 476 471 -5 zcip_main 1266 1256 -10 xxd_main 428 418 -10 whois_main 140 130 -10 who_main 463 453 -10 which_main 212 202 -10 wget_main 2535 2525 -10 watchdog_main 291 281 -10 watch_main 222 212 -10 vlock_main 399 389 -10 uuencode_main 332 322 -10 uudecode_main 316 306 -10 unlink_main 45 35 -10 udhcpd_main 1482 1472 -10 udhcpc_main 2762 2752 -10 tune2fs_main 290 280 -10 tunctl_main 366 356 -10 truncate_main 218 208 -10 tr_main 518 508 -10 time_main 1134 1124 -10 tftp_main 286 276 -10 telnetd_main 1873 1863 -10 tcpudpsvd_main 1785 1775 -10 taskset_main 521 511 -10 tar_main 1009 999 -10 tail_main 1644 1634 -10 syslogd_main 1967 1957 -10 switch_root_main 368 358 -10 svlogd_main 1454 1444 -10 sv 1296 1286 -10 stat_main 104 94 -10 start_stop_daemon_main 1028 1018 -10 split_main 542 532 -10 sort_main 796 786 -10 slattach_main 624 614 -10 shuf_main 504 494 -10 setsid_main 96 86 -10 setserial_main 1132 1122 -10 setfont_main 388 378 -10 setconsole_main 78 68 -10 sendmail_main 1209 1199 -10 sed_main 677 667 -10 script_main 1077 1067 -10 run_parts_main 325 315 -10 rtcwake_main 454 444 -10 rm_main 175 165 -10 reformime_main 119 109 -10 readlink_main 123 113 -10 rdate_main 246 236 -10 pwdx_main 189 179 -10 pstree_main 317 307 -10 pscan_main 663 653 -10 popmaildir_main 818 808 -10 pmap_main 80 70 -10 nc_main 1042 1032 -10 mv_main 558 548 -10 mountpoint_main 477 467 -10 mount_main 1264 1254 -10 modprobe_main 768 758 -10 modinfo_main 333 323 -10 mktemp_main 200 190 -10 mkswap_main 324 314 -10 mkfs_vfat_main 1489 1479 -10 microcom_main 715 705 -10 md5_sha1_sum_main 521 511 -10 man_main 867 857 -10 makedevs_main 1052 1042 -10 ls_main 563 553 -10 losetup_main 432 422 -10 loadfont_main 89 79 -10 ln_main 524 514 -10 link_main 75 65 -10 ipcalc_main 544 534 -10 iostat_main 2397 2387 -10 install_main 768 758 -10 id_main 480 470 -10 i2cset_main 1239 1229 -10 i2cget_main 380 370 -10 i2cdump_main 1482 1472 -10 i2cdetect_main 682 672 -10 hwclock_main 406 396 -10 httpd_main 741 731 -10 grep_main 837 827 -10 getty_main 1559 1549 -10 fuser_main 297 287 -10 ftpgetput_main 345 335 -10 ftpd_main 2232 2222 -10 fstrim_main 251 241 -10 fsfreeze_main 77 67 -10 fsck_minix_main 2921 2911 -10 flock_main 314 304 -10 flashcp_main 740 730 -10 flash_eraseall_main 833 823 -10 fdformat_main 532 522 -10 expand_main 680 670 -10 eject_main 335 325 -10 dumpleases_main 630 620 -10 du_main 314 304 -10 dos2unix_main 441 431 -10 diff_main 1350 1340 -10 df_main 1064 1054 -10 date_main 1095 1085 -10 cut_main 961 951 -10 cryptpw_main 228 218 -10 crontab_main 575 565 -10 crond_main 1149 1139 -10 cp_main 370 360 -10 common_traceroute_main 3834 3824 -10 common_ping_main 1767 1757 -10 comm_main 239 229 -10 cmp_main 655 645 -10 chrt_main 379 369 -10 chpst_main 704 694 -10 chpasswd_main 308 298 -10 chown_main 171 161 -10 chmod_main 158 148 -10 cat_main 428 418 -10 bzip2_main 120 110 -10 blkdiscard_main 264 254 -10 base64_main 221 211 -10 arping_main 1665 1655 -10 ar_main 556 546 -10 adjtimex_main 406 396 -10 adduser_main 882 872 -10 addgroup_main 411 401 -10 acpid_main 1198 1188 -10 optstring 11 - -11 opt_string 18 - -18 OPT_STR 25 - -25 ubi_tools_main 1288 1258 -30 ls_options 31 - -31 ------------------------------------------------------------------------------ (add/remove: 0/6 grow/shrink: 3/129 up/down: 86/-1383) Total: -1297 bytes text data bss dec hex filename 915428 485 6876 922789 e14a5 busybox_old 914629 485 6872 921986 e1182 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-08 21:55:02 +02:00
Denys Vlasenko	248a67fb75	free,stat: make NOEXEC pkill/pgrep/pidof uncovered another quirk: what about noexec's _process names_? Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-07 18:18:09 +02:00
Denys Vlasenko	1a1203ff89	users,w,who,uptime,renice: make NOEXEC Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-07 16:47:34 +02:00
Denys Vlasenko	a759b22c29	nameif: make it NOEXEC Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-06 14:15:24 +02:00
Denys Vlasenko	00c1811d87	pstree: make it NOEXEC While at it, documet why ps can't be NOEXEC. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-05 22:25:00 +02:00
Denys Vlasenko	caf26b36f3	sysctl: make it NOEXEC Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-05 18:23:10 +02:00
Denys Vlasenko	50db1f29bf	sysctl: recognize ";comment" and "<whitespace>#comment" lines function old new delta config_read 639 699 +60 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-05 18:20:34 +02:00
Denys Vlasenko	20077c1429	libbb: make trim() return pointer to terminating NUL function old new delta trim 80 90 +10 angle_address 56 50 -6 sysctl_main 282 273 -9 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/3 up/down: +10/-15) Total: -5 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-05 17:50:35 +02:00
Denys Vlasenko	9cf89cdf84	sysctl: fix file parsing, do not require -w for VAR=VAL function old new delta sysctl_act_on_setting - 451 +451 sysctl_main 222 282 +60 packed_usage 31744 31793 +49 config_read 604 639 +35 sysctl_act_recursive 612 163 -449 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 3/1 up/down: 595/-449) Total: 146 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-05 13:45:22 +02:00
Denys Vlasenko	947b2391c0	pmap: tweak help text, show usage if no params are given Noticed while auditing nofork/noexec status function old new delta pmap_main 70 80 +10 packed_usage 31747 31744 -3 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-04 18:37:34 +02:00
Denys Vlasenko	727948e585	getopt32: factor out code to treat all args as options Working towards making getopt32() xmalloc-free function old new delta make_all_argv_opts - 58 +58 top_main 914 912 -2 getopt32 1517 1458 -59 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 0/2 up/down: 58/-61) Total: -3 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-04 16:33:23 +02:00
Denys Vlasenko	39194f0309	new NOFORKs: pwdx,kill[all5],ttysize,realpath,readlink NOEXECs: date,resize function old new delta run_nofork_applet 258 280 +22 readlink_main 112 123 +11 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 33/0) Total: 33 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-03 19:03:32 +02:00
Denys Vlasenko	69be994de6	ps: tweak outdated comment, no code changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-29 02:27:12 +02:00
Denys Vlasenko	5d725fd627	ps: implement -o sid function old new delta func_sid - 29 +29 out_spec 320 340 +20 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 1/0 up/down: 49/0) Total: 49 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-29 02:20:17 +02:00
Denys Vlasenko	86981e3ad2	ash: allow "trap NUM [SIG]..." syntax While at it, make get_signum() return -1 for numeric strings >= NSIG. function old new delta trapcmd 292 306 +14 get_signum 295 300 +5 builtin_trap 413 412 -1 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/1 up/down: 19/-1) Total: 18 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-25 20:06:17 +02:00
Denys Vlasenko	578008a989	pgrep: fix "pgrep -v -P1"; also allow matching of comm - closes 10086 function old new delta pgrep_main 662 720 +58 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-21 17:43:14 +02:00
Denys Vlasenko	72089cf6b4	config: deindent all help texts Those two spaces after tab have no effect, and always a nuisance when editing. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-21 09:50:55 +02:00
Denys Vlasenko	4eed2c6c50	Update menuconfig items with approximate applet sizes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-18 22:01:24 +02:00
Denys Vlasenko	9f4b4226a4	pgrep: implement -a function old new delta pgrep_main 640 726 +86 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-06-26 21:10:47 +02:00
Denys Vlasenko	4add757929	pgrep: fix pgrep -flx "sleep 11" - saw "sleep 11" processes as "sleep 11 " function old new delta pgrep_main 584 597 +13 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-06-26 14:41:53 +02:00
Denys Vlasenko	5d72ae53c9	fix "ifdef ENABLE_foo": should always be "#if ENABLE_foo" function old new delta pack_gzip 1729 1789 +60 fill_window 220 216 -4 static.gzip_level_config 24 - -24 gzip_main 275 192 -83 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 1/2 up/down: 60/-111) Total: -51 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-06-15 17:11:59 +02:00
Denys Vlasenko	d9eb40c185	fix errors found with make_single_applets.sh Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-12 15:48:19 +02:00
Denys Vlasenko	0cecbe7d5d	Sort more misplaced applets into coreutils or util-linux No code changes Surprisingly, nice and renice are coming from different packages :) Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-12 14:16:29 +02:00
Denys Vlasenko	205d48e948	*: add comment about APPLET_ODDNAME format It confused me more than once Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-29 14:57:33 +01:00
Denys Vlasenko	f3d705f41b	make --help texts smaller function old new delta packed_usage 31035 30968 -67 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-21 03:46:57 +01:00
Denys Vlasenko	4e08a123b0	Assorted warning fixes and added a comment, no code changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-16 17:31:05 +01:00
Denys Vlasenko	6c1f348fa7	Move FEATURE_USE_TERMIOS config option to two applets which use it No code changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-11 16:27:12 +01:00
Denys Vlasenko	01ccdd1d3c	libbb: consolidate the code to set termios unbuffered mode function old new delta set_termios_to_raw - 116 +116 count_lines 72 74 +2 powertop_main 1458 1430 -28 top_main 943 914 -29 more_main 759 714 -45 fsck_minix_main 2969 2921 -48 conspy_main 1197 1135 -62 rawmode 99 36 -63 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 1/6 up/down: 118/-275) Total: -157 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-11 16:17:59 +01:00
Denys Vlasenko	0fd9fb4244	top: FEATURE_USE_TERMIOS shouldn't control reading of screen size It controls whether we take input. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-11 10:50:08 +01:00
Denys Vlasenko	f560422fa0	Big cleanup in config help and description Redundant help texts (one which only repeats the description) are deleted. Descriptions and help texts are trimmed. Some config options are moved, even across menus. No config option _names_ are changed. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-10 14:58:54 +01:00
Kang-Che Sung	61a91af63d	kill: optimizations for single-applet build * Fix a bug with a configuration in which the shell's kill builtin would be mistreated as a killall command (i.e. '-q' works, and 'kill process_name' succeeds when it shouldn't): CONFIG_ASH_JOB_CONTROL=y CONFIG_HUSH_KILL=y # CONFIG_KILL is not set CONFIG_KILLALL=y # CONFIG_KILLALL5 is not set * Optimize out unneeded code when the relevant applets are not selected. * Move kbuild lines about shells' kill builtins from Kbuild.src to kill.c, to accompany the new HAVE_SH_KILL macro. I hope this would make maintanence a little bit easier. Signed-off-by: Kang-Che Sung <explorer09@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-09 18:46:58 +01:00
Kang-Che Sung	53487a8d22	kill: need not build kill.c when ash's job control is off ash kill builtin depends on the job control config option. Signed-off-by: Kang-Che Sung <explorer09@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-09 17:02:51 +01:00
Denys Vlasenko	1125d7d680	hush: kill builtin and kill %jobspec support Also made it and printf, type and wait builtins optional. function old new delta builtin_kill - 323 +323 bltins1 336 348 +12 builtin_type 114 116 +2 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 2/0 up/down: 337/0) Total: 337 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-08 17:19:38 +01:00
Kang-Che Sung	a474728e82	ash: fix "kill %1" not working if CONFIG_ASH is disabled ix ash "kill %1" not working if CONFIG_ASH is disabled but ash is launched by 'sh' or 'bash' name Signed-off-by: Kang-Che Sung <explorer09@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-08 14:27:34 +01:00
Denys Vlasenko	0b8835861b	Make it possible to select "sh" and "bash" aliases without selecting ash or hush The same can be done for msh, but we are probably better off just deleting it in a next versio or two. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-12-23 16:56:43 +01:00
Denys Vlasenko	718e4fd564	top: fix help text: with !TERMIOS, no keys are affected top output Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-12-03 12:09:50 +01:00
Denys Vlasenko	1d3a04a3a4	Code style fixes, no code changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-28 01:22:57 +01:00
Denys Vlasenko	5467d268f0	Make killall and killall5 selecatable independent from kill Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-23 06:43:46 +01:00
Denys Vlasenko	f8f81ed7aa	Convert all procps/* applets to "new style" applet definitions Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-23 06:23:44 +01:00
Denys Vlasenko	aedc3fe19f	top: move free(prev_hist) out of signal path It was seen being called recursively on repeated signals, leading to double free Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-08-19 11:07:31 +02:00
Denys Vlasenko	237bedd499	getopt32: add new syntax of 'o:+' and 'o:*' for -o NUM and -o LIST In many cases, this aqllows to drop use of opt_complementary. Approximately -400 bytes: function old new delta getopt32 1423 1502 +79 opt_string 17 18 +1 OPT_STR 24 25 +1 uniq_main 416 406 -10 timeout_main 279 269 -10 sulogin_main 270 260 -10 readprofile_main 1825 1815 -10 ps_main 543 533 -10 pidof_main 245 235 -10 pgrep_main 611 601 -10 od_main 2600 2590 -10 mkfs_minix_main 2684 2674 -10 mkfs_ext2_main 2603 2593 -10 microcom_main 712 702 -10 makemime_main 315 305 -10 ionice_main 282 272 -10 inetd_main 2074 2064 -10 ifplugd_main 1144 1134 -10 halt_main 353 343 -10 getopt_main 636 626 -10 fdisk_main 2854 2844 -10 env_main 206 196 -10 dmesg_main 319 309 -10 conspy_main 1214 1204 -10 awk_main 981 971 -10 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/22 up/down: 81/-220) Total: -139 bytes text data bss dec hex filename 919373 906 14060 934339 e41c3 busybox_old 918969 906 14060 933935 e402f busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-07-06 21:58:02 +02:00
Denys Vlasenko	3e134ebf6a	: slap on a few ALIGN1/2s where appropriate The result of looking at "grep -F -B2 'fill*' busybox_unstripped.map" text data bss dec hex filename 829901 4086 1904 835891 cc133 busybox_before 829665 4086 1904 835655 cc047 busybox Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-04-22 18:09:21 +02:00
Denys Vlasenko	9de2e5a222	*: hopefully all setup_common_bufsiz() are in place Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-04-21 18:38:51 +02:00
Denys Vlasenko	47cfbf32fd	*: add most of the required setup_common_bufsiz() calls Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-04-21 18:18:48 +02:00
Denys Vlasenko	e6a2f4cc5a	libbb: make bb_common_bufsiz1 1 kbyte, add capability to use bss tail for it The config item is FEATURE_USE_BSS_TAIL. When it is off (default): function old new delta read_config 210 228 +18 doCommands 2279 2294 +15 ipneigh_list_or_flush 763 772 +9 ipaddr_list_or_flush 1256 1261 +5 display_process_list 1301 1306 +5 conspy_main 1378 1383 +5 do_lzo_compress 352 355 +3 do_lzo_decompress 565 567 +2 push 46 44 -2 inetd_main 2136 2134 -2 uevent_main 421 418 -3 addLines 97 92 -5 bb_common_bufsiz1 8193 1024 -7169 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 8/5 up/down: 62/-7181) Total: -7119 bytes text data bss dec hex filename 829850 4086 9080 843016 cdd08 busybox_old 829901 4086 1904 835891 cc133 busybox_unstripped FEATURE_USE_BSS_TAIL=y: read_config 210 228 +18 doCommands 2279 2294 +15 ipneigh_list_or_flush 763 772 +9 ipaddr_list_or_flush 1256 1261 +5 display_process_list 1301 1306 +5 conspy_main 1378 1383 +5 do_lzo_compress 352 355 +3 do_lzo_decompress 565 567 +2 inetd_main 2136 2134 -2 bb_common_bufsiz1 8193 - -8193 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 8/1 up/down: 62/-8195) Total: -8133 bytes text data bss dec hex filename 829850 4086 9080 843016 cdd08 busybox_old 829911 4086 880 834877 cbd3d busybox_unstripped FIXME: setup_common_bufsiz() calls are missing. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-04-21 17:39:11 +02:00
Denys Vlasenko	0d1b71e8e6	nmeter: reinstate and document -d-1 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-03-15 17:54:17 +01:00
Denys Vlasenko	41b1e2c392	nmeter: remove undocumented %NNNd specifier function old new delta nmeter_main 707 745 +38 init_functions 48 44 -4 init_delay 63 - -63 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 1/1 up/down: 38/-67) Total: -29 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-03-15 16:13:23 +01:00
Denys Vlasenko	a63e2a8cb2	nmeter: simple code shrink here and there function old new delta nmeter_main 709 707 -2 init_cr 15 12 -3 collect_time 141 131 -10 collect_cpu 610 593 -17 init_cpu 82 63 -19 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/5 up/down: 0/-51) Total: -51 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-03-15 16:06:29 +01:00
Denys Vlasenko	8a26fda98c	nmeter: convert field list to bit list function old new delta rdval 34 157 +123 collect_int 123 122 -1 collect_thread_nr 65 62 -3 collect_blk 559 552 -7 collect_if 207 199 -8 collect_fork 119 111 -8 collect_ctx 119 111 -8 collect_fd 81 71 -10 collect_swp 120 107 -13 collect_cpu 623 610 -13 collect_mem 371 339 -32 rdval_loadavg 38 - -38 vrdval 170 - -170 ------------------------------------------------------------------------------ (add/remove: 0/2 grow/shrink: 1/10 up/down: 123/-311) Total: -188 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-03-15 15:52:40 +01:00
Denys Vlasenko	99c71c9e80	nmeter: code shrink function old new delta put 52 43 -9 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-03-15 15:28:49 +01:00
Denys Vlasenko	e4de8c6316	nmeter: fix a bug with unterminated varargs function old new delta collect_mem 361 371 +10 collect_swp 116 120 +4 vrdval 168 170 +2 collect_thread_nr 63 65 +2 collect_int 121 123 +2 collect_if 205 207 +2 collect_fork 117 119 +2 collect_fd 79 81 +2 collect_ctx 117 119 +2 collect_cpu 621 623 +2 collect_blk 557 559 +2 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 11/0 up/down: 32/0) Total: 32 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-03-15 15:22:42 +01:00
Denys Vlasenko	d2b820b540	renice: tweak help text Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-03-07 15:21:54 +01:00
Denys Vlasenko	049b007865	pmap: fix bogus {no such process} comm field text function old new delta read_cmdline 246 266 +20 procps_get_maps 196 193 -3 packed_usage 30413 30404 -9 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/2 up/down: 20/-12) Total: 8 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-24 03:45:57 +02:00
Denys Vlasenko	641caaec3d	libbb: factor out code which queries screen width function old new delta get_terminal_width - 17 +17 stty_main 1196 1197 +1 pstree_main 321 319 -2 ls_main 735 731 -4 watch_main 232 225 -7 bb_progress_update 714 706 -8 ps_main 555 543 -12 run_applet_and_exit 708 695 -13 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 1/6 up/down: 18/-46) Total: -28 byte Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-23 01:44:22 +02:00
Denys Vlasenko	4ad702c0a7	top: make sort field for 's' mode less confusing function old new delta display_topmem_process_list 542 565 +23 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-14 22:30:47 +02:00
Denys Vlasenko	7b85ec30b5	*: more BUILD_BUG_ON conversions Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-13 17:17:34 +02:00
Denys Vlasenko	7f3a2a2256	join some common strings, -400 bytes function old new delta print_intel_cstates 499 511 +12 file_insert 355 364 +9 dpkg_main 2944 2940 -4 ifenslave_main 645 640 -5 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/2 up/down: 21/-9) Total: 12 bytes text data bss dec hex filename 937564 932 17676 956172 e970c busybox_old 937164 932 17676 955772 e957c busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-08 11:24:44 +02:00
Denys Vlasenko	d60752f8c9	build system: -fno-builtin-printf Benefits are: drops reference to out-of-line putchar(), fixes a few cases of failed string merge. function old new delta i2cdump_main 1488 1502 +14 sha256_process_block64 423 433 +10 sendmail_main 1183 1185 +2 list_table 1114 1116 +2 i2cdetect_main 1235 1237 +2 fdisk_main 2852 2854 +2 builtin_type 119 121 +2 unicode_conv_to_printable2 325 324 -1 scan_recursive 380 378 -2 mkfs_minix_main 2687 2684 -3 buffer_fill_and_print 178 169 -9 putchar 152 - -152 ------------------------------------------------------------------------------ (add/remove: 0/2 grow/shrink: 7/4 up/down: 34/-167) Total: -133 bytes text data bss dec hex filename 937788 932 17676 956396 e97ec busybox_old 937564 932 17676 956172 e970c busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-07 22:42:45 +02:00
Denys Vlasenko	c9091d8947	ps: fix SEGV on narrow screens. closes 8176 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-07-01 19:07:24 +02:00
Bernhard Reutner-Fischer	86a7f18f21	*: Switch to POSIX utmpx API UTMP is SVID legacy, UTMPX is mandated by POSIX. Glibc and uClibc have identical layout of UTMP and UTMPX, both of these libc treat _PATH_UTMPX as _PATH_UTMP so from a user-perspective nothing changes except the names of the API entrypoints. Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>	2015-04-02 23:03:46 +02:00
Ron Yorston	8ec1ff350c	Use chomp to remove newlines function old new delta unix_do_one 548 540 -8 process_timer_stats 508 500 -8 process_irq_counts 532 524 -8 lpd_main 839 831 -8 hwclock_main 502 494 -8 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/6 up/down: 0/-50) Total: -40 bytes Signed-off-by: Ron Yorston <rmy@tigress.co.uk> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-03-12 20:18:51 +01:00
Denys Vlasenko	8dff01d06a	libbb: introduce and use is_prefixed_with() function old new delta is_prefixed_with - 18 +18 complete_username 78 77 -1 man_main 737 735 -2 fsck_device 429 427 -2 unpack_ar_archive 80 76 -4 strip_unsafe_prefix 105 101 -4 singlemount 1054 1050 -4 rtc_adjtime_is_utc 90 86 -4 resolve_mount_spec 88 84 -4 parse_one_line 1029 1025 -4 parse_conf 1460 1456 -4 may_wakeup 83 79 -4 loadkmap_main 219 215 -4 get_irqs_from_stat 103 99 -4 get_header_cpio 913 909 -4 findfs_main 79 75 -4 fbsplash_main 1230 1226 -4 load_crontab 776 771 -5 expand_vars_to_list 1151 1146 -5 date_main 881 876 -5 skip_dev_pfx 30 24 -6 make_device 2199 2193 -6 complete_cmd_dir_file 773 767 -6 run_applet_and_exit 715 708 -7 uudecode_main 321 313 -8 pwdx_main 197 189 -8 execute 568 560 -8 i2cdetect_main 1186 1176 -10 procps_scan 1242 1230 -12 procps_read_smaps 1017 1005 -12 process_module 746 734 -12 patch_main 1903 1891 -12 nfsmount 3572 3560 -12 stack_machine 126 112 -14 process_timer_stats 449 435 -14 match_fstype 111 97 -14 do_ipaddr 1344 1330 -14 open_list_and_close 359 343 -16 get_header_tar 1795 1779 -16 prepend_new_eth_table 340 323 -17 fsck_main 1811 1794 -17 find_iface_state 56 38 -18 dnsd_main 1321 1303 -18 base_device 179 158 -21 find_keyword 104 82 -22 handle_incoming_and_exit 2785 2762 -23 parse_and_put_prompt 774 746 -28 modinfo 347 317 -30 find_action 204 171 -33 update_passwd 1470 1436 -34 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 0/49 up/down: 18/-540) Total: -522 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-03-12 17:48:34 +01:00
Denys Vlasenko	86031a5ffd	trim extra newlines in help texts Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-01-24 19:46:45 +01:00
Denys Vlasenko	1ec49732e2	mpstat: code shrink function old new delta get_uptime 134 129 -5 get_irqs_from_stat 110 103 -7 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-01-05 18:39:23 +01:00
Guillermo Rodriguez	75a1403f26	free: handle "cached" value too function old new delta free_main 356 481 +125 Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-01-05 18:34:53 +01:00
Denys Vlasenko	6c6d37ee45	top: fix memset length (sizeof(ptr) vs sizeof(array) problem) Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-07-29 17:00:30 +02:00
Timo Teräs	7df1f1dda1	top: fix and merge code to parse /proc/meminfo display_header() code to parse meminfo as is was buggy: - uninitialized variables were used if meminfo was not as expected - meminfo parsing failed on new kernels (3.14+) as new field 'MemAvailable' was introduced between MemFree and Buffers - shared memory was handled only for ancient kernels (2.4.x and earlier) as result Buffers and shared memory fields were shown with bogus values on current kernels. The new code does not try to parse the old style summary header, as the separated fields are always present (it saves code size). Additionally, both Shmem (2.6+) and MemShared (2.4 and earlier) fields are now parsed and summed for shared memory usage; as only one of them exists depending on kernel version. display_topmem_header() parses also meminfo so this makes it use the same code for code shrink. function old new delta display_header - 681 +681 display_topmem_process_list 465 684 +219 parse_meminfo - 189 +189 static.fields - 106 +106 static.match 132 - -132 .rodata 120254 120117 -137 display_topmem_header 513 - -513 display_process_list 1705 667 -1038 ------------------------------------------------------------------------------ (add/remove: 3/2 grow/shrink: 1/2 up/down: 1195/-1820) Total: -625 bytes Signed-off-by: Timo Teräs <timo.teras@iki.fi> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-07-27 21:49:27 +02:00
Bartosz Golaszewski	5d2e409ef8	libbb: use a wrapper around sysconf(_SC_CLK_TCK) to save a few bytes function old new delta bb_sc_clk_tck - 10 +10 timescmd 118 113 -5 print_route 1763 1758 -5 mpstat_main 1288 1283 -5 iostat_main 1947 1942 -5 INET_setroute 879 871 -8 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 0/5 up/down: 10/-28) Total: -18 bytes Signed-off-by: Bartosz Golaszewski <bartekgola@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-06-22 14:01:13 +02:00
Denys Vlasenko	6554d03735	sysctl: do not error out showing write-only data. Closes 6386 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-02-24 17:28:43 +01:00
Bartosz Golaszewski	2de232da53	top.c: fix compilation warnings pfd[1] is unused Signed-off-by: Bartosz Golaszewski <bartekgola@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-01-20 03:26:34 +01:00
Denys Vlasenko	4b26f82c78	kill[all[5]]: code shrink function old new delta kill_main 992 947 -45 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-12-16 17:45:44 +01:00
Uros Vampl	3ac1e0d753	killall5: return 2 if no processes got killed function old new delta kill_main 943 992 +49 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-12-16 17:44:58 +01:00
Denys Vlasenko	327f550669	Use unsigned printf/scanf conversion where more appropriate Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-11-29 16:45:45 +01:00
Denys Vlasenko	dc57294485	top: fix breakage introduced by previous commit Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-09-06 12:59:48 +02:00
Denys Vlasenko	a407cf74cc	Make smart_ulltoa return pointer to end (allows for code shink in callers) function old new delta smart_ulltoa5 405 408 +3 smart_ulltoa4 273 276 +3 list_table 1113 1114 +1 scale 36 34 -2 put_lu 55 53 -2 ulltoa6_and_space 19 14 -5 powertop_main 1470 1461 -9 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-09-06 12:53:14 +02:00
Denys Vlasenko	173aa78bcf	pstree: fix theoretically unsafe code In practice, p->comm is never long enough to trigger the bug, but still. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-06-28 01:59:25 +02:00
Thomas De Schampheleire	879f008a8f	lsof: correct check for symbolic link Busybox lsof used the d_type field of a 'struct dirent' to verify whether the entry is a symbolic link. This field, however, is not portable. On at least one board [1] I have seen, that field is 0, and the check fails even though the entry is a link. The explicit check for a symbolic link is really only needed to skip the default directory entries '.' and '..'. The directory /proc/<pid>/fd/ should not contain anything else but these two and symbolic links. With these assumptions, this patch replaces the explicit link check with a basic check for '.' and '..' (and any hidden file). In the unlikely case that there are other file types, xmalloc_readlink() will return NULL, and we can skip the entry. [1] A MIPS-based board with glibc 2.9, Linux 2.6.32.27. Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-06-27 03:44:46 +02:00
Mike Frysinger	fea2588021	pstree: stop truncating thread names This also fixes a minor buffer overflow when displaying threads as add_proc() only expects COMM_LEN bytes, but we give it one more than that. Reported-by: Dag Wieers <dag@wieers.com> Signed-off-by: Mike Frysinger <vapier@gentoo.org>	2013-06-19 11:29:57 -04:00
Denys Vlasenko	8f2cb7ab26	libbb: introduce and use strftime_[YYYYMMDD]HHMMSS() function old new delta strftime_fmt - 53 +53 strftime_YYYYMMDDHHMMSS - 12 +12 strftime_HHMMSS - 12 +12 human_time 44 43 -1 fmtstr_t 9 - -9 step_time 361 345 -16 watch_main 261 232 -29 ------------------------------------------------------------------------------ (add/remove: 3/1 grow/shrink: 0/3 up/down: 77/-55) Total: 22 bytes text data bss dec hex filename 919203 932 17692 937827 e4f63 busybox_old 919209 932 17692 937833 e4f69 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-03-29 12:30:33 +01:00
Denys Vlasenko	7794c21daf	pgrep: fix a "missing closing paren" build error Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-02-28 15:51:55 +01:00
Bernhard Walle	47f8558eee	pgrep: fix -x option Because when -x is used (exact match), then we cannot compile the regular expression with REG_NOSUB. The manual page regcomp(3) states in section "Byte offsets": Unless REG_NOSUB was set for the compilation of the pattern buffer, it is possible to obtain substring match addressing information. The problem was detected on an ARM system with glibc 2.16. Signed-off-by: Bernhard Walle <bernhard@bwalle.de> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-02-28 12:42:38 +01:00
Denys Vlasenko	17d4436424	ps: seconds_since_boot: uint64_t -> ulong Even if long is 32-bit, 4 billion second uptime isn't likely :) Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-01-26 14:21:15 +01:00
Denys Vlasenko	778794d1dd	*: reuse more strings Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-01-22 10:13:52 +01:00
Denys Vlasenko	6aab061d2d	ps: fix sscanf format specifier (%l); make uptime unsigned Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-01-22 10:07:23 +01:00
Denys Vlasenko	60cb48ca50	whitespace cleanup. no code changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-01-14 15:57:44 +01:00
Denys Vlasenko	6967578728	whitespace fixes. no code changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-01-14 01:34:48 +01:00
Lauri Hintsala	fb499c5752	powertop: fix error message Application tries to use timer_stats module instead of cpufreq_stats. Error message is printed if opening of the file /proc/timer_stats fails. Signed-off-by: Lauri Hintsala <lauri.hintsala@bluegiga.com> Signed-off-by: Mike Frysinger <vapier@gentoo.org>	2013-01-04 17:45:44 -05:00
Denys Vlasenko	c4f2d997a4	libbb: correctness/size tweaks in signal-related helpers Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-09-27 13:20:34 +02:00
Denys Vlasenko	73a1990897	top: do not touch stdin if -b Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-09-26 16:58:25 +02:00
Denys Vlasenko	ffe03f04cb	top: fix build failure in !USE_TERMIOS case Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-09-25 12:48:46 +02:00
Denys Vlasenko	42be921d48	ps: fix build failure in !DESKTOP case Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-09-25 12:48:10 +02:00

1 2 3 4 5 ...

650 Commits