Denys Vlasenko
85164fa06e
ping: use |=, not =, when combine option bit mask
...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2009-11-21 15:44:56 +01:00
Denys Vlasenko
ad7d94bdc7
ping6: do not play dirty tricks with argv
...
function old new delta
common_ping_main - 368 +368
ping6_main 30 14 -16
ping_main 370 11 -359
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 0/2 up/down: 368/-375) Total: -7 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2009-11-20 18:12:12 +01:00
Denys Vlasenko
8131eea3dc
*: introduce and use ffulsh_all()
...
function old new delta
buffer_fill_and_print 179 196 +17
fflush_all - 9 +9
spawn 87 92 +5
rtcwake_main 455 453 -2
...
alarm_intr 93 84 -9
readcmd 1072 1062 -10
bb_ask 345 333 -12
more_main 845 832 -13
flush_stdout_stderr 42 23 -19
xfflush_stdout 27 - -27
flush_stderr 30 - -30
------------------------------------------------------------------------------
(add/remove: 1/2 grow/shrink: 2/50 up/down: 31/-397) Total: -366 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2009-11-02 14:19:51 +01:00
Denis Vlasenko
5e34ff29bc
*: mass renaming of USE_XXXX to IF_XXXX
...
and SKIP_XXXX to IF_NOT_XXXX - the second one was especially
badly named. It was not skipping anything!
2009-04-21 11:09:40 +00:00
Denis Vlasenko
e53738558f
*: fix SO_BINDTODEVICE. Kernel wants at least IFNAMSIZ bytes there.
2008-12-10 11:12:16 +00:00
Denis Vlasenko
59f502b36f
ping: trivial code shrink
...
function old new delta
ping6_main 31 30 -1
ping_main 405 370 -35
2008-10-27 11:54:45 +00:00
Denis Vlasenko
5770715588
ping: SO_RCVBUF must be bigger than packet size,
...
otherwise large ping packets might fail to be received.
2008-08-24 00:02:18 +00:00
Denis Vlasenko
a60f84ebf0
*: rename ATTRIBUTE_XXX to just XXX.
2008-07-05 09:18:54 +00:00
Bernhard Reutner-Fischer
636a1f85e8
- use EXIT_{SUCCESS,FAILURE}. No object-code changes
2008-05-19 09:29:47 +00:00
Denis Vlasenko
b34266b42b
ping: dont leak uninitialized data in ping packets
...
function old new delta
sendping4 176 186 +10
sendping6 93 100 +7
2008-04-29 12:31:53 +00:00
Denis Vlasenko
90c31b3d4b
ping: add -w, -W support (James Simmons <jsimmons AT infradead.org>)
...
function old new delta
print_stats_and_exit - 282 +282
sendping_tail 151 231 +80
packed_usage 23976 24054 +78
ping_main 401 412 +11
arm_ioctl 13 20 +7
pingstats 259 - -259
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 4/0 up/down: 458/-259) Total: 199 bytes
2008-04-07 00:46:29 +00:00
Denis Vlasenko
68404f13d4
*: add -Wunused-parameter; fix resulting breakage
...
function old new delta
procps_scan 1265 1298 +33
aliascmd 278 283 +5
parse_file_cmd 116 120 +4
dname_enc 373 377 +4
setcmd 90 93 +3
execcmd 57 60 +3
count_lines 72 74 +2
process_command_subs 340 339 -1
test_main 409 407 -2
mknod_main 179 177 -2
handle_incoming_and_exit 2653 2651 -2
argstr 1312 1310 -2
shiftcmd 131 128 -3
exitcmd 46 43 -3
dotcmd 297 294 -3
breakcmd 86 83 -3
evalpipe 353 349 -4
evalcommand 1180 1176 -4
evalcmd 109 105 -4
send_tree 374 369 -5
mkfifo_main 82 77 -5
evalsubshell 152 147 -5
typecmd 75 69 -6
letcmd 61 55 -6
add_cmd 1190 1183 -7
main 891 883 -8
ash_main 1415 1407 -8
parse_stream 1377 1367 -10
alloc_procps_scan 55 - -55
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 7/21 up/down: 54/-148) Total: -94 bytes
text data bss dec hex filename
797195 658 7428 805281 c49a1 busybox_old
797101 658 7428 805187 c4943 busybox_unstripped
2008-03-17 09:00:54 +00:00
Paul Fox
0b2b5842a1
Fix compilation error when FEATURE_FANCY_PING enabled. Also
...
reorder networking/Config.in moving FEATURE_FANCY_PING next to
PING6. (Cristian Ionescu-Idbohrn)
2008-02-01 23:25:32 +00:00
Bernhard Reutner-Fischer
8c69afd992
- be C99 friendly. Anonymous unions are a GNU extension. This change is
...
size-neutral WRT -std=gnu99 and fixes several compilation errors for strict
C99 mode.
2008-01-29 10:33:34 +00:00
Denis Vlasenko
6b404431aa
ps: fix build breakage from vda's recent commit
...
*: whitespace fixes
2008-01-07 16:13:14 +00:00
Denis Vlasenko
2edbc2ab85
ping: fix breakage from -I fix
...
passwd: SELinux support by KaiGai Kohei <kaigai@ak.jp.nec.com>
2007-10-20 02:00:49 +00:00
Denis Vlasenko
1a7afb48da
paing: make -I ethN work too (-I addr already worked)
2007-10-19 21:39:25 +00:00
Denis Vlasenko
9b49a5ed85
add -fvisibility=hidden to CC flags, mark XXX_main functions
...
EXTERNALLY_VISIBLE. 5% size reduction of libbusybox.so
2007-10-11 10:05:36 +00:00
Denis Vlasenko
fe7cd642b0
don't pass argc in getopt32, it's superfluous
...
(add/remove: 0/0 grow/shrink: 12/131 up/down: 91/-727) Total: -636 bytes
text data bss dec hex filename
773469 1058 11092 785619 bfcd3 busybox_old
772644 1058 11092 784794 bf99a busybox_unstripped
2007-08-18 15:32:12 +00:00
Denis Vlasenko
a27a11bb2c
introduce and use xdup2(int, int)
...
stop checking whether setsockopt_reuseaddr(int fd) was successful (it always is)
remove second parameter (sockllen) from xmalloc_sockaddr2xxxxx functions
sockaddr2str 142 156 +14
collect_blk 467 474 +7
xdup2 28 33 +5
singlemount 4456 4454 -2
print_host 214 212 -2
nslookup_main 139 137 -2
ftpgetput_main 414 412 -2
udhcpd_main 1258 1255 -3
udhcpc_main 2405 2402 -3
traceroute_main 4125 4122 -3
nc_main 1072 1069 -3
buffer_fill_and_print 76 73 -3
xmalloc_sockaddr2hostonly_noport 18 14 -4
xmalloc_sockaddr2host_noport 18 14 -4
xmalloc_sockaddr2host 15 11 -4
xmalloc_sockaddr2dotted_noport 18 14 -4
xmalloc_sockaddr2dotted 18 14 -4
wget_main 2618 2614 -4
ping_main 393 389 -4
ip_port_str 120 115 -5
dhcprelay_main 1146 1141 -5
dnsd_main 1531 1525 -6
passwd_main 1110 1102 -8
udhcp_kernel_packet 206 197 -9
udhcp_listen_socket 154 144 -10
getty_main 2576 2566 -10
setup 655 640 -15
xmove_fd 51 34 -17
dolisten 759 742 -17
tcpudpsvd_main 1866 1836 -30
startservice 339 299 -40
2007-08-18 14:16:39 +00:00
Denis Vlasenko
3483e85f6b
ping: fix non-fancy ping6
2007-07-02 15:47:52 +00:00
Denis Vlasenko
5ad1048c3d
ping: fix incorrect handling of -I (Iouri Kharon <bc-info@styx.cabel.net>)
2007-06-19 22:54:21 +00:00
Denis Vlasenko
7679145cfa
ping: fix write-after-allocated-mem bug
...
ping: use monotonic_us instead of gettimeofday: smaller code and
needs only 4 bytes in the packet
ping: display roundtrip times with 1/1000th of ms, not 1/10 ms precision.
wget: small optimization
function old new delta
pingstats 243 259 +16
sendping6 98 93 -5
sendping4 183 178 -5
.rodata 129715 129707 -8
progressmeter 867 855 -12
unpack_tail 320 272 -48
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/5 up/down: 16/-78) Total: -62 bytes
2007-06-18 08:55:57 +00:00
Denis Vlasenko
7b72fc1200
pscan: new applet (portscanner). ~1350 bytes. By Tito <farmatito@tiscali.it>
...
wget: lift 256 chars limitation on terminal width
2007-06-16 13:37:59 +00:00
Denis Vlasenko
821cc25f43
ping: stop using data/bss
...
function old new delta
ping_main 375 392 +17
unpack_tail 317 320 +3
ping4 525 528 +3
ping6 772 773 +1
sendping6 99 98 -1
sendping4 184 183 -1
myid 2 - -2
sendping_tail 154 151 -3
tsum 4 - -4
tmin 4 - -4
tmax 4 - -4
source_lsa 4 - -4
pingsock 4 - -4
pingcount 4 - -4
ntransmitted 4 - -4
nrepeats 4 - -4
nreceived 4 - -4
if_index 4 - -4
hostname 8 4 -4
dotted 4 - -4
datalen 4 - -4
pingaddr 28 - -28
rcvd_tbl 128 - -128
------------------------------------------------------------------------------
(add/remove: 0/15 grow/shrink: 4/4 up/down: 24/-215) Total: -191 bytes
text data bss dec hex filename
679835 2728 16736 699299 aaba3 busybox_old
679851 2720 16536 699107 aaae3 busybox_unstripped
2007-06-04 10:33:48 +00:00
Denis Vlasenko
1c9ad62d26
ping: fix wrong sign extension of packet id (bug 1373)
2007-05-27 00:53:41 +00:00
Denis Vlasenko
b6adbf1be2
usage.c: remove reference to busybox.h
...
*: s/include "busybox.h"/include "libbb.h"
2007-05-26 19:00:18 +00:00
Bernhard Reutner-Fischer
b290889f02
- add xsendto and use where appropriate; shrink iplink; sanitize libiproute a bit.
...
-916 byte
2007-04-12 11:34:39 +00:00
Denis Vlasenko
19c238bc90
ping: don't measure times if ping payload is less than 8 bytes;
...
commonalize some ping code.
2007-03-03 00:36:35 +00:00
Denis Vlasenko
c8e9993514
ping: reuse another bit of common code. -60 bytes
2007-02-09 18:14:42 +00:00
Denis Vlasenko
9ca26d38c5
ping: support -I addr in family neutral manner; reuse a bit of common code
2007-02-09 17:32:16 +00:00
Denis Vlasenko
42823d597a
add x to IPv6 functions which can die
2007-02-04 02:39:08 +00:00
Denis Vlasenko
06af216528
suppress warnings about easch <applet>_main() having
...
no preceding prototype
2007-02-03 17:28:39 +00:00
Denis Vlasenko
4c97863109
assorted fixes for bugs found with randomconfig
2007-02-03 03:31:13 +00:00
Denis Vlasenko
89ef65f024
preparatory patch for -Wwrite-strings #5
2007-01-29 23:43:18 +00:00
Denis Vlasenko
e935602ff5
taskset: fix incorrect rage spec and allow 0xXXX input
...
ping: shave off 60 bytes
2007-01-29 18:03:54 +00:00
Denis Vlasenko
aeb4bdd582
accidentally applied wrong (old) patch, fixing up...
2007-01-25 00:00:02 +00:00
Denis Vlasenko
581930cc0d
opt_complementary doesn't like numeric opts :(
2007-01-24 23:55:34 +00:00
Denis Vlasenko
b9a279ba94
Unify ping and ping6. ping has -4 and -6 which force
...
name resolution into IP or IPv6 only, otherwise
we take address family returned by host2sockaddr()
in lsa->sa.sa_family. IOW: "ping ::1" with do IPv6 ping,
"ping 127.0.0.1" will do IPv4 ping.
ping6 is aliased to "ping -6".
2007-01-24 23:53:22 +00:00
Denis Vlasenko
9adc6ced4f
ping6: stop using xgethostbyname2, remove it from libbb.
2007-01-22 22:45:27 +00:00
Denis Vlasenko
703e20235a
cleanups: unnecessary casts, unified const_1, eliminate cross-.c file
...
prototypes (heresy!), add spaces in places like "flags&NETSTAT_CONNECTED",
removed unused #defines, #ifdef -> #if, use uint32_t for ipv4 addrs.
2007-01-22 14:12:08 +00:00
Denis Vlasenko
35d4da0fb5
exterminate u_intXXX.
...
fix ping6 buglet (memset is too short), minor sync between ping and ping6
2007-01-22 14:04:27 +00:00
Denis Vlasenko
3821fb13ea
fix verbose output; remove commented-out includes.
2007-01-11 16:51:21 +00:00
Denis Vlasenko
44c2eb23dd
ping6: fix sequence numbers (missed ntoh) and ttl display.
...
(apparently some, eh, clever libc guy decided that
*CHANGING* IPV6_HOPLIMIT value in libc header is a nifty idea...)
2007-01-08 23:55:33 +00:00
Denis Vlasenko
919c10dd88
ping[6]: don't do htons(a++), it can be a macro
2007-01-03 22:14:18 +00:00
Denis Vlasenko
806116b234
fixes from Yann E. MORIN <yann.morin.1998@anciens.enib.fr>
2006-12-31 12:14:16 +00:00
Denis Vlasenko
d9e15f2068
style cleanup: return(a) -> return a, part 2
2006-11-27 16:49:55 +00:00
Denis Vlasenko
48237b0c88
introduce setsockopt_reuseaddr(int fd), setsockopt_broadcast(int fd),
...
use them where appropriate. 200 bytes saved
2006-11-22 23:22:06 +00:00
Denis Vlasenko
4a5cf16a36
login: use %s - we know that string is not too long there
...
ping[6]: use getopt32: smaller (-50 bytes) and handles -c6 correctly
(was requiring '-c 6' with mandatory space)
2006-11-20 00:48:22 +00:00
Denis Vlasenko
c6f188def8
silly size savings and capitalization fixes
2006-10-26 00:37:00 +00:00
Denis Vlasenko
e1a0d486e4
message string changes, mostly for consistency, also -32 bytes in .rodata
2006-10-20 13:28:22 +00:00
Denis Vlasenko
1385899416
attempt to regularize atoi mess.
2006-10-08 12:49:22 +00:00
Denis Vlasenko
bcf4908e71
ping: bind -> xbind
2006-09-02 17:53:16 +00:00
Denis Vlasenko
e0b7f71d26
ping(6): use htons instead of SWAP_BE.
2006-09-02 16:57:59 +00:00
Denis Vlasenko
2cbe6e6eb2
ping: implement -I option
2006-09-02 16:17:30 +00:00
Denis Vlasenko
db7f2e5881
ping6: resolve interface name to number early.
...
gcc is more efficient at truncating int to int16
via cast, use that instead of &.
2006-09-02 16:16:23 +00:00
Denis Vlasenko
cb6874cc66
Sync ping and ping6 a bit, fix style and indentation.
2006-09-02 16:13:36 +00:00
Rob Landley
cae61e7ca4
Make a gcc 4.1 warning go away.
2006-08-01 00:30:26 +00:00
Rob Landley
9b1857f79f
Bugfix from Shaun Jackman: don't attempt to write 64 bytes and then fail if
...
the write wasn't 192 bytes long.
2006-05-31 23:54:50 +00:00
Rob Landley
299a6b4d7b
Consolidate #include <sys/time.h> so libbb.h does it.
2006-05-27 21:42:58 +00:00
Rob Landley
07a637df47
Patch from KRONSTORFER Horst to Fix a size mismatch in ping, such as the 56/84
...
mismatch inthe following example:
# ping -c 1 172.16.2.1
PING 172.16.2.1 (172.16.2.1): 56 data bytes
84 bytes from 172.16.2.1: icmp_seq=0 ttl=64 time=0.2 ms
2006-04-01 17:28:11 +00:00
Mike Frysinger
06adf5fb47
2006-03-21 Shaun Jackman <sjackman@gmail.com>: Include signal.h instead of sys/signal.h.
2006-03-22 00:25:07 +00:00
Rob Landley
bc68cd14cc
Patch from Denis Vlasenko turning static const int (which gets emitted into
...
the busybox binary) into enums (which don't).
2006-03-10 19:22:06 +00:00
Rob Landley
dfba741457
Robert P. Day removed 8 gazillion occurrences of "extern" on function
...
definitions. (That should only be on prototypes.)
2006-03-06 20:47:33 +00:00
Tim Riker
c1ef7bdd8d
just whitespace
2006-01-25 00:08:53 +00:00
Rob Landley
bbf4e167f2
Ok, ping needs a rewrite from the ground up. (This is not a busybox app.)
...
Fix bug 309, where ping -s 1 localhost would give an elapsed time 9 digits
long due to a stack overflow. Apparently, iputils also does this.
2006-01-11 03:44:11 +00:00
Rob Landley
42eddbafe7
Add a fflush(stdout).
2005-12-15 08:04:17 +00:00
Mike Frysinger
887a1ad57f
BsAtHome writes in Bug 433:
...
Ping packets sent by busybox have wrong endian on f.x. mips32 (openwrt). Attatched is a patch that
uses htons() and ntohs() to be platform independent.
2005-09-15 01:32:48 +00:00
Mike Frysinger
03e827a422
2005-03-19 Shaun Jackman <sjackman@gmail.com>
...
* networking/ping.c (ping): Change the type of fromlen to socklen_t.
2005-07-26 23:00:59 +00:00
Eric Andersen
14f5c8d764
Patch from Bernhard Fischer to make a bunch of symbols static
...
which were otherwise cluttering the global namespace.
2005-04-16 19:39:00 +00:00
Eric Andersen
c7bda1ce65
Remove trailing whitespace. Update copyright to include 2004.
2004-03-15 08:29:22 +00:00
Eric Andersen
85e5e72bc1
Remove remaining libc5 support code
2003-07-22 08:56:55 +00:00
Manuel Novoa III
cad5364599
Major coreutils update.
2003-03-19 09:13:01 +00:00
Eric Andersen
4e486a5d00
Kiss Gabor noticed that ping compiled without BB_FEATURE_FANCY_PING
...
would return 0 instead of EXIT_FAILURE when no response was received.
2003-01-12 06:08:33 +00:00
Eric Andersen
e90e741b1e
Per discussion with vodz, Tim's changes do not seem to make sense.
...
Revert them.
-Erik
2002-06-06 11:47:00 +00:00
Tim Riker
c6def44cfc
ping return 1 if can't ping
2002-05-18 09:16:04 +00:00
Eric Andersen
b88868276c
Doh! I broke ping when removing the nested function.
...
This patch from vodz fixes it again.
2002-03-21 14:04:43 +00:00
Eric Andersen
b5474c48b1
Cave to pressure (2 months later). Eliminate using a
...
nested function, which is a purely unremovable gcc-ism...
-Erik
2002-03-20 11:59:28 +00:00
Matt Kraai
369da77d5e
2002-01-30 Neal H Walfield <neal@cs.uml.edu>
...
* networking/ping.c (hostname): Removed.
[CONFIG_FEATURE_FANCY_PING] (noresp): Moved from here . . .
[CONFIG_FEATURE_FANCY_PING] (ping:noresp): . . . to here.
Use H->h_name, not hostname.
[CONFIG_FEATURE_FANCY_PING] (ping): Do not copy H->h_name into
hostname.
Use H->h_name directly.
[!CONFIG_FEATURE_FANCY_PING] (hostent): New global variable.
[!CONFIG_FEATURE_FANCY_PING] (pingstats): Use hostent in favor
of the now obsolete hostname global variable.
[!CONFIG_FEATURE_FANCY_PING] (ping): Likewise.
No need to copy H; use hostent instead.
[!CONFIG_FEATURE_FANCY_PING] (ntransmitted, nreceived,
nrepeats, pingcount, myid, options, tmax, tsum): Removed
superfluous zero initializers.
2002-02-01 16:54:00 +00:00
Eric Andersen
bdfd0d78bc
Major rework of the directory structure and the entire build system.
...
-Erik
2001-10-24 05:00:29 +00:00
Eric Andersen
044228d5ec
This is vodz' latest patch. Sorry it took so long...
...
1) ping cleanup (compile fix from this patch already applied).
2) traceroute call not spare ntohl() now (and reduce size);
3) Fix for functions not declared static in insmod, ash, vi and mount.
4) a more simple API cmdedit :))
5) adds "stopped jobs" warning to ash on Ctrl-D and fixes "ignoreeof" option
6) reduce exporting library function index->strchr (traceroute), bzero->memset (syslogd)
2001-07-17 01:12:36 +00:00
Matt Kraai
06ef16563b
Allow featureless ping to compile, and featureful ping to shrink
...
(by Adam Slattery).
2001-07-13 20:56:27 +00:00
Eric Andersen
7467c8d3b6
Patch from vodz:
...
Changed email address
cmdedit API change
optimizations for traceroute and md5sum
added a new shared create_icmp_socket() function
2001-07-12 20:26:32 +00:00
Eric Andersen
004015e9c4
Patch from Lars Kellogg-Stedman <lars@larsshack.org> to fix bug
...
#1130 (i.e. When you turn on features it should always ADD features)
2001-05-21 20:30:51 +00:00
Matt Kraai
bf381a0ad8
Whoops. Forgot the x.
2001-05-16 15:52:23 +00:00
Matt Kraai
c55b8d41c1
Add xgethostbyname and herror_msg* functions.
2001-05-16 15:40:51 +00:00
Eric Andersen
b6b519b416
Update how we detect if libc5 is in use.
...
-Erik
2001-04-09 23:52:18 +00:00
Eric Andersen
14e9e9d1ca
Fix socklen_t for libc5
2001-03-14 01:23:07 +00:00
Eric Andersen
cbe31dace5
It turns out that DODMALLOC was broken when I reorganized busybox.h
...
header file usage before the 0.49 release. To fix it, I had to move
the '#include "busybox.h"' to the end of the list of #include files.
-Erik
2001-02-20 06:14:08 +00:00
Eric Andersen
67991cf824
This patch, put together by Manuel Novoa III, is a merge of work
...
done by Evin Robertson (bug#1105) and work from Manuel to make
usage messages occupy less space and simplify how usage messages
are displayed.
2001-02-14 21:23:06 +00:00
Matt Kraai
dd19c69904
Removed trailing \n from error_msg{,_and_die} messages.
2001-01-31 19:00:21 +00:00
Eric Andersen
ed3ef50c23
Fix header file usage -- there were many unnecessary header files included in
...
busybox.h which slowed compiles. I left only what was needed and then fixed up
all the apps to include their own header files. I also fixed naming for pwd.h
and grp.h functions. Tested to compile and run with libc5, glibc, and uClibc.
-Erik
2001-01-27 08:24:39 +00:00
Eric Andersen
f6c6d9aacc
Remove the warning messages. By consensus, netkit-tiny doesn't
...
need to happen.
2001-01-24 18:44:54 +00:00
Eric Andersen
24be980004
Fix spelling. s/maintainence/maintenance/
2001-01-24 17:37:07 +00:00
Mark Whitley
59ab025363
#define -> static const int. Also got rid of some big static buffers.
2001-01-23 22:30:04 +00:00
Eric Andersen
6705986f27
Warn about apps that will be going away in release 0.50
...
-Erik
2001-01-22 22:48:42 +00:00
Matt Kraai
a9819b2908
Use busybox error handling functions wherever possible.
2000-12-22 01:48:07 +00:00
Matt Kraai
1fa1adea2a
Change calls to error_msg.* and strerror to use perror_msg.*.
2000-12-18 03:57:16 +00:00
Mark Whitley
f57c944e09
Changed names of functions in utility.c and all affected files, to make
...
compliant with the style guide. Everybody rebuild your tags file!
2000-12-07 19:56:48 +00:00
Matt Kraai
3e856ce428
Stop using TRUE and FALSE for exit status.
2000-12-01 02:55:13 +00:00