1513 Commits

Author	SHA1	Message	Date
Shawn Landden	4261341281	umount: ignore -c ... "-c, --no-canonicalize: Do not canonicalize paths." As busybox doesn't canonicalize paths in the first place it is safe to ignore this option. See https://github.com/systemd/systemd/issues/7786 Signed-off-by: Shawn Landden <slandden@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-01-08 13:31:58 +01:00
Denys Vlasenko	1b510900e2	unshare: -r should map root to user, not the other way around ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-11-09 16:06:33 +01:00
Denys Vlasenko	b5a0d9d867	unshare: -r implies -U, not -u ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-11-09 15:59:22 +01:00
Denys Vlasenko	f1fdda4542	Fix build failures if MAXHOSTNAMELEN or MAXPATHLEN is not defined ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-10-31 15:59:19 +01:00
James Clarke	160d027c21	blkdiscard: Only build on Linux ... Signed-off-by: James Clarke <jrtc27@jrtc27.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-10-30 14:55:01 +01:00
Denys Vlasenko	2ab9403119	whitespace and comment format fixes, no code changes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-10-05 15:33:28 +02:00
Denys Vlasenko	ebe6d9d875	whitespace and comment format fixes, no code changes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-10-05 14:40:24 +02:00
Denys Vlasenko	0c4dbd481a	regularize format of source file headers, no code changes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-09-18 16:28:43 +02:00
Denys Vlasenko	0180b57aaf	setpriv: placete "declaration of 'index' shadows a global declaration" warning ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-29 15:34:38 +02:00
Denys Vlasenko	7d834c9bb4	run-init: if doing dry run, do not require pid==1 ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-22 11:40:27 +02:00
Denys Vlasenko	bbc26c6934	run-init: implement -n "dry run" ... function old new delta switch_root_main 637 706 +69 packed_usage 31743 31757 +14 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 83/0) Total: 83 bytes text data bss dec hex filename 915247 563 5844 921654 e1036 busybox_old 915303 563 5844 921710 e106e busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-22 10:37:30 +02:00
Denys Vlasenko	200bcc851a	run-init: new applet ... function old new delta switch_root_main 354 637 +283 drop_usermodehelper - 157 +157 cap_name_to_number - 77 +77 packed_usage 31707 31743 +36 applet_names 2665 2674 +9 applet_main 1544 1548 +4 applet_install_loc 193 194 +1 setpriv_main 933 928 -5 getcaps 131 122 -9 parse_cap 117 29 -88 ------------------------------------------------------------------------------ (add/remove: 3/0 grow/shrink: 5/3 up/down: 567/-102) Total: 465 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-21 19:30:01 +02:00
Denys Vlasenko	44b3f2ffbc	libbb: move capability names code to libbb ... function old new delta cap_name_to_number - 77 +77 parse_cap 117 29 -88 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 0/1 up/down: 77/-88) Total: -11 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-21 02:14:19 +02:00
Denys Vlasenko	ec2482e966	setpriv: code shrink ... function old new delta parse_cap 125 117 -8 setpriv_main 949 933 -16 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-24) Total: -24 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-20 20:21:31 +02:00
Denys Vlasenko	79747415d6	setpriv: accept any case in capability names ... This should work: setpriv --inh-caps -SyS_ReSOuRCE sh Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-18 19:11:57 +02:00
Denys Vlasenko	dce39c9894	fsck_minix,mkfs_minix: fix "strict-aliasing" warnings ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-16 11:53:48 +02:00
Denys Vlasenko	c4367d7227	uevent: placate gcc ... How sizeof() can be an aliasing problem? Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-16 11:45:09 +02:00
Denys Vlasenko	647d8afe86	build system: remove unused CONFIG_FEATURE_HAVE_RPC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-14 12:25:55 +02:00
Denys Vlasenko	c52dc0e836	fdisk: typo fix ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-10 15:12:11 +02:00
Denys Vlasenko	890bd5de51	ipcs: tweak output orer to match util-linux 2.28 ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-09 19:27:01 +02:00
Denys Vlasenko	c6ce1c9ca3	ipcrm,ipcs: make them NOEXEC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-09 19:24:19 +02:00
Denys Vlasenko	7943be1e13	ipcrm: code shrink ... function old new delta ipcrm_main 698 663 -35 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-09 19:20:08 +02:00
Denys Vlasenko	22542eca18	getopt32: remove opt_complementary ... function old new delta vgetopt32 1318 1392 +74 runsvdir_main 703 713 +10 bb_make_directory 423 425 +2 collect_cpu 546 545 -1 opt_chars 3 - -3 opt_complementary 4 - -4 tftpd_main 567 562 -5 ntp_init 476 471 -5 zcip_main 1266 1256 -10 xxd_main 428 418 -10 whois_main 140 130 -10 who_main 463 453 -10 which_main 212 202 -10 wget_main 2535 2525 -10 watchdog_main 291 281 -10 watch_main 222 212 -10 vlock_main 399 389 -10 uuencode_main 332 322 -10 uudecode_main 316 306 -10 unlink_main 45 35 -10 udhcpd_main 1482 1472 -10 udhcpc_main 2762 2752 -10 tune2fs_main 290 280 -10 tunctl_main 366 356 -10 truncate_main 218 208 -10 tr_main 518 508 -10 time_main 1134 1124 -10 tftp_main 286 276 -10 telnetd_main 1873 1863 -10 tcpudpsvd_main 1785 1775 -10 taskset_main 521 511 -10 tar_main 1009 999 -10 tail_main 1644 1634 -10 syslogd_main 1967 1957 -10 switch_root_main 368 358 -10 svlogd_main 1454 1444 -10 sv 1296 1286 -10 stat_main 104 94 -10 start_stop_daemon_main 1028 1018 -10 split_main 542 532 -10 sort_main 796 786 -10 slattach_main 624 614 -10 shuf_main 504 494 -10 setsid_main 96 86 -10 setserial_main 1132 1122 -10 setfont_main 388 378 -10 setconsole_main 78 68 -10 sendmail_main 1209 1199 -10 sed_main 677 667 -10 script_main 1077 1067 -10 run_parts_main 325 315 -10 rtcwake_main 454 444 -10 rm_main 175 165 -10 reformime_main 119 109 -10 readlink_main 123 113 -10 rdate_main 246 236 -10 pwdx_main 189 179 -10 pstree_main 317 307 -10 pscan_main 663 653 -10 popmaildir_main 818 808 -10 pmap_main 80 70 -10 nc_main 1042 1032 -10 mv_main 558 548 -10 mountpoint_main 477 467 -10 mount_main 1264 1254 -10 modprobe_main 768 758 -10 modinfo_main 333 323 -10 mktemp_main 200 190 -10 mkswap_main 324 314 -10 mkfs_vfat_main 1489 1479 -10 microcom_main 715 705 -10 md5_sha1_sum_main 521 511 -10 man_main 867 857 -10 makedevs_main 1052 1042 -10 ls_main 563 553 -10 losetup_main 432 422 -10 loadfont_main 89 79 -10 ln_main 524 514 -10 link_main 75 65 -10 ipcalc_main 544 534 -10 iostat_main 2397 2387 -10 install_main 768 758 -10 id_main 480 470 -10 i2cset_main 1239 1229 -10 i2cget_main 380 370 -10 i2cdump_main 1482 1472 -10 i2cdetect_main 682 672 -10 hwclock_main 406 396 -10 httpd_main 741 731 -10 grep_main 837 827 -10 getty_main 1559 1549 -10 fuser_main 297 287 -10 ftpgetput_main 345 335 -10 ftpd_main 2232 2222 -10 fstrim_main 251 241 -10 fsfreeze_main 77 67 -10 fsck_minix_main 2921 2911 -10 flock_main 314 304 -10 flashcp_main 740 730 -10 flash_eraseall_main 833 823 -10 fdformat_main 532 522 -10 expand_main 680 670 -10 eject_main 335 325 -10 dumpleases_main 630 620 -10 du_main 314 304 -10 dos2unix_main 441 431 -10 diff_main 1350 1340 -10 df_main 1064 1054 -10 date_main 1095 1085 -10 cut_main 961 951 -10 cryptpw_main 228 218 -10 crontab_main 575 565 -10 crond_main 1149 1139 -10 cp_main 370 360 -10 common_traceroute_main 3834 3824 -10 common_ping_main 1767 1757 -10 comm_main 239 229 -10 cmp_main 655 645 -10 chrt_main 379 369 -10 chpst_main 704 694 -10 chpasswd_main 308 298 -10 chown_main 171 161 -10 chmod_main 158 148 -10 cat_main 428 418 -10 bzip2_main 120 110 -10 blkdiscard_main 264 254 -10 base64_main 221 211 -10 arping_main 1665 1655 -10 ar_main 556 546 -10 adjtimex_main 406 396 -10 adduser_main 882 872 -10 addgroup_main 411 401 -10 acpid_main 1198 1188 -10 optstring 11 - -11 opt_string 18 - -18 OPT_STR 25 - -25 ubi_tools_main 1288 1258 -30 ls_options 31 - -31 ------------------------------------------------------------------------------ (add/remove: 0/6 grow/shrink: 3/129 up/down: 86/-1383) Total: -1297 bytes text data bss dec hex filename 915428 485 6876 922789 e14a5 busybox_old 914629 485 6872 921986 e1182 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-08 21:55:02 +02:00
Denys Vlasenko	036585a911	getopt32: remove applet_long_options ... FEATURE_GETOPT_LONG made dependent on LONG_OPTS. The folloving options are removed, now LONG_OPTS enables long options for affected applets: FEATURE_ENV_LONG_OPTIONS FEATURE_EXPAND_LONG_OPTIONS FEATURE_UNEXPAND_LONG_OPTIONS FEATURE_MKDIR_LONG_OPTIONS FEATURE_MV_LONG_OPTIONS FEATURE_RMDIR_LONG_OPTIONS FEATURE_ADDGROUP_LONG_OPTIONS FEATURE_ADDUSER_LONG_OPTIONS FEATURE_HWCLOCK_LONG_OPTIONS FEATURE_NSENTER_LONG_OPTS FEATURE_CHCON_LONG_OPTIONS FEATURE_RUNCON_LONG_OPTIONS They either had a small number of long options, or their long options are essential. Example: upstream addgroup and adduser have ONLY longopts, we should probably go further and get rid of non-standard short options. To this end, make addgroup and adduser "select LONG_OPTS". We had this breakage caused by us even in our own package! #if ENABLE_LONG_OPTS || !ENABLE_ADDGROUP /* We try to use --gid, not -g, because "standard" addgroup * has no short option -g, it has only long --gid. */ argv[1] = (char*)"--gid"; #else /* Breaks if system in fact does NOT use busybox addgroup */ argv[1] = (char*)"-g"; #endif xargs: its lone longopt no longer depends on DESKTOP, only on LONG_OPTS. hwclock TODO: get rid of incompatible -t, -l aliases to --systz, --localtime Shorten help texts by omitting long option when short opt alternative exists. Reduction of size comes from the fact that store of an immediate (an address of longopts) to a fixed address (global variable) is a longer insn than pushing that immediate or passing it in a register. This effect is CPU-agnostic. function old new delta getopt32 1350 22 -1328 vgetopt32 - 1318 +1318 getopt32long - 24 +24 tftpd_main 562 567 +5 scan_recursive 376 380 +4 collect_cpu 545 546 +1 date_main 1096 1095 -1 hostname_main 262 259 -3 uname_main 259 255 -4 setpriv_main 362 358 -4 rmdir_main 191 187 -4 mv_main 562 558 -4 ipcalc_main 548 544 -4 ifenslave_main 641 637 -4 gzip_main 192 188 -4 gunzip_main 77 73 -4 fsfreeze_main 81 77 -4 flock_main 318 314 -4 deluser_main 337 333 -4 cp_main 374 370 -4 chown_main 175 171 -4 applet_long_options 4 - -4 xargs_main 894 889 -5 wget_main 2540 2535 -5 udhcpc_main 2767 2762 -5 touch_main 436 431 -5 tar_main 1014 1009 -5 start_stop_daemon_main 1033 1028 -5 sed_main 682 677 -5 script_main 1082 1077 -5 run_parts_main 330 325 -5 rtcwake_main 459 454 -5 od_main 2169 2164 -5 nl_main 201 196 -5 modprobe_main 773 768 -5 mkdir_main 160 155 -5 ls_main 568 563 -5 install_main 773 768 -5 hwclock_main 411 406 -5 getopt_main 622 617 -5 fstrim_main 256 251 -5 env_main 198 193 -5 dumpleases_main 635 630 -5 dpkg_main 3991 3986 -5 diff_main 1355 1350 -5 cryptpw_main 233 228 -5 cpio_main 593 588 -5 conspy_main 1135 1130 -5 chpasswd_main 313 308 -5 adduser_main 887 882 -5 addgroup_main 416 411 -5 ftpgetput_main 351 345 -6 get_terminal_width_height 242 234 -8 expand_main 690 680 -10 static.expand_longopts 18 - -18 static.unexpand_longopts 27 - -27 mkdir_longopts 28 - -28 env_longopts 30 - -30 static.ifenslave_longopts 34 - -34 mv_longopts 46 - -46 static.rmdir_longopts 48 - -48 packed_usage 31739 31687 -52 ------------------------------------------------------------------------------ (add/remove: 2/8 grow/shrink: 3/49 up/down: 1352/-1840) Total: -488 bytes text data bss dec hex filename 915681 485 6880 923046 e15a6 busybox_old 915428 485 6876 922789 e14a5 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-08 17:09:40 +02:00
Denys Vlasenko	00677b5e35	*: fix up use of "getopt_longopts" for longopts not in getopt applet ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-08 14:59:35 +02:00
Denys Vlasenko	90ad4ba9db	ipcalc,rdev: make NOEXEC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-08 00:42:15 +02:00
Denys Vlasenko	ec98e3a628	freeramdisk: make NOEXEC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-07 23:17:14 +02:00
Denys Vlasenko	ae84418d26	losetup: make NOEXEC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-07 23:14:49 +02:00
Denys Vlasenko	354b104df1	fatattr: make NOEXEC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-07 22:21:54 +02:00
Denys Vlasenko	1a1203ff89	users,w,who,uptime,renice: make NOEXEC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-07 16:47:34 +02:00
Denys Vlasenko	4dea1edd08	script: -f means "flush", not "fsync" ... function old new delta packed_usage 31765 31768 +3 script_main 1102 1082 -20 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-07 02:21:34 +02:00
Denys Vlasenko	269b36a49a	script: make -t[FILE] compatible with util-linux ... function old new delta script_main 1056 1102 +46 packed_usage 31736 31765 +29 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 75/0) Total: 75 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-07 02:12:36 +02:00
Denys Vlasenko	dd55d5d53c	script: make -t independent of scriptreplay ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-07 01:53:17 +02:00
Denys Vlasenko	b9be780705	sv,svc: fix NOEXEC fallout ... function old new delta svc_main 145 162 +17 sv 1280 1297 +17 status 139 133 -6 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/1 up/down: 34/-6) Total: 28 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-06 21:23:03 +02:00
Denys Vlasenko	035e71578e	readprofile: do not close/free just before exiting ... function old new delta readprofile_main 1784 1762 -22 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-06 20:39:27 +02:00
Denys Vlasenko	277081e0a4	blkdiscard: make it NOEXEC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-06 20:20:47 +02:00
Denys Vlasenko	bf18239e3d	blkid: make it NOEXEC, make FEATURE_BLKID_TYPE=y default ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-06 20:16:28 +02:00
Denys Vlasenko	3239ab89c9	lspci,lsscsi,lsusb: make them NOEXEC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-05 23:28:19 +02:00
Denys Vlasenko	83a6c8d58b	umount: make it NOEXEC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-05 23:21:02 +02:00
Denys Vlasenko	fdb92359e4	pivot_root: make it NOFORK ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-05 01:51:12 +02:00
Denys Vlasenko	9f59849daa	blockdev, fsfreeze, fstrim, mountpoint: make NOEXEC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-05 01:29:12 +02:00
Denys Vlasenko	5c527dc57e	make 17 state-changing execing applets (ex: "nice PROG ARGS") noexec ... The applets with "<applet> [opts] PROG ARGS" API very quickly exec another program, noexec is okay for them: chpst/envdir/envuidgid/softlimit/setuidgid chroot chrt ionice nice nohup setarch/linux32/linux64 taskset cttyhack "reset" and "sulogin" applets don't have this form, but also exec another program at once, thus made noexec too. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-04 19:55:01 +02:00
Denys Vlasenko	6514785f95	mesg: make in NOFORK ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-04 19:16:01 +02:00
Denys Vlasenko	74c05f5b2c	chat: trim help text ... Noticed while auditing nofork/noexec status function old new delta packed_usage 31777 31747 -30 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-04 17:36:16 +02:00
Denys Vlasenko	72d725d7cc	getopt: make it NOEXEC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-03 19:30:21 +02:00
Denys Vlasenko	84ea60ed65	line editing: make read_line_input() not take timeout param ... It's almost always -1. function old new delta read_line_input 3902 3912 +10 new_line_input_t 24 31 +7 pgetc 583 585 +2 save_command_ps_at_cur_history 80 78 -2 read_line 76 74 -2 fgetc_interactive 246 244 -2 addLines 84 82 -2 doCommands 2226 2222 -4 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/5 up/down: 19/-12) Total: 7 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-02 17:27:28 +02:00
Denys Vlasenko	95f7953f2c	do not use `a' quoting style in comments ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-02 14:26:33 +02:00
Denys Vlasenko	5b3cbe3a53	config: more tweaking of help texts ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-27 14:45:25 +02:00
Denys Vlasenko	e9a5a6985c	rdate: tweak comments, no code changes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-27 14:31:59 +02:00
Denys Vlasenko	8cae43c5d7	swapon: do not use FEATURE_MOUNT_LABEL, have your own FEATURE_SWAPONOFF_LABEL ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-27 10:58:08 +02:00