emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
12,605 Commits 1 Branch 0 Tags 33 MiB
d38ca03946
Commit Graph

12605 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Denys Vlasenko
00ae989ee5 hush: fix a corner case of empty "do \n done" structure 
The structure is:

    while cmd; do
    done

bash doesn't accept it at all. We were accepting it but execution
was buggy.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-31 17:35:45 +02:00
Bernhard Reutner-Fischer
14f55538f0 makedevs: fix help-text 
pull
http://git.buildroot.net/buildroot/commit/?id=99ead3c2ead605d6504b9abad111778dc2a93ae6

Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
 2011-05-30 23:00:47 +02:00
Denys Vlasenko
488dd70869 fix !ENABLE_FEATURE_GETOPT_LONG build. Closes 3775 
When compiling with !ENABLE_FEATURE_GETOPT_LONG, busybox still tries
to include getopt.h which is not available; for example with uClibc
when !UCLIBC_HAS_GETOPT_LONG.  getopt.h is only required
for the _long set of functions.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-29 04:24:52 +02:00
Denys Vlasenko
217a7f4bf9 fuser: fix inverted access() check. Closes 3799. 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-29 02:03:38 +02:00
Peter Korsgaard
8dc6195c97 setconsole: open console for writing rather than reading 
The console passed to TIOCCONS has to be writable, otherwise future
console writes will fail.

This presumably used to work, but in current kernels (see
drivers/tty/tty_io.c:redirected_tty_write) console writes are sent to
vfs_write(device), which checks if the device is writable. A quick look
in the linux git history doesn't show any recent changes to either tty_io
or vfs_write.

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-29 01:51:33 +02:00
Denys Vlasenko
abb0952e63 nmeter: trim help text 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-26 09:00:23 +02:00
Denys Vlasenko
aeab42e3f4 syslogd,klogd: better help text 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-25 11:58:56 +02:00
Maksym Kryzhanovskyy
eeed2306fc fuser: code shrink 
function                                             old     new   delta
scan_proc_net_or_maps                                  -     427    +427
scan_recursive                                         -     380    +380
search_dev_inode                                      74      71      -3
add_pid                                               39       -     -39
scan_link                                             46       -     -46
scan_dir_links                                        76       -     -76
scan_pid_maps                                        222       -    -222
fuser_main                                           871     297    -574
------------------------------------------------------------------------------
(add/remove: 2/4 grow/shrink: 0/2 up/down: 807/-960)         Total: -153 bytes

Signed-off-by: Maksym Kryzhanovskyy <xmaks@email.cz>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-23 03:39:48 +02:00
Denys Vlasenko
e6df7e261e libbb.h: small reordering 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-23 03:39:08 +02:00
Denys Vlasenko
b24ef035bd find: cater for libc w/o FNM_CASEFOLD 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-23 00:40:54 +02:00
Bogdan Harjoc
7948ecb505 find: implement -ipath 
Signed-off-by: Bogdan Harjoc <harjoc@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-22 03:50:21 +02:00
Denys Vlasenko
d616ab6bbb reformime: do not require \r\n 
function                                             old     new   delta
parse                                                958    1063    +105
packed_usage                                       28691   28712     +21

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-22 03:46:33 +02:00
Denys Vlasenko
9b90d9b503 adduser: better logic for choosing addgroup -g/--gid 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-21 21:32:40 +02:00
Denys Vlasenko
569e930768 adduser: prefer to call addgroup --gid, not non-std addgroup -g 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-21 19:57:58 +02:00
Denys Vlasenko
b808614785 od: code shrink 
function                                             old     new   delta
od_main                                             2147    2132     -15

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-21 19:15:55 +02:00
Denys Vlasenko
d373355bf8 od: another fix for --strings 
function                                             old     new   delta
od_main                                             2139    2147      +8

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-21 18:47:51 +02:00
Denys Vlasenko
9d96e274ce od: fix -S NUM to not print chars >0x80 
function                                             old     new   delta
write_block                                          433     431      -2
print_ascii                                          217     215      -2
check_and_close                                      104      96      -8
od_main                                             2164    2139     -25

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-21 18:38:59 +02:00
Denys Vlasenko
3ef344be91 od: code shrink 
function                                             old     new   delta
exit_code                                              -       1      +1
open_next_file                                        73      72      -1
limit_bytes_to_format                                  1       -      -1
ioerror                                                1       -      -1
flag_pseudo_start                                      1       -      -1
flag_dump_strings                                      1       -      -1
od_main                                             2275    2164    -111

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-21 18:38:40 +02:00
Denys Vlasenko
5c10fa5c24 od: code shrink, fix "od --traditional FILE" 
function                                             old     new   delta
parse_old_offset                                     107     125     +18
packed_usage                                       28715   28691     -24
od_main                                             2312    2275     -37

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-21 17:43:06 +02:00
Alexey Fomenko
232ebaa568 lineedit: fix rare SEGV; mark a few FIXMEs 
Signed-off-by: Alexey Fomenko <ext-alexey.fomenko@nokia.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-20 04:26:29 +02:00
Cristian Ionescu-Idbohrn
ea137aa931 warning removal 
Signed-off-by: Cristian Ionescu-Idbohrn <cii@axis.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-20 03:52:36 +02:00
Denys Vlasenko
9e933d9bfc tail: optimize "tail -c HUGENUM REGULAR_FILE". Closes 3763. 
function                                             old     new   delta
tail_main                                           1541    1547      +6

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-20 00:30:04 +02:00
Denys Vlasenko
24b71fd894 top: display sort indicator in memory display 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-18 12:11:19 +02:00
Denys Vlasenko
351fec332a busybox.conf: code shrink 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-16 14:30:26 +02:00
Denys Vlasenko
d83aff1aed busybox.conf: USER.GROUP is _optional_ 
function                                             old     new   delta
main                                                 785     809     +24

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-16 13:53:19 +02:00
Denys Vlasenko
3770b6b061 main: make busybox.conf mode handling less obscure 
function                                             old     new   delta
static.mode_mask                                       -      20     +20
main                                                 782     785      +3
static.mode_chars                                     15      13      -2
run_applet_no_and_exit                               450     441      -9
mode_mask                                             24       -     -24
------------------------------------------------------------------------------
(add/remove: 2/2 grow/shrink: 1/2 up/down: 41/-53)            Total: -12 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-16 13:19:25 +02:00
Denys Vlasenko
9be4702a30 main: free suid_config list after use 
function                                             old     new   delta
run_applet_no_and_exit                               438     450     +12
ifupdown_main                                       2147    2149      +2
writeFileToTarball                                  1325    1326      +1
pidof_main                                           244     245      +1
last_main                                            896     897      +1
grep_main                                            779     780      +1
find_list_entry2                                     121     122      +1
tar_main                                             835     833      -2
llist_unlink                                          28      26      -2
llist_rev                                             23      21      -2
main                                                 791     782      -9
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 7/4 up/down: 19/-15)              Total: 4 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-16 12:21:31 +02:00
Cristian Ionescu-Idbohrn
9a296fbeab vi.c: remove warning: variable 'sp' set but not used 
Signed-off-by: Cristian Ionescu-Idbohrn <cii@axis.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-16 03:53:43 +02:00
Cristian Ionescu-Idbohrn
662972a77a The [-Wunused-but-set-variable] warnings 
networking/ntpd.c:1748:19: warning: variable 'version' set but not used

Signed-off-by: Cristian Ionescu-Idbohrn <cii@axis.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-16 03:53:00 +02:00
Denys Vlasenko
6afc6775e8 dc: do not advertise ops disabled in .config 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-16 00:13:18 +02:00
Denys Vlasenko
4566e172eb simplify parsing of /etc/busybox.conf 
function                                             old     new   delta
parse_config_file                                    799     667    -132

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-16 00:01:08 +02:00
Denys Vlasenko
e0238f852b tweak config help text 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-14 15:23:55 +02:00
Denys Vlasenko
29f9b7268a hush: fix misparsing of "... do eval a= ...". Closes 3721 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-14 11:27:36 +02:00
Denys Vlasenko
eafc558f94 top: better indicator of selected field in mem view 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-14 01:32:09 +02:00
Denys Vlasenko
60a9414cad fix "variable 'foo' set but not used" warnings 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-13 20:57:01 +02:00
Denys Vlasenko
8dd29da2c6 ls: code shrink 
function                                             old     new   delta
sort_and_display_files                                 -     427    +427
scan_and_display_dirs_recur                          497     488      -9
ls_main                                              765     735     -30
display_files                                        422       -    -422
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 0/2 up/down: 427/-461)          Total: -34 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-13 17:55:08 +02:00
Denys Vlasenko
4029e21b37 ls: reorder and rename functions. No code changes 
function                                             old     new   delta
display_single                                         -     931    +931
scan_and_display_dirs_recur                            -     497    +497
display_files                                          -     422    +422
showfiles                                            422       -    -422
showdirs                                             497       -    -497
list_single                                          931       -    -931
------------------------------------------------------------------------------
(add/remove: 3/3 grow/shrink: 0/0 up/down: 1850/-1850)          Total: 0 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-13 17:28:46 +02:00
Denys Vlasenko
2a81639534 ls: reduce memory consumption and speed up (don't do redundant [l]stat) 
function                                             old     new   delta
my_stat                                              110     278    +168
splitdnarray                                         120     118      -2
ls_main                                              769     765      -4
list_single                                          961     931     -30
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/3 up/down: 168/-36)           Total: 132 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-13 17:28:09 +02:00
Denys Vlasenko
66ca241dca ls: avoid forward declaration. No code changes 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-13 17:27:36 +02:00
Denys Vlasenko
d27ac299eb ls: code shrink 
function                                             old     new   delta
list_single                                          990     961     -29

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-13 17:27:15 +02:00
Denys Vlasenko
3a240212d9 passwd: shorter help text 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-13 03:31:45 +02:00
Denys Vlasenko
12a432715f adduser: safe username passing to passwd/addgroup 
passwd: support creating SHA passwords
random code shrink

function                                             old     new   delta
crypt_make_pw_salt                                     -      87     +87
adduser_main                                         883     904     +21
...
crypt_make_salt                                       99      89     -10
chpasswd_main                                        329     312     -17
packed_usage                                       28731   28691     -40
passwd_main                                         1070    1000     -70
cryptpw_main                                         310     224     -86
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 4/12 up/down: 154/-288)        Total: -134 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-13 03:19:01 +02:00
Denys Vlasenko
0806e401d6 hush: install signal handlers with filled sigmask 
function                                             old     new   delta
install_sighandler                                     -      39     +39
hush_main                                           1001    1031     +30
builtin_trap                                         386     392      +6
install_sighandlers                                  121     123      +2
switch_off_special_sigs                               87      86      -1
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 3/1 up/down: 77/-1)              Total: 76 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-12 23:06:20 +02:00
Denys Vlasenko
b1ab283f0b inetd: add FIXMEs 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-12 23:05:27 +02:00
Denys Vlasenko
89f5bfd6c3 libbb.h: use inlined sigfillset, sigemptyset, sigisemptyset on uclibc 
text    data     bss     dec     hex filename
 875879     493    7584  883956   d7cf4 busybox_old
 875879     493    7584  883956   d7cf4 busybox_unstripped

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-12 23:03:18 +02:00
Denys Vlasenko
279a7ac04e ls: fix help text: -w N is optional 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-12 18:44:51 +02:00
Denys Vlasenko
4ad95e6b0e ls: fix -p help text, improve comments and define names 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-12 18:40:59 +02:00
Denys Vlasenko
75e77deab1 hush: fixes and small shrink for HUSH_JOB!=y 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-12 13:12:47 +02:00
Denys Vlasenko
ebc1ee2e2a hush: remove one sigprocmask from exit path 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-12 10:59:18 +02:00
Denys Vlasenko
0c40a731e3 hush: add forgotten {} in multi-statement if. 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-05-12 09:50:12 +02:00