Glenn L McGrath
78b0e379d7
Vladimir's last_patch_15
2001-06-26 02:06:08 +00:00
Eric Andersen
6c947d289f
Fix the code for establishing a controlling terminal.
...
-Erik
2001-06-25 22:24:38 +00:00
Eric Andersen
2d848a476a
This should finish off the job control issues with lash. Make certain
...
we have a controlling terminal...
-Erik
2001-06-25 17:11:54 +00:00
Eric Andersen
52a97ca00c
Some more cleanups. Of special importance, never free a pipe
...
that still has running jobs. Instead, we ignore it and expect
it to be cleaned by the background job stuff.
-Erik
2001-06-22 06:49:26 +00:00
Eric Andersen
c798b07762
Some cleanups for hush. Saves about 350bytes.
...
-Erik
2001-06-22 06:23:03 +00:00
Eric Andersen
8a646dd293
This commit guts lash, restoring it to what it was originally intended to do,
...
just be a simple command line interpreter with basic pipe, redirect, and job
control. For all the more fancy things, people should use hush or ash.
-Erik
2001-06-21 16:38:11 +00:00
Eric Andersen
04407e522b
Another hush update from Larry:
...
Fixes the interaction between if/then/else/fi syntax and variables.
I planned to do it right from the beginning, but my implementation
was buggy. Also adds the relevant test cases. Also adds some old
Matt Kraai variable test cases that got left out somehow.
2001-06-07 16:42:05 +00:00
Eric Andersen
817e73cb63
A patch from Larry to fix pathological things like '>""'
2001-06-06 17:56:09 +00:00
Matt Kraai
c616e53ca2
Don't close file descriptors when we are duplicating them.
2001-06-05 16:50:08 +00:00
Eric Andersen
4f6753e586
Cope gracefully when people type something, then hit ^C.
...
-Erik
2001-05-31 17:17:12 +00:00
Eric Andersen
4f990533e3
Patch from Vladimir to fix up autocompletion on a files/dirs with spaces in
...
them in the presence of a quoting. Also revert my signal handling patch,
which seems to not solve the problem I thought it solved.
2001-05-31 17:15:57 +00:00
Eric Andersen
a813afc24f
Plug another memory leak
2001-05-24 16:19:36 +00:00
Eric Andersen
a15dc15f12
Plug another memory leak in hush. This one showed up when backticked
...
commands were run. This one was sure a bugger to find.
-Erik
2001-05-23 23:46:09 +00:00
Eric Andersen
bf7df04ec1
Fix a massive memory leak in the run_list_test() function.
...
Rename run_list_test() as free_pipe_list().
Rename run_pipe_test() as free_pipe().
-Erik
2001-05-23 22:18:35 +00:00
Eric Andersen
77d9268892
Patch from larry to fix some grammar errors.
2001-05-23 20:32:09 +00:00
Matt Kraai
bdd4eced84
Commit a patch by Larry Doolittle which fixes recursive calls to file_peek,
...
and improves some debugging messages.
2001-05-23 17:43:00 +00:00
Eric Andersen
57e6a49e5b
Excellent. This patch from Larry fixes the behavior of hush
...
when builtins are included in pipes.
2001-05-22 22:34:51 +00:00
Eric Andersen
9978576f15
Fix this case. No, really this time.
...
unset FOO
export FOO=bar
FOO=baz
echo "global env: " `env | grep ^FOO`
echo "local env: " `set | grep ^FOO`
-Erik
2001-05-22 21:37:48 +00:00
Eric Andersen
aeb44c4da6
Fix a race. Sometimes by the time we got to checkjobs(), the
...
pipe struct had already been freed. Return immediately if the
pipe is NULL.
2001-05-22 20:29:00 +00:00
Eric Andersen
816867858b
Oops. Remove some debug noise I left in.
2001-05-22 19:23:35 +00:00
Eric Andersen
94ac244dea
Updates from both Vladimir and Larry
2001-05-22 19:05:18 +00:00
Eric Andersen
004015e9c4
Patch from Lars Kellogg-Stedman <lars@larsshack.org> to fix bug
...
#1130 (i.e. When you turn on features it should always ADD features)
2001-05-21 20:30:51 +00:00
Eric Andersen
ada18ff0f5
The latest patch from Larry
2001-05-21 16:18:22 +00:00
Eric Andersen
9ffb7dd9a4
This is a patch from Vladimir:
...
> I rewrite *local_variable* function in hush.c with:
> 1) remove many memory leaks
> 2) add support read_only protect (require write builtin function for set this,
> I write this special for variable HUSH_VERION=0.01)
> 3) commad read set only local variable now
> 4) remove many error messages if "set unset export" not defined variable
> (bash syntax not put and set error code). Hmm, if I set result to -1, you hush
> called waitpid and returned with error "no waitpid" ( i not found place this
> error).
> 5) destroy error in new version check xgetcwd()==NULL and set "(unknow)" -
> this have error: crashe in next call `pwd`, but xgetcwd(not null) called
> free(arg).
> 6) next add integraion with libbb
Valdimir's patch missed two cases of local variable handling
FOO=bar
export FOO=baz
unset FOO
and
export FOO=bar
FOO=baz
which were working before, so I fixed those two cases.
2001-05-19 03:00:46 +00:00
Eric Andersen
bfae2529b8
It turns out job control in both hush and lash was broken by the
...
signal handling in cmdedit.c. Disabling it makes the shells behave
themselves again. hush isn't quite there, but is getting close...
-Erik
2001-05-17 00:14:27 +00:00
Matt Kraai
59df6f7398
Change 'printf("%s\n", ...)' into 'puts(...)'. Noted and patched in hostname.c
...
by Larry Doolittle.
2001-05-16 14:21:09 +00:00
Eric Andersen
bc604a2f41
Move init of a bunch of globals into main so we are at least
...
a bit more reentrant.
-Erik
2001-05-16 05:24:03 +00:00
Eric Andersen
f72f562b2f
Fix the behavior of local shell variables to match that of bash and ash.
...
-Erik
2001-05-15 23:21:41 +00:00
Eric Andersen
15649c11f3
Oops. I left in some debug noise.
2001-05-15 17:28:26 +00:00
Eric Andersen
20a69a77d2
Write set_local_var() and fixup lookup_param() so you can now use
...
shell local variables.
-Erik
2001-05-15 17:24:44 +00:00
Eric Andersen
78a7c99f7f
This patch covers one big part of variable handling.
...
$ a=b foo
should be handled correctly.
$ a=b
is parsed OK, but the actual variable setting is not
yet written. Except for some weird exceptions related
to quoting rules, this code passes (matches ash behavior)
all the tests I threw at it.
If someone now writes set_local_var(), and updates lookup_param()
to match, we can claim success!
- Larry
2001-05-15 16:30:25 +00:00
Eric Andersen
cfa88ecb72
Fix up some silly warnings
2001-05-11 18:08:16 +00:00
Eric Andersen
5f265b755a
Fix a segfault in lash, hush, and cmdedit. Each of these used
...
xgetcwd, but did not check the return for a NULL, and then continued
to call strlen on the NULL when the cwd had been removed from under it.
-Erik
2001-05-11 16:58:46 +00:00
Eric Andersen
9d94deabd3
Use xgetcwd
2001-05-11 16:36:03 +00:00
Eric Andersen
1a6d39b259
A few more structural updates for job control.
...
-Erik
2001-05-08 05:11:54 +00:00
Eric Andersen
0a36de0580
Fix a stupid segfault caused by dereferencing a NULL ptr.
...
-Erik
2001-05-08 04:25:46 +00:00
Eric Andersen
45e92ba2ce
This patch from Evin Robertson <nitfol@my-deja.com> fixes export so it works.
...
This way leaks memory, but oh well. We will probably fix that when we get
around to doing local variables.
2001-05-07 23:53:09 +00:00
Eric Andersen
83a2ae2184
More hush updates from Larry:
...
Update some comments. Generate partial placeholders for the missing
builtins. Write builtin_umask. Properly treat exec without arguments
as a means to open/close files within the running script. Implement
"4<&-" that encodes for file descriptor closure.
2001-05-07 17:59:25 +00:00
Eric Andersen
2dcfba7117
Larry's variant on Evin Robertson's fix to what I messed up
...
trying to make job control work. This fix makes it so that
hush doesn't error out when init hasn't set up job control,
as in when init=/bin/sh
2001-05-04 22:13:37 +00:00
Matt Kraai
d24f878546
Don't reset parents context when we encounter an terminator. Fixes
...
if true; then if true; then true; fi; fi
2001-05-04 21:20:20 +00:00
Eric Andersen
e5ffb911e8
If it fails to run a builtin, let it fall through to
...
exec the real thing.
-Erik
2001-05-04 16:30:29 +00:00
Matt Kraai
80abc45182
Move up waitpid error check so that errno isn't clobbered by tcsetpgrp.
2001-05-02 21:48:17 +00:00
Eric Andersen
0fcd447d59
Some more job control updates. It will now sucessfully background
...
stuff. Good luck getting things back into the foreground though...
-Erik
2001-05-02 20:12:03 +00:00
Matt Kraai
20a3069ec0
Don't treat newline as pipe separator when processing substitutions.
2001-05-02 17:52:49 +00:00
Matt Kraai
9f8caf134f
Fix $(...) construction. Noted and patched by Larry Doolittle
...
<ldoolitt@recycle.lbl.gov>. I'm just a patch whore. :)
2001-05-02 16:26:12 +00:00
Eric Andersen
bafd94f154
First pass at getting job control working. This gets the infrastructure
...
in place, but something is still missing/wrong in there. Testing with
'grep foo &' seems to put _hush_ into the background. Pondering...
-Erik
2001-05-02 16:11:59 +00:00
Matt Kraai
1c8a59ab95
Use the current pgrp, not pid, when resetting the foreground process group.
...
Fixes bizarre suspension when executing `echo`.
2001-05-02 15:37:09 +00:00
Matt Kraai
f162e7d09d
Don't segfault if the first word is the empty string.
2001-05-02 14:48:48 +00:00
Eric Andersen
e67c3ce327
Another update from Larry:
...
Makes hush return code equal to that of the last command executed.
Fixes the mode where input comes from a file.
2001-05-02 02:09:36 +00:00
Eric Andersen
4ed5e37d4b
Another hush update from Larry:
...
Minor improvements. Something is still broken with running
scripts via "hush filename". All the following are now handled
acceptably (matches ash, not bash).
if true; then echo foo1; fi
if
true; then echo foo2; fi
if true; false; then echo bar; else echo foo3; fi
if true || false; then echo foo4; fi
- Larry
2001-05-01 01:49:50 +00:00
Eric Andersen
aac75e5a78
Some more hush.c updates from Larry Doolittle.
2001-04-30 18:18:45 +00:00
Eric Andersen
088875fec4
Use BUFSIZ for the_command to match size used in cmdedit
2001-04-27 07:49:41 +00:00
Eric Andersen
af44a0e8f4
An update to hush from Larry:
...
It should recover more smoothly from syntax errors, and it now
has a decent guess when the reserved word construct is over
(or not) to control execution and prompting. I took out all the
redundant standalone test copies of libbb routines, but left in a
hook so I can include those for my testing. I'll post that include
file on my web site.
- Larry
2001-04-27 07:26:12 +00:00
Eric Andersen
25f2703015
This is the initial checkin of Larry Doolittle's hush.c, using his
...
April 25, 2001 snapshot, adjusted a bit by me so it has cmdedit support.
This checkin also removes sh.c. In the future sh.c will be a symlink to
your shell of choice. For now, this symlink will default to pointing to
lash.c (as in the past). If you change the symlink to point to hush.c,
then thats what you will get. This symlink business is a temporary situation,
which will be cleaned up Real Soon Now(tm).
-Erik
2001-04-26 23:22:31 +00:00
Mark Whitley
4b541a8817
Moved some #ifdefs down below #include "busybox.h" where they belong.
2001-04-25 17:10:30 +00:00
Eric Andersen
ed424dbf1d
Some patches from Gennady Feldman. Fixed a glob problem such that
...
'ls *.h Config.h' works. Fixed a silly typo with fg/bg process control.
Made cmdedit exit sanely when it cannot read input.
2001-04-23 15:28:28 +00:00
Matt Kraai
4ef40c02f4
Another banner consolidation from Larry Doolittle <ldoolitt@recycle.lbl.gov>.
2001-04-12 20:44:21 +00:00
Matt Kraai
be66ad3212
Fix handling of '' and "".
2001-04-12 15:42:17 +00:00
Eric Andersen
e5dfced23a
Apply Vladimir's latest cleanup patch.
...
-Erik
2001-04-09 22:48:12 +00:00
Eric Andersen
c270ec1fa2
Add support of /W prompts
...
-Erik
2001-04-05 23:00:47 +00:00
Matt Kraai
2129f97cd9
Avoid segfault when export is invoked with no arguments. Thanks to
...
Gennady Feldman.
2001-04-04 17:50:04 +00:00
Eric Andersen
84e229cfbe
Add in a new standalone env applet for fixing up app's environments
...
-Erik
2001-03-29 22:48:33 +00:00
Mark Whitley
a82a00397f
Fix to last patch: locale code should be 9, not 7.
2001-03-27 17:07:15 +00:00
Mark Whitley
1c6581a865
Applied patch from Vladimir N. Oleynik to add locale support to the shell per
...
bug report from Ralph Jones.
2001-03-27 16:35:16 +00:00
Eric Andersen
82ab8da245
-Wshadow sh fix from Jeff Garzik
2001-03-23 17:06:01 +00:00
Eric Andersen
1ca20a7747
A nice patch from Larry Doolittle that adds -Wshadow and
...
cleans up most of the now-revealed problems.
2001-03-21 07:34:27 +00:00
Eric Andersen
92d23245c9
Another cleanup patch from Jeff Garzik <jgarzik@mandrakesoft.com>
2001-03-19 23:49:41 +00:00
Eric Andersen
61173a5371
Fix to cmdedit.c from Vladimir
2001-03-19 17:48:55 +00:00
Eric Andersen
341744781a
Patch from Larry and Vladimir to clean up sh.c and fix
...
shell expansion to work in non POSIX locales.
2001-03-17 00:20:10 +00:00
Eric Andersen
4aaefc2a50
Fix from Larry for glob problems.
...
-Erik
2001-03-15 23:01:19 +00:00
Eric Andersen
f9ff8a7d90
cmdedit.c bugfix patch from Vladimir.
...
-Erik
2001-03-15 20:51:09 +00:00
Mark Whitley
730cdb1904
Reversed previous patch. The right way is to fix uClibc.
2001-03-15 19:39:40 +00:00
Mark Whitley
0b57e28373
Applied patch from Andreas Neuhaus to fix namespace conflict that made busybox
...
not compile with uClibc.
2001-03-15 19:12:06 +00:00
Eric Andersen
1ef92685cf
Yesterday I make strsep_space include post-token whitespace,
...
so we should not be adding another " " between tokens.
-Erik
2001-03-14 19:33:45 +00:00
Eric Andersen
ce4a586edb
I forgot to malloc space for the NULL.
...
-Erik
2001-03-14 18:57:54 +00:00
Mark Whitley
44a9914709
Applied patch from Larry Doolittle to fix '>\na\n' bug. Should close bug #1132
2001-03-14 17:26:37 +00:00
Eric Andersen
4e7244e6b2
libc5 glob is pretty stupid and doesn't do GLOB_BRACE or GLOB_TILDE
...
-Erik
2001-03-14 00:49:52 +00:00
Mark Whitley
f594986b37
- Changed name of BB_FEATURE_SIMPLE_PROMPT to BB_FEATURE_SH_SIMPLE_PROMPT
...
- Set BB_FEATURE_SH_STANDALONE_SHELL and BB_FEATURE_SH_APPLETS_ALWAYS_WIN to
be off by default
- Set BB_FEATURE_SH_SIMPLE_PROMPT to be on by default
- Added some more magic to the Olympus section to make all the dependencies
on the shell, cmdline editing, tab completion and friend work properly.
- Tidied up the Olympus section with some whitespace. Checked the various
scrips that parse through there and the extra whitespace shouldn't break
anything.
2001-03-14 00:29:14 +00:00
Eric Andersen
b3d6e2df95
Update the lash shell (hopefully the last time...) so things like
...
echo "foo bar" and echo -n "foo\t\\\\\tbar" work as expected.
Merge prompt printing work from Vladimir.
-Erik
2001-03-13 22:57:56 +00:00
Eric Andersen
4987bbf979
A fix from Larry Doolittle for some nasty segfaults when sh.c tried to free a
...
corrupted cmd pointer, and where it would truncate a command line at the first
double space.
-Erik
2001-03-12 21:36:49 +00:00
Eric Andersen
1365bb7861
When using wordexp, only try to use the expand command
...
when something actually got expanded. Skip it otherwise.
-Erik
2001-03-10 07:12:12 +00:00
Eric Andersen
74e056bfc8
Fixed a couple more cases. $FOO/bar ${FOO} and such now work
...
without wordexp. Of course for stuff like ${1:-foo} you still
need wordexp for them to work.
-Erik
2001-03-09 20:34:46 +00:00
Eric Andersen
3c7361f53a
Allow wordexp to be used if available
2001-03-09 19:45:26 +00:00
Eric Andersen
ce89871ff7
Urg. Remove the debug noise
2001-03-09 19:43:57 +00:00
Eric Andersen
195743f195
Ok, sh.c should be working now. Many thanks to Larry Doolittle
...
for his timely help -- nearly all of the work in this patch is
his.
-Erik
2001-03-09 19:21:37 +00:00
Eric Andersen
01658a3eec
Fix sh.c for the glab case. I was messing things up for
...
single argument commands. It should now work as expected...
-Erik
2001-03-09 01:24:02 +00:00
Eric Andersen
3dbf1e877a
A '.' is a legal seperator.
2001-03-09 01:08:06 +00:00
Eric Andersen
b180dd9e50
Cleanup patch from Larry
2001-03-09 00:42:46 +00:00
Eric Andersen
13d1fa1d01
Add in 'trim' routine. Fix up sh.c so it works when wordexp
...
is not available.
-Erik
2001-03-08 23:59:45 +00:00
Mark Whitley
7e5291f111
Whitespace / formatting / bracket cleanup.
2001-03-08 19:31:12 +00:00
Eric Andersen
32f8c170b0
Remember to delete un-expandable variables, and do a better job of expanding
...
shell-specific things in case the wordexp implementation is broken (ie. the
stubbed out wordexp in uClibc).
-Erik
2001-03-08 17:44:37 +00:00
Eric Andersen
ca6045955d
Rework environment variable handling to use wordexp, per a suggestion from
...
Larry Doolittle a couple of months ago. This makes the stuff-expansion in lash
be ever so standards compliant. This change needs testing by everyone, but
appears to be solid enough to let us close bug #1090 .
It works for me; however, please test this change!
-Erik
2001-03-08 17:17:13 +00:00
Eric Andersen
11ae573320
remove an unused variable
2001-03-07 03:51:27 +00:00
Eric Andersen
702ec5926f
Fix the memory leak. No really this time.
...
-Erik
2001-03-06 22:17:29 +00:00
Eric Andersen
36278b9576
Fix func prototype
2001-03-06 20:47:31 +00:00
Eric Andersen
54851d3c65
Fixed a memory leak in lash. It seems that close_all was calling close()
...
directly instead of calling mark_closed(), which allowed the memory allocated
by mark_open() to never be freed.
-Erik
2001-03-06 20:44:39 +00:00
Eric Andersen
07f2f3917a
Close open files before calling builtin_exec(). I've tested this
...
and it fixes bug #1121 .
-Erik
2001-03-06 20:28:22 +00:00
Eric Andersen
5165fbed63
Oops. Since dirent.h depends on BB_FEATURE_SH_TAB_COMPLETION, put it
...
after busybox.h is included.
2001-02-20 06:42:29 +00:00
Eric Andersen
caeeb36784
This fixes lash so it handles environment variable expansion, regardless
...
of where the environment variables are located in an argument. This allows
things like 'echo foo$1$SHELL' to expand the same way bash would expand it.
Of course, to make this work I introduced a memory leak, and I am too tired
to find a way to fix it.
-Erik
2001-02-20 06:38:44 +00:00
Eric Andersen
cbe31dace5
It turns out that DODMALLOC was broken when I reorganized busybox.h
...
header file usage before the 0.49 release. To fix it, I had to move
the '#include "busybox.h"' to the end of the list of #include files.
-Erik
2001-02-20 06:14:08 +00:00