6937487be7
Back in 2007, commit 0c97c9d437
("'simple' error message functions by
Loic Grenie") introduced bb_simple_perror_msg() to allow for a lower
overhead call to bb_perror_msg() when only a string was being printed
with no parameters. This saves space for some CPU architectures because
it avoids the overhead of a call to a variadic function. However there
has never been a simple version of bb_error_msg(), and since 2007 many
new calls to bb_perror_msg() have been added that only take a single
parameter and so could have been using bb_simple_perror_message().
This changeset introduces 'simple' versions of bb_info_msg(),
bb_error_msg(), bb_error_msg_and_die(), bb_herror_msg() and
bb_herror_msg_and_die(), and replaces all calls that only take a
single parameter, or use something like ("%s", arg), with calls to the
corresponding 'simple' version.
Since it is likely that single parameter calls to the variadic functions
may be accidentally reintroduced in the future a new debugging config
option WARN_SIMPLE_MSG has been introduced. This uses some macro magic
which will cause any such calls to generate a warning, but this is
turned off by default to avoid use of the unpleasant macros in normal
circumstances.
This is a large changeset due to the number of calls that have been
replaced. The only files that contain changes other than simple
substitution of function calls are libbb.h, libbb/herror_msg.c,
libbb/verror_msg.c and libbb/xfuncs_printf.c. In miscutils/devfsd.c,
networking/udhcp/common.h and util-linux/mdev.c additonal macros have
been added for logging so that single parameter and multiple parameter
logging variants exist.
The amount of space saved varies considerably by architecture, and was
found to be as follows (for 'defconfig' using GCC 7.4):
Arm: -92 bytes
MIPS: -52 bytes
PPC: -1836 bytes
x86_64: -938 bytes
Note that for the MIPS architecture only an exception had to be made
disabling the 'simple' calls for 'udhcp' (in networking/udhcp/common.h)
because it made these files larger on MIPS.
Signed-off-by: James Byrne <james.byrne@origamienergy.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
162 lines
4.7 KiB
C
162 lines
4.7 KiB
C
/*
|
|
* runcon [ context |
|
|
* ( [ -c ] [ -r role ] [-t type] [ -u user ] [ -l levelrange ] )
|
|
* command [arg1 [arg2 ...] ]
|
|
*
|
|
* attempt to run the specified command with the specified context.
|
|
*
|
|
* -r role : use the current context with the specified role
|
|
* -t type : use the current context with the specified type
|
|
* -u user : use the current context with the specified user
|
|
* -l level : use the current context with the specified level range
|
|
* -c : compute process transition context before modifying
|
|
*
|
|
* Contexts are interpreted as follows:
|
|
*
|
|
* Number of MLS
|
|
* components system?
|
|
*
|
|
* 1 - type
|
|
* 2 - role:type
|
|
* 3 Y role:type:range
|
|
* 3 N user:role:type
|
|
* 4 Y user:role:type:range
|
|
* 4 N error
|
|
*
|
|
* Port to busybox: KaiGai Kohei <kaigai@kaigai.gr.jp>
|
|
* - based on coreutils-5.97 (in Fedora Core 6)
|
|
*
|
|
* Licensed under GPLv2, see file LICENSE in this source tree.
|
|
*/
|
|
//config:config RUNCON
|
|
//config: bool "runcon (6.6 kb)"
|
|
//config: default n
|
|
//config: depends on SELINUX
|
|
//config: help
|
|
//config: Enable support to run command in specified security context.
|
|
|
|
//applet:IF_RUNCON(APPLET(runcon, BB_DIR_USR_BIN, BB_SUID_DROP))
|
|
|
|
//kbuild:lib-$(CONFIG_RUNCON) += runcon.o
|
|
|
|
//usage:#define runcon_trivial_usage
|
|
//usage: "[-c] [-u USER] [-r ROLE] [-t TYPE] [-l RANGE] PROG ARGS\n"
|
|
//usage: "runcon CONTEXT PROG ARGS"
|
|
//usage:#define runcon_full_usage "\n\n"
|
|
//usage: "Run PROG in a different security context\n"
|
|
//usage: "\n CONTEXT Complete security context\n"
|
|
//usage: "\n -c Compute process transition context before modifying"
|
|
//usage: "\n -t TYPE Type (for same role as parent)"
|
|
//usage: "\n -u USER User identity"
|
|
//usage: "\n -r ROLE Role"
|
|
//usage: "\n -l RNG Levelrange"
|
|
|
|
#include <selinux/context.h>
|
|
/* from deprecated <selinux/flask.h>: */
|
|
#undef SECCLASS_PROCESS
|
|
#define SECCLASS_PROCESS 2
|
|
|
|
#include "libbb.h"
|
|
|
|
static context_t runcon_compute_new_context(char *user, char *role, char *type, char *range,
|
|
char *command, int compute_trans)
|
|
{
|
|
context_t con;
|
|
security_context_t cur_context;
|
|
|
|
if (getcon(&cur_context))
|
|
bb_simple_error_msg_and_die("can't get current context");
|
|
|
|
if (compute_trans) {
|
|
security_context_t file_context, new_context;
|
|
|
|
if (getfilecon(command, &file_context) < 0)
|
|
bb_error_msg_and_die("can't retrieve attributes of '%s'",
|
|
command);
|
|
if (security_compute_create(cur_context, file_context,
|
|
SECCLASS_PROCESS, &new_context))
|
|
bb_simple_error_msg_and_die("unable to compute a new context");
|
|
cur_context = new_context;
|
|
}
|
|
|
|
con = context_new(cur_context);
|
|
if (!con)
|
|
bb_error_msg_and_die("'%s' is not a valid context", cur_context);
|
|
if (user && context_user_set(con, user))
|
|
bb_error_msg_and_die("can't set new user '%s'", user);
|
|
if (type && context_type_set(con, type))
|
|
bb_error_msg_and_die("can't set new type '%s'", type);
|
|
if (range && context_range_set(con, range))
|
|
bb_error_msg_and_die("can't set new range '%s'", range);
|
|
if (role && context_role_set(con, role))
|
|
bb_error_msg_and_die("can't set new role '%s'", role);
|
|
|
|
return con;
|
|
}
|
|
|
|
#if ENABLE_LONG_OPTS
|
|
static const char runcon_longopts[] ALIGN1 =
|
|
"user\0" Required_argument "u"
|
|
"role\0" Required_argument "r"
|
|
"type\0" Required_argument "t"
|
|
"range\0" Required_argument "l"
|
|
"compute\0" No_argument "c"
|
|
"help\0" No_argument "h"
|
|
;
|
|
#endif
|
|
|
|
#define OPTS_ROLE (1<<0) /* r */
|
|
#define OPTS_TYPE (1<<1) /* t */
|
|
#define OPTS_USER (1<<2) /* u */
|
|
#define OPTS_RANGE (1<<3) /* l */
|
|
#define OPTS_COMPUTE (1<<4) /* c */
|
|
#define OPTS_HELP (1<<5) /* h */
|
|
#define OPTS_CONTEXT_COMPONENT (OPTS_ROLE | OPTS_TYPE | OPTS_USER | OPTS_RANGE)
|
|
|
|
int runcon_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
|
|
int runcon_main(int argc UNUSED_PARAM, char **argv)
|
|
{
|
|
char *role = NULL;
|
|
char *range = NULL;
|
|
char *user = NULL;
|
|
char *type = NULL;
|
|
char *context = NULL;
|
|
unsigned opts;
|
|
context_t con;
|
|
|
|
selinux_or_die();
|
|
|
|
opts = getopt32long(argv, "^"
|
|
"r:t:u:l:ch"
|
|
"\0" "-1",
|
|
runcon_longopts,
|
|
&role, &type, &user, &range
|
|
);
|
|
argv += optind;
|
|
|
|
if (!(opts & OPTS_CONTEXT_COMPONENT)) {
|
|
context = *argv++;
|
|
if (!argv[0])
|
|
bb_simple_error_msg_and_die("no command given");
|
|
}
|
|
|
|
if (context) {
|
|
con = context_new(context);
|
|
if (!con)
|
|
bb_error_msg_and_die("'%s' is not a valid context", context);
|
|
} else {
|
|
con = runcon_compute_new_context(user, role, type, range,
|
|
argv[0], opts & OPTS_COMPUTE);
|
|
}
|
|
|
|
if (security_check_context(context_str(con)))
|
|
bb_error_msg_and_die("'%s' is not a valid context",
|
|
context_str(con));
|
|
|
|
if (setexeccon(context_str(con)))
|
|
bb_error_msg_and_die("can't set up security context '%s'",
|
|
context_str(con));
|
|
|
|
BB_EXECVP_or_die(argv);
|
|
}
|