emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
4,018 Commits 1 Branch 0 Tags 33 MiB
C 93.2%
Shell 4.1%
Assembly 1%
Makefile 0.7%
C++ 0.5%
Other 0.2%
3f47c453da
Go to file
Eric Andersen 3f47c453da Christian Grigis, christian.grigis at smartdata dot ch writes: 
Hello everyone,

Busybox's insmod fails to locate a module when that module is the only one
existing in the /lib/modules directory (with a unique name).

Example:

# find /lib/modules/ -type f
/lib/modules/kernel/drivers/char/bios.o
# insmod bios
insmod: bios.o: no module by that name found
# touch /lib/modules/dummy
# find /lib/modules/ -type f
/lib/modules/kernel/drivers/char/bios.o
/lib/modules/dummy
# insmod bios
Using /lib/modules/kernel/drivers/char/bios.o

As long as there is another file in the /lib/modules directory, insmod
finds it OK.

I tracked the problem down to 'check_module_name_match()' in insmod.c:

It returns TRUE when a match is found, and FALSE otherwise. In the case
where there is only one module in the /lib/modules directory (or more that
one module, but all with the same name), 'recursive_action()' will return
TRUE and we end up on line 4196 in 'insmod.c' which returns an error.
[The reason it works with more than one module with different
names is that in this case there will always be one not matching,
'recursive_action()' will return FALSE and we end up in line 4189.]

Now, from the implementation of 'recursive_action()' and from other
usages of it (tar.c, etc.), it seems to me that FALSE should be returned
to indicate that we want to stop the recursion, so TRUE and FALSE should
be inverted in 'check_module_name_match()'.

At the same time, 'recursive_action()' continues to recurse even after
the recursive call has returned FALSE; again in my understanding and
other usages of it, we can safely stop recursing at this point.


Here is my patch against 1.00-pre8:
2004-04-06 11:56:26 +00:00
applets Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
archival rename uncompress.c to decompress_uncompress.c 2004-04-05 13:03:34 +00:00
console-tools Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
coreutils Fix non standard 'date -R' formatting 2004-04-06 09:38:18 +00:00
debian Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
debianutils Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
docs Yet more doc cleanups 2004-03-27 11:35:46 +00:00
editors The last patch broke: 2004-04-01 09:23:30 +00:00
examples Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
findutils Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
include As noted by Martin Schwenke, the example for find was wrong 2004-03-29 08:20:08 +00:00
init Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
libbb Christian Grigis, christian.grigis at smartdata dot ch writes: 2004-04-06 11:56:26 +00:00
libpwdgrp Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
loginutils passwd and sulogin also need libcrypt, via libbb/pw_encrypt() 2004-03-27 10:08:53 +00:00
miscutils Tito, farmatito at tiscali dot it writes: 2004-04-05 13:08:08 +00:00
modutils Christian Grigis, christian.grigis at smartdata dot ch writes: 2004-04-06 11:56:26 +00:00
networking Patch from Thomas Winkler: 2004-03-31 11:30:08 +00:00
patches Patch adding support for ibs= and obs= to dd 2004-04-05 14:30:15 +00:00
procps Simplify, make formatting better match the procps version 2004-04-06 11:10:50 +00:00
scripts Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
shell Per suggestion by Pawel Sakowski, fix the dash_arith() prototype 2004-04-05 13:24:07 +00:00
sysdeps/linux Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
sysklogd Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
testsuite Minor tar test update 2004-04-06 11:34:02 +00:00
util-linux Everything should be made as simple as possible. But no simpler. 2004-04-03 12:36:03 +00:00
.cvsignore Yet another major rework of the BusyBox config system, using the considerably 2002-12-05 08:41:41 +00:00
.indent.pro First revision of the Busybox Style Guide and an accompanying .indent.pro 2000-07-24 22:36:06 +00:00
AUTHORS Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
Changelog Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
INSTALL Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
LICENSE Update a bunch of docs. Run a script to update my email addr. 2003-07-14 21:21:08 +00:00
Makefile Yet more 'make allyesconfig' adjustments 2004-04-06 11:51:45 +00:00
README Update docs 2004-03-27 09:40:15 +00:00
Rules.mak Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00

README 

Please see the LICENSE file for details on copying and usage.

BusyBox combines tiny versions of many common UNIX utilities into a single
small executable. It provides minimalist replacements for most of the utilities
you usually find in GNU coreutils, util-linux, etc. The utilities in BusyBox
generally have fewer options than their full-featured GNU cousins; however, the
options that are included provide the expected functionality and behave very
much like their GNU counterparts. BusyBox provides a fairly complete POSIX
environment for any small or embedded system.

BusyBox has been written with size-optimization and limited resources in mind.
It is also extremely modular so you can easily include or exclude commands (or
features) at compile time. This makes it easy to customize your embedded
systems. To create a working system, just add /dev, /etc, and a Linux kernel.

BusyBox is extremely configurable.  This allows you to include only the
components you need, thereby reducing binary size. Run 'make config' or
'make menuconfig' for select the functionality that you wish to enable.

After the build is complete, a busybox.links file is generated.  This is
used by 'make install' to create symlinks to the BusyBox binary for all
compiled in functions.  By default, 'make install' will place the symlink
forest into `pwd`/_install unless you have defined the PREFIX environment
variable (i.e., 'make PREFIX=/tmp/foo install')

If you wish to install hard links, rather than symlinks, you can use
'make PREFIX=/tmp/foo install-hardlinks' instead.

----------------

Supported architectures:

   BusyBox in general will build on any architecture supported by gcc.  It has
   a few specialized features added for __sparc__ and __alpha__.  insmod
   functionality is currently limited to x86, ARM, SH3/4, powerpc, m68k,
   MIPS, cris, and v850e.

Supported C Libraries:

   glibc-2.0.x, glibc-2.1.x, glibc-2.2.x, glibc-2.3.x, uClibc.  People
   are looking at newlib and diet-libc, but consider them unsupported,
   untested, or worse.  Linux-libc5 is no longer supported -- you
   should probably use uClibc instead if you want a small C library.

Supported kernels:

   Full functionality requires Linux 2.2.x or better.  A large fraction of the
   code should run on just about anything.  While the current code is fairly
   Linux specific, it should be fairly easy to port the majority of the code
   to, say, FreeBSD or Solaris, or MacOsX, or even Windows (if you are into that
   sortof thing).

----------------

Getting help:

When you find you need help, you can check out the BusyBox mailing list
archives at http://busybox.net/lists/busybox/ or even join
the mailing list if you are interested.

----------------

Bugs:

If you find bugs, please submit a detailed bug report to the BusyBox mailing
list at busybox@mail.busybox.net.  A well-written bug report should include a
transcript of a shell session that demonstrates the bad behavior and enables
anyone else to duplicate the bug on their own machine. The following is such
an example:

    To: busybox@mail.busybox.net
    From: diligent@testing.linux.org
    Subject: /bin/date doesn't work

    Package: BusyBox
    Version: 1.00

    When I execute BusyBox 'date' it produces unexpected results.
    With GNU date I get the following output:

	$ date
	Sat Mar 27 14:19:41 MST 2004

    But when I use BusyBox date I get this instead:

	$ date
	illegal instruction

    I am using Debian unstable, kernel version 2.4.25-vrs2 on a Netwinder,
    and the latest uClibc from CVS.  Thanks for the wonderful program!

	-Diligent

Note the careful description and use of examples showing not only what BusyBox
does, but also a counter example showing what an equivalent GNU app does.  Bug
reports lacking such detail may never be fixed...  Thanks for understanding.

----------------

Downloads:

Source for the latest released version, as well as daily snapshots, can always
be downloaded from
    http://busybox.net/downloads/

----------------

CVS:

BusyBox now has its own publicly browsable CVS tree at:
    http://busybox.net/cgi-bin/cvsweb/busybox/

Anonymous CVS access is available.  For instructions, check out:
    http://busybox.net/cvs_anon.html

For those that are actively contributing there is even CVS write access:
    http://busybox.net/cvs_write.html

----------------

Please feed suggestions, bug reports, insults, and bribes back to:
	Erik Andersen
	<andersen@codepoet.org>