busybox

History

James Byrne 6937487be7 libbb: reduce the overhead of single parameter bb_error_msg() calls Back in 2007, commit `0c97c9d437` ("'simple' error message functions by Loic Grenie") introduced bb_simple_perror_msg() to allow for a lower overhead call to bb_perror_msg() when only a string was being printed with no parameters. This saves space for some CPU architectures because it avoids the overhead of a call to a variadic function. However there has never been a simple version of bb_error_msg(), and since 2007 many new calls to bb_perror_msg() have been added that only take a single parameter and so could have been using bb_simple_perror_message(). This changeset introduces 'simple' versions of bb_info_msg(), bb_error_msg(), bb_error_msg_and_die(), bb_herror_msg() and bb_herror_msg_and_die(), and replaces all calls that only take a single parameter, or use something like ("%s", arg), with calls to the corresponding 'simple' version. Since it is likely that single parameter calls to the variadic functions may be accidentally reintroduced in the future a new debugging config option WARN_SIMPLE_MSG has been introduced. This uses some macro magic which will cause any such calls to generate a warning, but this is turned off by default to avoid use of the unpleasant macros in normal circumstances. This is a large changeset due to the number of calls that have been replaced. The only files that contain changes other than simple substitution of function calls are libbb.h, libbb/herror_msg.c, libbb/verror_msg.c and libbb/xfuncs_printf.c. In miscutils/devfsd.c, networking/udhcp/common.h and util-linux/mdev.c additonal macros have been added for logging so that single parameter and multiple parameter logging variants exist. The amount of space saved varies considerably by architecture, and was found to be as follows (for 'defconfig' using GCC 7.4): Arm: -92 bytes MIPS: -52 bytes PPC: -1836 bytes x86_64: -938 bytes Note that for the MIPS architecture only an exception had to be made disabling the 'simple' calls for 'udhcp' (in networking/udhcp/common.h) because it made these files larger on MIPS. Signed-off-by: James Byrne <james.byrne@origamienergy.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>		2019-07-02 11:35:03 +02:00
..
chattr.c	libbb: reduce the overhead of single parameter bb_error_msg() calls	2019-07-02 11:35:03 +02:00
Config.src
e2fs_lib.c
e2fs_lib.h
fsck.c	libbb: reduce the overhead of single parameter bb_error_msg() calls	2019-07-02 11:35:03 +02:00
Kbuild.src
lsattr.c	config: update size information	2018-12-28 03:20:17 +01:00
README
tune2fs.c	move storage helpers to libbb.h	2018-09-28 15:13:04 +02:00

README

Authors and contributors of original e2fsprogs:

Remy Card <card@masi.ibp.fr>
Theodore Ts'o <tytso@mit.edu>
Stephen C. Tweedie <sct@redhat.com>
Andreas Gruenbacher, <a.gruenbacher@computer.org>
Kaz Kylheku <kaz@ashi.footprints.net>
F.W. ten Wolde <franky@duteca.et.tudelft.nl>
Jeremy Fitzhardinge <jeremy@zip.com.au>
M.J.E. Mol <marcel@duteca.et.tudelft.nl>
Miquel van Smoorenburg <miquels@drinkel.ow.org>
Uwe Ohse <uwe@tirka.gun.de>