6937487be7
Back in 2007, commit 0c97c9d43707 ("'simple' error message functions by Loic Grenie") introduced bb_simple_perror_msg() to allow for a lower overhead call to bb_perror_msg() when only a string was being printed with no parameters. This saves space for some CPU architectures because it avoids the overhead of a call to a variadic function. However there has never been a simple version of bb_error_msg(), and since 2007 many new calls to bb_perror_msg() have been added that only take a single parameter and so could have been using bb_simple_perror_message(). This changeset introduces 'simple' versions of bb_info_msg(), bb_error_msg(), bb_error_msg_and_die(), bb_herror_msg() and bb_herror_msg_and_die(), and replaces all calls that only take a single parameter, or use something like ("%s", arg), with calls to the corresponding 'simple' version. Since it is likely that single parameter calls to the variadic functions may be accidentally reintroduced in the future a new debugging config option WARN_SIMPLE_MSG has been introduced. This uses some macro magic which will cause any such calls to generate a warning, but this is turned off by default to avoid use of the unpleasant macros in normal circumstances. This is a large changeset due to the number of calls that have been replaced. The only files that contain changes other than simple substitution of function calls are libbb.h, libbb/herror_msg.c, libbb/verror_msg.c and libbb/xfuncs_printf.c. In miscutils/devfsd.c, networking/udhcp/common.h and util-linux/mdev.c additonal macros have been added for logging so that single parameter and multiple parameter logging variants exist. The amount of space saved varies considerably by architecture, and was found to be as follows (for 'defconfig' using GCC 7.4): Arm: -92 bytes MIPS: -52 bytes PPC: -1836 bytes x86_64: -938 bytes Note that for the MIPS architecture only an exception had to be made disabling the 'simple' calls for 'udhcp' (in networking/udhcp/common.h) because it made these files larger on MIPS. Signed-off-by: James Byrne <james.byrne@origamienergy.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
271 lines
7.1 KiB
C
271 lines
7.1 KiB
C
/* vi: set sw=4 ts=4: */
|
|
/*
|
|
* Copyright (C) 2003 by Glenn McGrath
|
|
* SELinux support: by Yuichi Nakamura <ynakam@hitachisoft.jp>
|
|
*
|
|
* Licensed under GPLv2 or later, see file LICENSE in this source tree.
|
|
*/
|
|
//config:config INSTALL
|
|
//config: bool "install (12 kb)"
|
|
//config: default y
|
|
//config: help
|
|
//config: Copy files and set attributes.
|
|
//config:
|
|
//config:config FEATURE_INSTALL_LONG_OPTIONS
|
|
//config: bool "Enable long options"
|
|
//config: default y
|
|
//config: depends on INSTALL && LONG_OPTS
|
|
|
|
//applet:IF_INSTALL(APPLET(install, BB_DIR_USR_BIN, BB_SUID_DROP))
|
|
|
|
//kbuild:lib-$(CONFIG_INSTALL) += install.o
|
|
|
|
/* -v, -b, -c are ignored */
|
|
//usage:#define install_trivial_usage
|
|
//usage: "[-cdDsp] [-o USER] [-g GRP] [-m MODE] [-t DIR] [SOURCE]... DEST"
|
|
//usage:#define install_full_usage "\n\n"
|
|
//usage: "Copy files and set attributes\n"
|
|
//usage: "\n -c Just copy (default)"
|
|
//usage: "\n -d Create directories"
|
|
//usage: "\n -D Create leading target directories"
|
|
//usage: "\n -s Strip symbol table"
|
|
//usage: "\n -p Preserve date"
|
|
//usage: "\n -o USER Set ownership"
|
|
//usage: "\n -g GRP Set group ownership"
|
|
//usage: "\n -m MODE Set permissions"
|
|
//usage: "\n -t DIR Install to DIR"
|
|
//usage: IF_SELINUX(
|
|
//usage: "\n -Z Set security context"
|
|
//usage: )
|
|
|
|
#include "libbb.h"
|
|
#include "libcoreutils/coreutils.h"
|
|
|
|
#if ENABLE_FEATURE_INSTALL_LONG_OPTIONS
|
|
static const char install_longopts[] ALIGN1 =
|
|
IF_FEATURE_VERBOSE(
|
|
"verbose\0" No_argument "v"
|
|
)
|
|
"directory\0" No_argument "d"
|
|
"preserve-timestamps\0" No_argument "p"
|
|
"strip\0" No_argument "s"
|
|
"group\0" Required_argument "g"
|
|
"mode\0" Required_argument "m"
|
|
"owner\0" Required_argument "o"
|
|
"target-directory\0" Required_argument "t"
|
|
/* autofs build insists of using -b --suffix=.orig */
|
|
/* TODO? (short option for --suffix is -S) */
|
|
# if ENABLE_SELINUX
|
|
"context\0" Required_argument "Z"
|
|
"preserve_context\0" No_argument "\xff"
|
|
"preserve-context\0" No_argument "\xff"
|
|
# endif
|
|
;
|
|
# define GETOPT32 getopt32long
|
|
# define LONGOPTS install_longopts,
|
|
#else
|
|
# define GETOPT32 getopt32
|
|
# define LONGOPTS
|
|
#endif
|
|
|
|
|
|
#if ENABLE_SELINUX
|
|
static void setdefaultfilecon(const char *path)
|
|
{
|
|
struct stat s;
|
|
security_context_t scontext = NULL;
|
|
|
|
if (!is_selinux_enabled()) {
|
|
return;
|
|
}
|
|
if (lstat(path, &s) != 0) {
|
|
return;
|
|
}
|
|
|
|
if (matchpathcon(path, s.st_mode, &scontext) < 0) {
|
|
goto out;
|
|
}
|
|
if (strcmp(scontext, "<<none>>") == 0) {
|
|
goto out;
|
|
}
|
|
|
|
if (lsetfilecon(path, scontext) < 0) {
|
|
if (errno != ENOTSUP) {
|
|
bb_perror_msg("warning: can't change context"
|
|
" of %s to %s", path, scontext);
|
|
}
|
|
}
|
|
|
|
out:
|
|
freecon(scontext);
|
|
}
|
|
|
|
#endif
|
|
|
|
int install_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
|
|
int install_main(int argc, char **argv)
|
|
{
|
|
struct stat statbuf;
|
|
mode_t mode;
|
|
uid_t uid;
|
|
gid_t gid;
|
|
char *arg, *last;
|
|
const char *gid_str;
|
|
const char *uid_str;
|
|
const char *mode_str;
|
|
int mkdir_flags = FILEUTILS_RECUR;
|
|
int copy_flags = FILEUTILS_DEREFERENCE | FILEUTILS_FORCE;
|
|
int opts;
|
|
int ret = EXIT_SUCCESS;
|
|
int isdir;
|
|
#if ENABLE_SELINUX
|
|
security_context_t scontext;
|
|
bool use_default_selinux_context = 1;
|
|
#endif
|
|
enum {
|
|
OPT_c = 1 << 0,
|
|
OPT_v = 1 << 1,
|
|
OPT_b = 1 << 2,
|
|
OPT_MKDIR_LEADING = 1 << 3,
|
|
OPT_DIRECTORY = 1 << 4,
|
|
OPT_PRESERVE_TIME = 1 << 5,
|
|
OPT_STRIP = 1 << 6,
|
|
OPT_GROUP = 1 << 7,
|
|
OPT_MODE = 1 << 8,
|
|
OPT_OWNER = 1 << 9,
|
|
OPT_TARGET = 1 << 10,
|
|
#if ENABLE_SELINUX
|
|
OPT_SET_SECURITY_CONTEXT = 1 << 11,
|
|
OPT_PRESERVE_SECURITY_CONTEXT = 1 << 12,
|
|
#endif
|
|
};
|
|
|
|
/* -c exists for backwards compatibility, it's needed */
|
|
/* -b is ignored ("make a backup of each existing destination file") */
|
|
opts = GETOPT32(argv, "^"
|
|
"cvb" "Ddpsg:m:o:t:" IF_SELINUX("Z:")
|
|
"\0"
|
|
"t--d:d--t:s--d:d--s"
|
|
IF_FEATURE_INSTALL_LONG_OPTIONS(IF_SELINUX(":Z--\xff:\xff--Z")),
|
|
LONGOPTS
|
|
&gid_str, &mode_str, &uid_str, &last
|
|
IF_SELINUX(, &scontext)
|
|
);
|
|
argc -= optind;
|
|
argv += optind;
|
|
|
|
#if ENABLE_SELINUX
|
|
if (opts & (OPT_PRESERVE_SECURITY_CONTEXT|OPT_SET_SECURITY_CONTEXT)) {
|
|
selinux_or_die();
|
|
use_default_selinux_context = 0;
|
|
if (opts & OPT_PRESERVE_SECURITY_CONTEXT) {
|
|
copy_flags |= FILEUTILS_PRESERVE_SECURITY_CONTEXT;
|
|
}
|
|
if (opts & OPT_SET_SECURITY_CONTEXT) {
|
|
setfscreatecon_or_die(scontext);
|
|
copy_flags |= FILEUTILS_SET_SECURITY_CONTEXT;
|
|
}
|
|
}
|
|
#endif
|
|
|
|
if ((opts & OPT_v) && FILEUTILS_VERBOSE) {
|
|
mkdir_flags |= FILEUTILS_VERBOSE;
|
|
copy_flags |= FILEUTILS_VERBOSE;
|
|
}
|
|
|
|
/* preserve access and modification time, this is GNU behaviour,
|
|
* BSD only preserves modification time */
|
|
if (opts & OPT_PRESERVE_TIME) {
|
|
copy_flags |= FILEUTILS_PRESERVE_STATUS;
|
|
}
|
|
mode = 0755; /* GNU coreutils 6.10 compat */
|
|
if (opts & OPT_MODE)
|
|
mode = bb_parse_mode(mode_str, mode);
|
|
uid = (opts & OPT_OWNER) ? get_ug_id(uid_str, xuname2uid) : getuid();
|
|
gid = (opts & OPT_GROUP) ? get_ug_id(gid_str, xgroup2gid) : getgid();
|
|
|
|
/* If -t DIR is in use, then isdir=true, last="DIR" */
|
|
isdir = (opts & OPT_TARGET);
|
|
if (!(opts & (OPT_TARGET|OPT_DIRECTORY))) {
|
|
/* Neither -t DIR nor -d is in use */
|
|
argc--;
|
|
last = argv[argc];
|
|
argv[argc] = NULL;
|
|
/* coreutils install resolves link in this case, don't use lstat */
|
|
isdir = stat(last, &statbuf) < 0 ? 0 : S_ISDIR(statbuf.st_mode);
|
|
}
|
|
|
|
if (argc < 1)
|
|
bb_show_usage();
|
|
|
|
while ((arg = *argv++) != NULL) {
|
|
char *dest;
|
|
|
|
if (opts & OPT_DIRECTORY) {
|
|
dest = arg;
|
|
/* GNU coreutils 6.9 does not set uid:gid
|
|
* on intermediate created directories
|
|
* (only on last one) */
|
|
if (bb_make_directory(dest, 0755, mkdir_flags)) {
|
|
ret = EXIT_FAILURE;
|
|
goto next;
|
|
}
|
|
} else {
|
|
dest = last;
|
|
if (opts & OPT_MKDIR_LEADING) {
|
|
char *ddir = xstrdup(dest);
|
|
/*
|
|
* -D -t DIR1/DIR2/F3 FILE: create DIR1/DIR2/F3, copy FILE there
|
|
* -D FILE DIR1/DIR2/F3: create DIR1/DIR2, copy FILE there as F3
|
|
*/
|
|
bb_make_directory((opts & OPT_TARGET) ? ddir : dirname(ddir), 0755, mkdir_flags);
|
|
/* errors are not checked. copy_file
|
|
* will fail if dir is not created.
|
|
*/
|
|
free(ddir);
|
|
}
|
|
if (isdir)
|
|
dest = concat_path_file(last, bb_basename(arg));
|
|
if (copy_file(arg, dest, copy_flags) != 0) {
|
|
/* copy is not made */
|
|
ret = EXIT_FAILURE;
|
|
goto next;
|
|
}
|
|
if (opts & OPT_STRIP) {
|
|
char *args[4];
|
|
args[0] = (char*)"strip";
|
|
args[1] = (char*)"-p"; /* -p --preserve-dates */
|
|
args[2] = dest;
|
|
args[3] = NULL;
|
|
if (spawn_and_wait(args)) {
|
|
bb_simple_perror_msg("strip");
|
|
ret = EXIT_FAILURE;
|
|
}
|
|
}
|
|
}
|
|
|
|
/* Set the file mode (always, not only with -m).
|
|
* GNU coreutils 6.10 is not affected by umask. */
|
|
if (chmod(dest, mode) == -1) {
|
|
bb_perror_msg("can't change %s of %s", "permissions", dest);
|
|
ret = EXIT_FAILURE;
|
|
}
|
|
#if ENABLE_SELINUX
|
|
if (use_default_selinux_context)
|
|
setdefaultfilecon(dest);
|
|
#endif
|
|
/* Set the user and group id */
|
|
if ((opts & (OPT_OWNER|OPT_GROUP))
|
|
&& lchown(dest, uid, gid) == -1
|
|
) {
|
|
bb_perror_msg("can't change %s of %s", "ownership", dest);
|
|
ret = EXIT_FAILURE;
|
|
}
|
|
next:
|
|
if (ENABLE_FEATURE_CLEAN_UP && isdir)
|
|
free(dest);
|
|
}
|
|
|
|
return ret;
|
|
}
|