emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
cf4dc4a09d
busybox/util-linux
History
Denys Vlasenko cf4dc4a09d mount: "mount -o rw ...." should not fall back to RO mount 
The reported case was an attempt to remount,rw a CD-ROM:

  mount -o remount,rw /mnt/sr0

which "succeeded" by falling back to RO:

  mount("/dev/sr0", "/mnt/sr0", 0x412862, MS_REMOUNT|MS_SILENT|MS_RELATIME, "nojoliet,check=s,map=n,blocksize"...) = -1 EROFS (Read-only file system)
  ...
  mount("/dev/sr0", "/mnt/sr0", 0x412862, MS_RDONLY|MS_REMOUNT|MS_SILENT|MS_RELATIME, "nojoliet,check=s,map=n,blocksize"...) = 0

Clearly, not what was intended!

function                                             old     new   delta
parse_mount_options                                  241     267     +26
mount_main                                          1198    1211     +13
singlemount                                         1301    1313     +12
inetd_main                                          1919    1911      -8
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 3/1 up/down: 51/-8)              Total: 43 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2021-10-08 02:20:10 +02:00
..
volume_id decrease paddign: gcc-9.3.1 slaps 32-byte alignment on arrays willy-nilly 2020-11-30 13:03:03 +01:00
acpid.c decrease paddign: gcc-9.3.1 slaps 32-byte alignment on arrays willy-nilly 2020-11-30 13:03:03 +01:00
blkdiscard.c blkdiscard: accept -f (force) as no-op 2021-09-10 00:20:05 +02:00
blkid.c build system: drop PLATFORM_LINUX 2020-08-13 17:12:56 +02:00
blockdev.c blockdev: support --get/setra 2021-06-16 17:00:56 +02:00
cal.c cal: implement -m 2021-09-21 15:25:37 +02:00
chrt.c help text tweaks 2020-12-18 04:12:51 +01:00
Config.src restore documentation on the build config language 2018-06-06 15:16:48 +02:00
dmesg.c *: --help tweaks 2021-06-14 20:47:20 +02:00
eject.c build system: drop PLATFORM_LINUX 2020-08-13 17:12:56 +02:00
fallocate.c config: update size information 2018-12-28 03:20:17 +01:00
fatattr.c build system: drop PLATFORM_LINUX 2020-08-13 17:12:56 +02:00
fbset.c decrease paddign: gcc-9.3.1 slaps 32-byte alignment on arrays willy-nilly 2020-11-30 13:03:03 +01:00
fdformat.c build system: drop PLATFORM_LINUX 2020-08-13 17:12:56 +02:00
fdisk_aix.c fdisk_aix: fix aliasing warning, comment out unused global variables 2019-10-04 17:16:15 +02:00
fdisk_gpt.c libbb: introduce and use fputs_stdout 2021-02-03 20:52:40 +01:00
fdisk_osf.c decrease paddign: gcc-9.3.1 slaps 32-byte alignment on arrays willy-nilly 2020-11-30 13:03:03 +01:00
fdisk_sgi.c decrease paddign: gcc-9.3.1 slaps 32-byte alignment on arrays willy-nilly 2020-11-30 13:03:03 +01:00
fdisk_sun.c fdisk: indentation fix 2021-08-16 11:13:30 +02:00
fdisk.c fdisk: commonalize strings 2021-06-25 01:14:43 +02:00
findfs.c build system: drop PLATFORM_LINUX 2020-08-13 17:12:56 +02:00
flock.c *: more --help tweaking 2021-06-13 03:51:55 +02:00
freeramdisk.c build system: drop PLATFORM_LINUX 2020-08-13 17:12:56 +02:00
fsck_minix.c libbb: reduce the overhead of single parameter bb_error_msg() calls 2019-07-02 11:35:03 +02:00
fsfreeze.c build system: drop PLATFORM_LINUX 2020-08-13 17:12:56 +02:00
fstrim.c help text: replace [OPTIONS] with actual options (if not too long) 2020-12-13 22:34:05 +01:00
getopt.c getopt: code shrink 2021-09-16 01:09:32 +02:00
hexdump_xxd.c xxd: compat tweak for -i 2021-06-25 00:16:04 +02:00
hexdump.c more --help text tweaks 2020-12-13 19:18:28 +01:00
hwclock.c libbb: introduce and use xgettimeofday(), do not truncate 64-bit time_t in shells 2020-12-30 23:48:01 +01:00
ionice.c ionice: implement -t 2021-06-17 13:45:13 +02:00
ipcrm.c config: update size information 2018-12-28 03:20:17 +01:00
ipcs.c build system: drop PLATFORM_LINUX 2020-08-13 17:12:56 +02:00
Kbuild.src Convert all util-linux/* applets to "new style" applet definitions 2016-11-23 11:46:32 +01:00
last_fancy.c Sort some miscutils/ applets into coreutils or util-linux 2017-04-12 13:58:40 +02:00
last.c libbb: reduce the overhead of single parameter bb_error_msg() calls 2019-07-02 11:35:03 +02:00
losetup.c mount: support the sizelimit and offset option for loop devices 2020-10-01 00:31:11 +02:00
lspci.c libbb: shrink recursive_action() by reducing memory pressure 2020-10-01 21:52:16 +02:00
lsusb.c libbb: shrink recursive_action() by reducing memory pressure 2020-10-01 21:52:16 +02:00
mdev.c libbb: introduce and use xgettimeofday(), do not truncate 64-bit time_t in shells 2020-12-30 23:48:01 +01:00
mesg.c libbb: reduce the overhead of single parameter bb_error_msg() calls 2019-07-02 11:35:03 +02:00
minix.h more bionic fixes 2016-03-14 19:34:15 +01:00
mkfs_ext2_test.sh fix more instances of ": $((a++))" in shell scripts 2017-07-15 19:20:45 +02:00
mkfs_ext2.c decrease paddign: gcc-9.3.1 slaps 32-byte alignment on arrays willy-nilly 2020-11-30 13:03:03 +01:00
mkfs_ext2.txt mkfs_ext2: use compatible inode sizes; add -I <inodesize>. (by Vladimir) 2009-10-22 12:12:17 +02:00
mkfs_minix.c build system: drop PLATFORM_LINUX 2020-08-13 17:12:56 +02:00
mkfs_reiser.c build system: drop PLATFORM_LINUX 2020-08-13 17:12:56 +02:00
mkfs_vfat.c build system: drop PLATFORM_LINUX 2020-08-13 17:12:56 +02:00
mkswap.c libbb: add and use infrastructure for fixed page size optimization 2020-12-14 18:54:30 +01:00
more.c config: update size information 2018-12-28 03:20:17 +01:00
mount.c mount: "mount -o rw ...." should not fall back to RO mount 2021-10-08 02:20:10 +02:00
mountpoint.c *: more --help tweaking 2021-06-13 03:51:55 +02:00
nologin.c nologin: make it possible to build it as single applet 2020-06-24 15:05:22 +02:00
nsenter.c help text tweaks 2020-12-18 04:12:51 +01:00
pivot_root.c build system: drop PLATFORM_LINUX 2020-08-13 17:12:56 +02:00
rdate.c libbb: introduce and use xsettimeofday() 2020-12-16 21:36:36 +01:00
rdev.c config: update size information 2018-12-28 03:20:17 +01:00
readprofile.c *: more --help tweaking 2021-06-13 03:51:55 +02:00
renice.c *: more --help tweaks 2021-06-15 10:00:18 +02:00
rev.c rev: correct output for long input lines 2021-08-22 00:08:18 +02:00
rtcwake.c move ADJTIME_PATH define to header files 2020-12-17 20:53:43 +01:00
script.c libbb: introduce and use xgettimeofday(), do not truncate 64-bit time_t in shells 2020-12-30 23:48:01 +01:00
scriptreplay.c config: update size information 2018-12-28 03:20:17 +01:00
setarch.c build system: drop PLATFORM_LINUX 2020-08-13 17:12:56 +02:00
setpriv.c help text tweaks 2020-12-18 04:12:51 +01:00
setsid.c config: update size information 2018-12-28 03:20:17 +01:00
swaponoff.c build system: drop PLATFORM_LINUX 2020-08-13 17:12:56 +02:00
switch_root.c switch_root: code shrink - use iterate_on_dir() 2021-06-24 17:54:11 +02:00
taskset.c taskset: disallow "taskset -p 0" 2021-08-15 20:41:18 +02:00
uevent.c help text tweaks 2020-12-18 04:12:51 +01:00
umount.c help text: replace [OPTIONS] with actual options (if not too long) 2020-12-13 22:34:05 +01:00
unshare.c help text tweaks 2020-12-18 04:12:51 +01:00
wall.c config: update size information 2018-12-28 03:20:17 +01:00