diff --git a/nk/io.c b/nk/io.c index 78fb2ae..b0fef9f 100644 --- a/nk/io.c +++ b/nk/io.c @@ -1,10 +1,6 @@ -// Copyright 2010-2018 Nicholas J. Kain +// Copyright 2010-2022 Nicholas J. Kain // SPDX-License-Identifier: MIT -#include -#include -#include #include "nk/io.h" -#include // POSIX says read/write/etc() with len param > SSIZE_MAX is implementation defined. // So we avoid implementation-defined behavior with the bounding in each safe_* fn. @@ -92,23 +88,3 @@ ssize_t safe_recv(int fd, char *buf, size_t len, int flags) } return (ssize_t)s; } - -ssize_t safe_recvmsg(int fd, struct msghdr *msg, int flags) -{ - ssize_t r; - for (;;) { - r = recvmsg(fd, msg, flags); - if (r >= 0 || errno != EINTR) break; - } - return r; -} - -int safe_ftruncate(int fd, off_t length) -{ - int r; - for (;;) { - r = ftruncate(fd, length); - if (!r || errno != EINTR) break; - } - return r; -} diff --git a/nk/io.h b/nk/io.h index 874d922..1872bd0 100644 --- a/nk/io.h +++ b/nk/io.h @@ -1,17 +1,64 @@ -// Copyright 2010-2015 Nicholas J. Kain +// Copyright 2010-2022 Nicholas J. Kain // SPDX-License-Identifier: MIT #ifndef NCM_IO_H_ #define NCM_IO_H_ +#include +#include +#include #include +#include ssize_t safe_read(int fd, char *buf, size_t len); +// Same as above, but will only call read one time. +// Meant to be used with a blocking fd where we need <= len bytes. +static inline ssize_t safe_read_once(int fd, char *buf, size_t len) +{ + if (len > SSIZE_MAX) len = SSIZE_MAX; + ssize_t r; + for (;;) { + r = read(fd, buf, len); + if (r >= 0 || errno != EINTR) break; + } + return r; +} + ssize_t safe_write(int fd, const char *buf, size_t len); ssize_t safe_sendto(int fd, const char *buf, size_t len, int flags, const struct sockaddr *dest_addr, socklen_t addrlen); + ssize_t safe_recv(int fd, char *buf, size_t len, int flags); -ssize_t safe_recvmsg(int fd, struct msghdr *msg, int flags); -int safe_ftruncate(int fd, off_t length); +// Same as above, but will only call read one time. +// Meant to be used with a blocking fd where we need <= len bytes. +static inline ssize_t safe_recv_once(int fd, char *buf, size_t len, int flags) +{ + if (len > SSIZE_MAX) len = SSIZE_MAX; + ssize_t r; + for (;;) { + r = recv(fd, buf, len, flags); + if (r >= 0 || errno != EINTR) break; + } + return r; +} + +static inline ssize_t safe_recvmsg(int fd, struct msghdr *msg, int flags) +{ + ssize_t r; + for (;;) { + r = recvmsg(fd, msg, flags); + if (r >= 0 || errno != EINTR) break; + } + return r; +} +static inline int safe_ftruncate(int fd, off_t length) +{ + int r; + for (;;) { + r = ftruncate(fd, length); + if (!r || errno != EINTR) break; + } + return r; +} #endif diff --git a/scriptd.c b/scriptd.c index c746fea..cdfa717 100644 --- a/scriptd.c +++ b/scriptd.c @@ -32,7 +32,7 @@ void request_scriptd_run(void) suicide("%s: (%s) write failed: %zd", client_config.interface, __func__, r); char buf[16]; - r = safe_recv(scriptdSock[0], buf, sizeof buf, 0); + r = safe_recv_once(scriptdSock[0], buf, sizeof buf, 0); if (r == 0) { // Remote end hung up. exit(EXIT_SUCCESS);