openrc/ChangeLog

commit 901b752463eb37784fcebe5a3b5648b4bfbd9371
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    README: force references to be on separate lines for github

commit c88368b7925e343e293a493da671edaa4ccebc0d
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    update news
    
    This adds a note about SHLIBDIR being dropped from the makefiles.

commit bfffe2c585dd6a23a7d3c99d16d414abcb321105
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    drop reference to gentoo bugzilla
    
    OpenRC has a bug tracker on github, so ask people to file issues there.

commit 5f890ee8ab94f8760f4840d280feb7eced999068
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    init.sh: rework the /run setup for linux xystems
    
    - fix mount options for /run.
    - run restorecon after everything is set up.
    
    X-Gentoo-Bug: 740576
    X-Gentoo-Bug-URL: https://bugs.gentoo.org/740576

commit ef76a663bcc03d4cc9dd1ef05c800f208e26d0ed
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    stop namespaced services with specified pids
    
    The previous fix excludes PIDs of processes running in a different namespace
    regardless of whether the PID has been explicitly stored in a PID file mentioned
    in the --pidfile parameter.  The correct behavior is to only exclude the pid if
    it is not stored in a pidfile.
    
    X-Gentoo-Bug: 776010
    X-Gentoo-Bug-URL: https://bugs.gentoo.org/776010

commit fccd37c34cbabe77d701316491b899a0eb529114
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    add PKGCONFIGDIR to the makefiles
    
    This allows pkgconfig files to be stored in /usr even if PREFIX is /.

commit 5058b6668caaa1ac019d6da299528ad0c75379c2
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    drop shlibdir
    
    I know of no other build systems that have separate paths for static vs
    shared libraries, so this changes ours to use libdir for all libraries.

commit 1878a74a124e12fbdc3fe3286d81045b9198d424
Author: Thomas Deutschmann <whissi@whissi.de>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    numlock: Don't disable numlock on shutdown
    
    When dealing with remote consoles, a shutdown could disable
    host's numlock which is not desired.
    
    This fixes #413.

commit 897c2c00eff0dd73717b0903548912063cfd9f01
Author: btdmaster <59375667+btdmaster@users.noreply.github.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    README: Wrap 'make install' in backticks
    
    This fixes #412

commit 08d518b7fe8f4eade97a50d41859da841a04658a
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    rc_cgroup.sh: do not add newline when writing group2 values
    
    Fixes: #407

commit de776746634cde398bf2a171bfcb43ecc7069e33
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    rc-cgroup.sh: avoid process substitution for cgroup_get_pids
    
    This should make cgroup_cleanup work successfully since cgroup_get_pids
    no longer uses a subshell.
    
    This fixes #396.
    This fixes #397.

commit 4fb4674374931be2fa279692800185078f350d9f
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    fix unified cgroups v2 setup
    
    The cgroups v2 setup required the rc_cgroups_controllers variable
    to be set to the list of controllers to enable regardless of whether the
    mode was hybrid or unified.
    
    This makes sense for hybrid mode since the controllers can't be in both
    the cgroups v1 and v2 hierarchies, but for unified mode we should enable
    all controllers that are configured in the kernel.

commit 0ddab761be249f54388c12f6cc8197dd01a63673
Author: Disconnect3d <dominik.b.czarnota@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    start-stop-daemon: Fix off by ones when checking for RC_* envvars
    
    The same as https://github.com/OpenRC/openrc/pull/361
    
    This fixes #362.

commit f5dd2f5baf1a33173c8ac47495e53d32aee834f5
Author: Disconnect3d <dominik.b.czarnota@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    supervise-daemon: Fix off by ones when checking for RC_* envvars
    
    Fixes strncmp size argument off by one as the current implementation didn't
    match the `=` character.
    
    This fixes #361.

commit b12c52d40f2221e6e2b3ae0296d45c607845ea2a
Author: Rin Cat <me@rin.cat>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    Support docker and lxc stop
    
    This fixes #398.

commit bac71fce5bc9cb7ba02338c6c4cfc949badd218b
Author: sqozz <sqozz@geekify.de>
Commit: Mike Frysinger <vapier@gmail.com>

    start-stop-daemon: fix typo in manpage

commit 12ee72a9b34ef33411cf1bfd5ea059676ee6e482
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    allow devfs to run on lxc
    
    X-Gentoo-Bug: 761918
    X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=761918
    Closes #272.

commit 170ce2624a98952e6eb871cd9915c7c1b76ab887
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    typo fix

commit 9a6698876af1c7563ae7a3237111fc43cf4f5bda
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    improve the diagnostic when the ulimit builtin fails
    
    X-Gentoo-Bug:739274
    X-Gentoo-Bug-URL:https://bugs.gentoo.org/739274

commit bf9af1fb23b57af38880d824e7bba37a648f12fb
Author: Gaël PORTAY <gael.portay@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    net-online: fix process of symlinks in sysfs
    
    The test `[ -h "${ifname}" ] && continue` skips the symlinks while it is
    the opposite that is the expected: ignoring files that are not symlinks.
    
    Fixes commit f42ec82f21f3760b829507344ad0ae761e1d59aa.
    This fixes #391.

commit 5c9c2a19397eb7bcc0bd1c7091229bbf9ef883b5
Author: Patrick Noll <8444617+pnoll1@users.noreply.github.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    remove statement about not providing an init
    
    This fixes #359.

commit 4b2a61f1b8b786600e39ba1a223ff8d9b389b275
Author: Manuel Rüger <manuel@rueg.eu>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    rc-status: Remove noise from ini-formatted output
    
    Otherwise this would create the following output:
    
    rc-status -f ini
     * Caching service dependencies ...        [ ok ]
    [default]
    dbus =  started
    NetworkManager =  started
    syslog-ng =  started
    ...
    
    This fixes #364.

commit 62bc463c63a3beeeead0b6fb164f7c7e9b917849
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    update freebsd 11.x image on cirrus ci

commit 7019bfad3b4cf6eff31d967f6f4e0960f67858fb
Author: Clayton Craft <clayton@craftyguy.net>
Commit: Luca Barbato <luca.barbato@gmail.com>

    user-guide: clarify note for Runlevels/rc-update usage
    
    I found the original note a little confusing, since using rc-update will
    add it to a runlevel so it *is* auto-started when the system reaches
    that runlevel again, but I don't think that was the intended meaning of
    'auto-start', so hopefully this makes it a little more clear.

commit 8346c985d598385e760375a8adf69c986bb4a350
Author: lishuxiang <GoldenMean58@outlook.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    Update user-guide.md
    
    fix a typo
    
    This fixes #389.

commit da30767353eb1cc13826176bf19308a05c7bade4
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    supervise-daemon: do not spawn a process if we are exiting
    
    This fixes #375 and allows us to not add another level of indentation in
    the supervisor loop.

commit 57d9528a0bc64366ea3e0fbbb21b1282ce5c1212
Author: Dermot Bradley <dermot_bradley@yahoo.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    Remove warning when osclock init.d script runs
    
    Currently when osclock is enabled as a init.d service the following
    messages appear during boot when osclock starts:
    
      * The command variable is undefined.
      * There is nothing for osclock to start.
      * If this is what you intend, please write a start function.
      * This will become a failure in a future release.
    
    osclock is activated whenever a machine's system clock is automatically
    configured from a RTC by the kernel and the osclock's only purpose is to
    satisfy the "clock" dependency defined by other init.d services.
    
    Adding a stub start() function prevents OpenRC from showing warnings but
    continues to ensure that the osclock service still does not actually do
    anything.
    
    This fixes #377.

commit 6ce48f124aea593b77163d6f198d18bbe9093068
Author: Calvin Montgomery <calzoneman@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    man/openrc.8: populate OPTIONS from --help output
    
    This fixes #378.

commit 00ea2166081856774f24f7243126f701c7fe6db9
Author: Michael Orlitzky <michael@orlitzky.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    src/rc/checkpath.c: replace mkdir() with mkdirat().
    
    The do_check() function recently gained some defenses against symlink
    replacement attacks that involve the use of *at functions in place of
    their vanilla counterparts; openat() instead of open(), for example.
    One opportunity to replace mkdir() with mkdirat() was missed, however,
    and this commit replaces it.
    
    This fixes #386.

commit ac7ca6d901d72b1bc4ed13be5438e825c07fc0da
Author: Michael Orlitzky <michael@orlitzky.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    src/rc/checkpath.c: fix typo "synbolic" -> "symbolic".

commit 47819f004cec3cc3e911ba69003b8b52bacbebef
Author: Johannes Heimansberg <git@jhe.dedyn.io>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    start-stop-daemon, supervise-daemon: fix parsing of usernames passed via --user that start with a number
    
    start-stop-daemon and supervise-daemon parse usernames and group names
    passed via the --user argument as numeric UID/GID if they start with a
    number (e.g. user "4foo" will be treated as UID 4). This results in the
    process that is being started to run under a totally unexpected user if
    that UID exists.
    
    Even though the result of the sscanf calls are tested for a result of
    exactly 1, which means exactly one value was extracted, because sscanf's
    format string only contains only one placeholder, it will never return
    a value greater than 1, even if there are still characters left to be
    parsed. This causes start-stop-daemon and supervise-daemon to assume
    that usernames starting with a number are just that number. Adding a
    second placeholder "%1s" to the format string, which matches a string of
    length 1, makes sure that sscanf can distinguish between pure numbers
    (in which case it will return 1) and strings either starting with a
    number (in which case it will return 2) and any other string (in which
    case it will return 0).
    
    This fixes #379.
    This fixes #380.

commit 0fab3e837b45021fdcc02a71873c3c245ce96080
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    bootmisc: allow sysvinit compatibility  during shutdown
    
    Use "halt -w" to write the halt record if it exists.
    Otherwise use openrc-shutdown.
    
    This fixes #336.

commit 38aaba28ee86602e29d8a31f155dfa72f5481e68
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    scripts/shutdown.in: fix sysvinit compatible shutdown
    
    X-Gentoo-Bug: https://bugs.gentoo.org/755422

commit 3ed4126a31406124ae8042fc3d4c0bf963d6961e
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    update news for 0.43 with info on checkpath fix

commit aa0fdf6d08b987dfcabebf5b8d05beff015ad8f4
Author: Lars Wendler <polynomial-c@gentoo.org>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    start-stop-daemon: Don't segfault if --exec was given a non-existing file name
    
      Starting program: /sbin/start-stop-daemon --start --exec i-dont-exist
    
      Program received signal SIGSEGV, Segmentation fault.
      0x0000555555559053 in main (argc=1, argv=0x7fffffffdc20)
          at start-stop-daemon.c:631
      631                         *exec_file ? exec_file : exec);
    
    This fixes #385.

commit b6fef599bf8493480664b766040fa9b0d4b1e335
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    checkpath: fix CVE-2018-21269
    
    This walks the directory path to the file we are going to manipulate to make
    sure that when we create the file and change the ownership and permissions
    we are working on the same file.
    Also, all non-terminal symbolic links must be owned by root. This will
    keep a non-root user from making a symbolic link as described in the
    bug. If root creates the symbolic link, it is assumed to be trusted.
    
    On non-linux platforms, we no longer follow non-terminal symbolic links
    by default. If you need to do that, add the -s option on the checkpath
    command line, but keep in mind that this is not secure.
    
    This fixes #201.

commit aac1734a70b60da97d4d24930f1902ca46894b44
Author: Julien Surloppe <julien@surloppe.fr>
Commit: Mike Frysinger <vapier@gmail.com>

    Update user-guide.md
    
    Add missing underscore.

commit 2355f1a3f2a4fd62cac6d9af0e94c8731acd4c0f
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    supervise-daemon: only log debug logs when verbose mode is active

commit fbec1eed51c85c53b39f97a213479caa0a2b75ab
Author: Manuel Rüger <manuel@rueg.eu>
Commit: Manuel Rüger <manuel@rueg.eu>

    .cirrus.yml: Update FreeBSD releases
    
    Signed-off-by: Manuel Rüger <manuel@rueg.eu>

commit 229692cc3424e95d8185e6c681b76c0dc88899f9
Author: Austin English <austinenglish@gmail.com>
Commit: Mike Frysinger <vapier@gmail.com>

    man/openrc-run.8: fix a typo

commit 375ef42393f3dc6edbaa2cb70c79b2366072db38
Author: Sergei Trofimovich <slyfox@gentoo.org>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    src/rc/rc-logger.h: fix build failure against gcc-10
    
    On gcc-10 (and gcc-9 -fno-common) build fails as:
    
    ```
    cc  -L../librc -L../libeinfo -O2 -g -std=c99 -Wall -Wextra -Wimplicit -Wshadow \
      -Wformat=2 -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn \
      -Wmissing-format-attribute -Wnested-externs -Winline -Wwrite-strings \
      -Wcast-align -Wcast-qual -Wpointer-arith -Wdeclaration-after-statement \
      -Wsequence-point -Werror=implicit-function-declaration    \
      -Wl,-rpath=/lib   -o openrc rc.o rc-logger.o rc-misc.o rc-plugin.o _usage.o -lutil -lrc -leinfo -Wl,-Bdynamic -ldl
    ld: rc-logger.o:/home/slyfox/dev/git/openrc/src/rc/rc-logger.h:16:
      multiple definition of `rc_logger_pid'; rc.o:openrc/src/rc/rc-logger.h:16: first defined here
    ld: rc-logger.o:/home/slyfox/dev/git/openrc/src/rc/rc-logger.h:17:
      multiple definition of `rc_logger_tty'; rc.o:openrc/src/rc/rc-logger.h:17: first defined here
    ```
    
    gcc-10 will change the default from -fcommon to fno-common:
    https://gcc.gnu.org/PR85678.
    
    The error also happens if CFLAGS=-fno-common passed explicitly.
    
    This fixes #348.

commit 6deda13754f1b60245945e953cce8d97e40e86fc
Author: Wolf <wolf@wolfsden.cz>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    supervise-daemon: Fix segfault when executable does not exist
    
    When executable is provided just by name (and therefore searched in a
    path), exec_file is reset to NULL every time. exists() handles it being
    NULL just fine, but dereferencing it in eerror does not work.
    
    Fixes #326
    Fixes #327

commit eb610859519292c6164c4ba601d22e642c306beb
Author: artoo <artoo@artixlinux.org>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    binfmt: ensure a file is ungegistered before registering
    
    This fixes #328

commit 039845b742e40752b05ef9393d5a6959d55fe0b6
Author: Andrew Scheller <github@loowis.durge.org>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    Fix typo in README
    
    This fixes #338

commit a7e7fd2b37a7666f26c2d4de9386b2d04f583b41
Author: Ethan Sommer <e5ten.arch@gmail.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    make grep usage POSIX compliant
    
    use grep -E instead of egrep
    check for space or end of line instead of GNU-specific word boundary
    
    This fixes #345

commit 12e147a107c6e27172734c660624343a3c092437
Author: Jason Bowen <jbowen@infinitecactus.com>
Commit: William Hubbs <w.d.hubbs@gmail.com>

    Delete stray text.
    
    It looks like some stray text was left at the bottom of the file:
    ```
    package.
    migrating your system to openrc-init.
    ```
    There's a subsection on migrating a system to `openrc-ini`; perhaps this was
    an embryonic section title?
    
    This fixes #347.

commit fd852865e06a74ecf8b77ff534fa8053e020160f
Author: William Hubbs <william.hubbs@sony.com>
Commit: William Hubbs <william.hubbs@sony.com>

    openrc-shutdown.c: typo fix

commit 35ec935741ffb571cacf763dcca98661c0cfb296
Author: William Hubbs <w.d.hubbs@gmail.com>
Commit: William Hubbs <william.hubbs@sony.com>

    ci/travis.sh: run shellcheck on shell scripts

commit 19cfd82dadf2e52299cf3752deb04562be52145c
Author: Austin English <austinenglish@gmail.com>
Commit: William Hubbs <william.hubbs@sony.com>

    .travis.yml: install shellcheck

commit 87cfad3d6cd619c6090e8209092448ae68279b0c
Author: E5ten <ethancsommer@gmail.com>
Commit: William Hubbs <william.hubbs@sony.com>

    cgroup2_set_limits: verify that the cgroup2 path is a mount point
    
    prior to cgroups getting mounted, /sys/fs/cgroup will still exist,
    but attempts to make directories in it will fail, change cgroup2_set_limits() to
    verify that cgroups are mounted instead of just checking that /sys/fs/cgroup
    exists.
    
    This fixes #307.
    This fixes #321.

commit 8e31614c4b6679fc1bc1f1d1e0779dcedd066a5a
Author: William Hubbs <william.hubbs@sony.com>
Commit: William Hubbs <william.hubbs@sony.com>

    fix clang build