emo/openrc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src/rc/rc-logger.h: fix build failure against gcc-10

Browse Source 
On gcc-10 (and gcc-9 -fno-common) build fails as:

```
cc  -L../librc -L../libeinfo -O2 -g -std=c99 -Wall -Wextra -Wimplicit -Wshadow \
  -Wformat=2 -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn \
  -Wmissing-format-attribute -Wnested-externs -Winline -Wwrite-strings \
  -Wcast-align -Wcast-qual -Wpointer-arith -Wdeclaration-after-statement \
  -Wsequence-point -Werror=implicit-function-declaration    \
  -Wl,-rpath=/lib   -o openrc rc.o rc-logger.o rc-misc.o rc-plugin.o _usage.o -lutil -lrc -leinfo -Wl,-Bdynamic -ldl
ld: rc-logger.o:/home/slyfox/dev/git/openrc/src/rc/rc-logger.h:16:
  multiple definition of `rc_logger_pid'; rc.o:openrc/src/rc/rc-logger.h:16: first defined here
ld: rc-logger.o:/home/slyfox/dev/git/openrc/src/rc/rc-logger.h:17:
  multiple definition of `rc_logger_tty'; rc.o:openrc/src/rc/rc-logger.h:17: first defined here
```

gcc-10 will change the default from -fcommon to fno-common:
https://gcc.gnu.org/PR85678.

The error also happens if CFLAGS=-fno-common passed explicitly.

This fixes #348.
This commit is contained in:
Sergei Trofimovich 2020-01-19 15:24:20 +00:00 committed by William Hubbs
parent 6deda13754
commit 375ef42393
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/rc/rc-logger.h
View File

@ -13,8 +13,8 @@
#ifndef RC_LOGGER_H #ifndef RC_LOGGER_H
#define RC_LOGGER_H #define RC_LOGGER_H
pid_t rc_logger_pid; extern pid_t rc_logger_pid;
int rc_logger_tty; extern int rc_logger_tty;
extern bool rc_in_logger; extern bool rc_in_logger;
void rc_logger_open(const char *runlevel); void rc_logger_open(const char *runlevel);