emo/openrc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

seedrng: fix memory leak reported by clang-tidy

Browse Source 
`seed_dir` gets allocated via xstrdup but never gets freed - which
clang-tidy flags as a memory leak.

instead of free-ing the allocation, just don't allocate to begin with
since there's no need for it.

also bump the copyright year.
This commit is contained in:
NRK 2023-01-31 04:16:41 +06:00 committed by Mike Frysinger
parent 36cc40a9d6
commit 63a5ee3d8c
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/seedrng/seedrng.c
View File

@ -5,7 +5,7 @@
*/ */
/* /*
* Copyright (c) 2022 The OpenRC Authors. * Copyright (c) 2023 The OpenRC Authors.
* See the Authors file at the top-level directory of this distribution and * See the Authors file at the top-level directory of this distribution and
* https://github.com/OpenRC/openrc/blob/HEAD/AUTHORS * https://github.com/OpenRC/openrc/blob/HEAD/AUTHORS
* *
@ -455,7 +455,7 @@ int main(int argc, char **argv)
static const char seedrng_prefix[] = "SeedRNG v1 Old+New Prefix"; static const char seedrng_prefix[] = "SeedRNG v1 Old+New Prefix";
static const char seedrng_failure[] = "SeedRNG v1 No New Seed Failure"; static const char seedrng_failure[] = "SeedRNG v1 No New Seed Failure";
int opt, fd, dfd, program_ret = 0; int opt, fd, dfd, program_ret = 0;
char *seed_dir = NULL; const char *seed_dir = NULL;
uint8_t new_seed[MAX_SEED_LEN]; uint8_t new_seed[MAX_SEED_LEN];
size_t new_seed_len; size_t new_seed_len;
bool new_seed_creditable; bool new_seed_creditable;
@ -470,7 +470,7 @@ int main(int argc, char **argv)
switch (opt) { switch (opt) {
case LONGOPT_SEED_DIR: case LONGOPT_SEED_DIR:
if (!seed_dir) if (!seed_dir)
seed_dir = xstrdup(optarg); seed_dir = optarg;
break; break;
case LONGOPT_SKIP_CREDIT: case LONGOPT_SKIP_CREDIT:
skip_credit = true; skip_credit = true;
@ -479,7 +479,7 @@ int main(int argc, char **argv)
} }
} }
if (!seed_dir) if (!seed_dir)
seed_dir = xstrdup(DEFAULT_SEED_DIR); seed_dir = DEFAULT_SEED_DIR;
if (getuid()) if (getuid())
eerrorx("%s: superuser access is required", applet); eerrorx("%s: superuser access is required", applet);
umask(0077); umask(0077);