emo/openrc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

seedrng: use posix positional params to avoid space splitting

Browse Source 
The value of ${seed_dir} may have spaces in it, making the current
argument string building method unsafe. Instead, use positional
parameters to pass these arguments safely.
This commit is contained in:
Jason A. Donenfeld 2022-04-21 17:45:56 +02:00 committed by Mike Frysinger
parent b5f713124b
commit f81bb7e2c4
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
init.d/seedrng.in
View File

@ -19,18 +19,18 @@ depend()
provide urandom provide urandom
} }
seedrng_options() seedrng_with_options()
{ {
[ -n "${seed_dir}" ] && set --
echo "--seed-dir \"${seed_dir}\"" [ -n "${seed_dir}" ] && set -- "$@" --seed-dir "${seed_dir}"
yesno "${skip_credit}" && yesno "${skip_credit}" && set -- "$@" --skip-credit
echo "--skip-credit" seedrng "$@"
} }
start() start()
{ {
ebegin "Seeding random number generator" ebegin "Seeding random number generator"
seedrng $(seedrng_options) seedrng_with_options
eend $? "Error seeding random number generator" eend $? "Error seeding random number generator"
return 0 return 0
} }
@ -38,7 +38,7 @@ start()
stop() stop()
{ {
ebegin "Saving random number generator seed" ebegin "Saving random number generator seed"
seedrng $(seedrng_options) seedrng_with_options
eend $? "Error saving random number generator seed" eend $? "Error saving random number generator seed"
return 0 return 0
} }