top: finally circumvent that minor libnuma memory leak
Still unhappy with a minor memory leak associated with libnuma, I experimented with omitting the dlclose that was issued at module's end. For some reason which will remain a mystery, the valgrind leak then went bye-bye. So this patch just omits one use of dlclose and relies on whatever kernel magic is at work to free the memory when each process ends. We kept, however, the original code (now commented-out) to serve as a future caution. There remains one potential (but unlikely) dlclose use near the original dlopen. But there will be no leak as that 'numa_node_of_cpu' will not yet have been called. This seems to be the culprit that triggers such leaks. None of this libnuma shit would likely have come close to hitting our fan had the numa developers provided us with 'new' and 'unref' functions like our newlib does. [ this commit parallels a patch in our newlib branch ] Signed-off-by: Jim Warner <james.warner@comcast.net>
This commit is contained in:
1
NEWS
1
NEWS
@@ -4,6 +4,7 @@ procps-ng-NEXT
|
||||
* library: dont use vm_min_free on non Linux Debian #831396
|
||||
* library: dont use SIGPWR on FreeBSD Debian #832148
|
||||
* pmap: fix duplicate output line under '-x' option Redhat #1374061
|
||||
* top: eliminated minor libnuma memory leak
|
||||
|
||||
procps-ng-3.3.12
|
||||
----------------
|
||||
|
Reference in New Issue
Block a user