emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

Merge branch 'fix-kill-l-bad-free-sig-prefix' into 'master'

Browse Source 
kill: Fix free() with bad pointer on SIG-prefixed signal-name

kill -l SIGHUP (or any other signal-name prefixed with "SIG")
would cause free() to be called with a bad pointer instead of
a pointer to what was allocated. Fix this and add test-case.

See merge request !26
This commit is contained in:
Craig Small 2016-09-10 23:54:44 +00:00
commit 18e7ebd261
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
proc/sig.c
View File

@ -261,7 +261,7 @@ char *strtosig(const char *restrict s){
} }
} }
} }
free(p); free(copy);
return converted; return converted;
} }

4
testsuite/kill.test/kill.exp
View File

@ -24,6 +24,10 @@ set test "kill convert signal name to number"
spawn $kill -lHUP spawn $kill -lHUP
expect_pass "$test" "^1\\s*" expect_pass "$test" "^1\\s*"
set test "kill convert SIG-prefixed signal name to number"
spawn $kill -lSIGHUP
expect_pass "$test" "^1\\s*$"
set test "kill convert signal number to name" set test "kill convert signal number to name"
spawn $kill -l 1 spawn $kill -l 1
expect_pass "$test" "^HUP\\s*" expect_pass "$test" "^HUP\\s*"