emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

pwdx: fix compiler warning

Browse Source 
pwdx.c:96:3: warning: ISO C90 forbids variable length array 'buf' [-Wvla]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
This commit is contained in:
Sami Kerola 2012-02-25 22:24:58 +01:00 committed by Craig Small
parent 5d04a5a75c
commit 1e489c7bc9
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pwdx.c
View File

@ -22,6 +22,7 @@
#include "proc/version.h" #include "proc/version.h"
#include "c.h" #include "c.h"
#include "nls.h" #include "nls.h"
#include "xalloc.h"
static void __attribute__ ((__noreturn__)) usage(FILE * out) static void __attribute__ ((__noreturn__)) usage(FILE * out)
{ {
@ -91,9 +92,11 @@ int main(int argc, char *argv[])
for (i = 0; i < argc; i++) { for (i = 0; i < argc; i++) {
char *s; char *s;
ssize_t len; ssize_t len, buflen;
/* Constant 10 is the length of strings "/proc/" + "/cwd" + 1 */ /* Constant 10 is the length of strings "/proc/" + "/cwd" + 1 */
char buf[10 + strlen(argv[i]) + 1]; char *buf;
buflen = 10 + strlen(argv[i]) + 1;
buf = xmalloc(buflen);
if (check_pid_argument(argv[i])) if (check_pid_argument(argv[i]))
xerrx(EXIT_FAILURE, _("invalid process id: %s"), xerrx(EXIT_FAILURE, _("invalid process id: %s"),
@ -104,9 +107,9 @@ int main(int argc, char *argv[])
* the first char is possible * the first char is possible
*/ */
if (argv[i][0] != '/') if (argv[i][0] != '/')
snprintf(buf, sizeof buf, "/proc/%s/cwd", argv[i]); snprintf(buf, buflen, "/proc/%s/cwd", argv[i]);
else else
snprintf(buf, sizeof buf, "%s/cwd", argv[i]); snprintf(buf, buflen, "%s/cwd", argv[i]);
/* /*
* buf contains /proc/NNNN/cwd symlink name * buf contains /proc/NNNN/cwd symlink name
@ -116,6 +119,7 @@ int main(int argc, char *argv[])
alloclen *= 2; alloclen *= 2;
pathbuf = realloc(pathbuf, alloclen); pathbuf = realloc(pathbuf, alloclen);
} }
free(buf);
if (len < 0) { if (len < 0) {
s = strerror(errno == ENOENT ? ESRCH : errno); s = strerror(errno == ENOENT ? ESRCH : errno);