emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

kill: print usage if no pid is passed in command line

Browse Source 
This makes a command such as `kill -TERM` or `kill -9` fails and prints
usage, instead of silently succeeding.

The behavior is consistent with how `kill` behaves without an explicit
signal, or with the behavior of the `kill` builtin in a shell like bash.

Signed-off-by: Filipe Brandenburger <filbranden@google.com>
This commit is contained in:
Filipe Brandenburger 2015-06-04 22:27:03 -07:00
parent d1d2ccf732
commit 27b2937d2d
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
skill.c
View File

@ -493,6 +493,9 @@ static void __attribute__ ((__noreturn__))
argc -= optind; argc -= optind;
argv += optind; argv += optind;
if (argc < 1)
kill_usage(stderr);
for (i = 0; i < argc; i++) { for (i = 0; i < argc; i++) {
pid = strtol_or_err(argv[i], _("failed to parse argument")); pid = strtol_or_err(argv[i], _("failed to parse argument"));
if (!kill((pid_t) pid, signo)) if (!kill((pid_t) pid, signo))