emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

pidof: Prevent integer overflows with grow_size().

Browse Source 
Note: unlike "size" and "omit_size", "path_alloc_size" is not multiplied
by "sizeof(struct el)" but the checks in grow_size() allow for a roughly
100MB path_alloc_size, which should be more than enough for readlink().
This commit is contained in:
Qualys Security Advisory 1970-01-01 00:00:00 +00:00 committed by Craig Small
parent ab8b3881a0
commit 6df9ffb341
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pidof.c
View File

@ -20,6 +20,7 @@
#include <stdio.h> #include <stdio.h>
#include <getopt.h> #include <getopt.h>
#include <limits.h>
#include "c.h" #include "c.h"
#include "fileutils.h" #include "fileutils.h"
@ -29,7 +30,12 @@
#include "proc/version.h" /* procps_version */ #include "proc/version.h" /* procps_version */
#define grow_size(x) (x = x * 5 / 4 + 1024) #define grow_size(x) do { \
if ((x) < 0 || (size_t)(x) >= INT_MAX / 5 / sizeof(struct el)) \
xerrx(EXIT_FAILURE, _("integer overflow")); \
(x) = (x) * 5 / 4 + 1024; \
} while (0)
#define safe_free(x) if (x) { free(x); x=NULL; } #define safe_free(x) if (x) { free(x); x=NULL; }