emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

0004-pgrep: Replace buf+1 with buf in read_pidfile().

Browse Source 
Unless we missed something, this makes it unnecessarily difficult to
read/audit.
This commit is contained in:
Qualys Security Advisory 1970-01-01 00:00:00 +00:00 committed by Craig Small
parent 9cfc1b8c1f
commit 8e3e77910d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pgrep.c
View File

@ -266,11 +266,11 @@ static struct el *read_pidfile(void)
if(opt_lock && !has_flock(fd) && !has_fcntl(fd))
goto out;
memset(buf,'\0',sizeof buf);
n = read(fd,buf+1,sizeof buf-2);
n = read(fd,buf,sizeof buf-1);
if (n<1)
goto out;
pid = strtoul(buf+1,&endp,10);
if(endp<=buf+1 || pid<1 )
pid = strtoul(buf,&endp,10);
if(endp<=buf || pid<1 )
goto out;
if(*endp && !isspace(*endp))
goto out;