emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

library: <MEMINFO> api, changed that 'get' return type

Browse Source 
The following commit message is shared with 4 patches.
------------------------------------------------------

Under the newlib interface most of our 'get' functions
represent a bit of a compromise in that the actual raw
values are coerced into one (probably ok) return type.

That approach creates the possibility of truncation at
best, and wouldn't serve future needs should something
other than numeric data be added to the 'get' results.

This commit trades the current compromise for a return
value guaranteed to satisfy all future needs, namely a
pointer to a particular api's specific results struct.

The impact on existing programs is minimal, especially
when using a new supplied macro. Otherwise, native 'C'
syntax could be used, but may feel somewhat unnatural.

[ as an aside, this new approach allows us to delete ]
[ all 'getsfunc' table entries & the supporting code ]

Signed-off-by: Jim Warner <james.warner@comcast.net>
This commit is contained in:
Jim Warner
2016-06-18 00:00:00 -05:00
committed by Craig Small
parent e8d7f869b5
commit 8f1fb67a78
2 changed files with 112 additions and 222 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
proc/meminfo.h
View File

@@ -135,8 +135,11 @@ struct meminfo_stack {
};
#define PROCPS_MEMINFO_VAL(rel_enum,type,stack) \
stack -> head [ rel_enum ] . result . type
#define PROCPS_MEMINFO_GET( meminfo, actual_enum, type ) \
procps_meminfo_get( meminfo, actual_enum ) -> result . type
#define PROCPS_MEMINFO_VAL( relative_enum, type, stack) \
stack -> head [ relative_enum ] . result . type
struct procps_meminfo;
@@ -145,7 +148,7 @@ int procps_meminfo_new (struct procps_meminfo **info);
int procps_meminfo_ref (struct procps_meminfo *info);
int procps_meminfo_unref (struct procps_meminfo **info);
signed long procps_meminfo_get (
struct meminfo_result *procps_meminfo_get (
struct procps_meminfo *info,
enum meminfo_item item);