emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

libproc-ng & ps: fix warning reported by smatch

Browse Source 
proc/ksym.c +279 read_file(54) info: redundant null check on buf calling free()
proc/ksym.c +330 parse_ksyms(41) info: redundant null check on ksyms_data calling free()
proc/ksym.c +332 parse_ksyms(43) info: redundant null check on ksyms_index calling free()
proc/ksym.c +451 sysmap_mmap(110) info: redundant null check on sysmap_index calling free()
proc/procps.h:74:5: warning: undefined preprocessor identifier 'SHARED'
proc/slab.c +145 parse_slabinfo20(24) error: potential null derefence 'prev'.
proc/slab.c +222 parse_slabinfo11(21) error: potential null derefence 'prev'.
ps/stacktrace.c +131 debug(6) error: snprintf() is printing too much 99 vs 16

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
This commit is contained in:
Sami Kerola
2011-10-11 22:01:19 +02:00
parent c1fa3bfce8
commit 9057b18a32
5 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ps/stacktrace.c
View File

@ -128,7 +128,7 @@ void debug(int method, char *prog_name){
char *args[4] = { "gdb", NULL, NULL, NULL };
int x;
snprintf (buf, 99, "%d", getpid ());
snprintf (buf, 16, "%d", getpid ());
args[1] = prog_name;
args[2] = buf;