emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

proc/sysinfo.c: Fix off-by-one in get_pid_digits().

Browse Source 
At "pidbuf[rc] = '\0';" if "rc = read()" returns "sizeof pidbuf"
(unlikely to ever happen, but still).
This commit is contained in:
Qualys Security Advisory 1970-01-01 00:00:00 +00:00 committed by Craig Small
parent 8136a7a664
commit a33be33885
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
proc/sysinfo.c
View File

@ -1140,7 +1140,7 @@ unsigned get_pid_digits(void){
ret = 5; ret = 5;
fd = open("/proc/sys/kernel/pid_max", O_RDONLY); fd = open("/proc/sys/kernel/pid_max", O_RDONLY);
if(fd==-1) goto out; if(fd==-1) goto out;
rc = read(fd, pidbuf, sizeof pidbuf); rc = read(fd, pidbuf, sizeof pidbuf - 1);
close(fd); close(fd);
if(rc<3) goto out; if(rc<3) goto out;
pidbuf[rc] = '\0'; pidbuf[rc] = '\0';