emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

top: miscellaneous accumulated tweaks of code/comments

Browse Source 
This commit just tries to parallel that newlib branch.
It contains the following changes, which were prompted
by the newlib coverity analysis which Craig initiated:

. comment typo predicting 'String not null terminated'
. eliminate 'Logically dead code' from insp_make_row()

Some tweaks, unrelated to coverity, are also included:

. use more modern (recommended) approach for time call

Signed-off-by: Jim Warner <james.warner@comcast.net>
This commit is contained in:
Jim Warner 2016-04-26 00:00:00 -05:00 committed by Craig Small
parent 5e26512980
commit ac8f49e79e
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
top/top.c
View File

@ -982,7 +982,7 @@ static int ioch (int ech, char *buf, unsigned cnt) {
// it may have been the beginning of a lengthy escape sequence // it may have been the beginning of a lengthy escape sequence
tcflush(STDIN_FILENO, TCIFLUSH); tcflush(STDIN_FILENO, TCIFLUSH);
// note: we do NOT produce a vaid 'string' // note: we do NOT produce a valid 'string'
return rc; return rc;
} // end: ioch } // end: ioch
@ -2699,7 +2699,7 @@ static void sysinfo_refresh (int forced) {
if (forced) if (forced)
mem_secs = cpu_secs = 0; mem_secs = cpu_secs = 0;
time(&cur_secs); cur_secs = time(NULL);
/*** hotplug_acclimated ***/ /*** hotplug_acclimated ***/
if (3 <= cur_secs - mem_secs) { if (3 <= cur_secs - mem_secs) {
@ -3008,7 +3008,6 @@ static inline void insp_make_row (int col, int row) {
int fr, to, ofs; int fr, to, ofs;
int hicap = 0; int hicap = 0;
capNO;
if (col < INSP_RLEN(row)) if (col < INSP_RLEN(row))
memcpy(tline, Insp_p[row] + col, sizeof(tline)); memcpy(tline, Insp_p[row] + col, sizeof(tline));
else tline[0] = '\n'; else tline[0] = '\n';