emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

sysctl return value

Browse Source 
Gilles brought up a warning message in sysctl.c
sysctl.c: In function 'main':
sysctl.c:767: warning: value computed is not used

The return value of Preload was not being applied correctly to ret
meaning sysctl would not return the correct value.

Reference: http://www.freelists.org/post/procps/procpsng-337,18

Signed-off-by: Craig Small <csmall@enc.com.au>
This commit is contained in:
Craig Small 2013-04-07 09:30:59 +10:00
parent a059034856
commit c2707dc2d7
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sysctl.c
View File

@ -764,15 +764,15 @@ int main(int argc, char *argv[])
int ret = EXIT_SUCCESS, i; int ret = EXIT_SUCCESS, i;
if (!preloadfile) { if (!preloadfile) {
if (!argc) { if (!argc) {
ret != Preload(DEFAULT_PRELOAD); ret |= Preload(DEFAULT_PRELOAD);
} }
} else { } else {
/* This happens when -pfile option is /* This happens when -pfile option is
* used without space. */ * used without space. */
Preload(preloadfile); ret |= Preload(preloadfile);
} }
for (i = 0; i < argc; i++) for (i = 0; i < argc; i++)
Preload(argv[i]); ret |= Preload(argv[i]);
return ret; return ret;
} }