emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

Coverity scan findings - memleaks, unused vars, potential nullptr dereferences

Browse Source
This commit is contained in:
Jan Rybar 2021-05-06 16:30:54 +02:00 committed by Craig Small
parent bf0b3b6522
commit d293b686e4
3 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/test_process.c
View File

@ -69,6 +69,7 @@ signal_handler(int signum, siginfo_t *siginfo, void *ucontext)
exit(EXIT_FAILURE); exit(EXIT_FAILURE);
} }
free(signame);
} }
int main(int argc, char *argv[]) int main(int argc, char *argv[])

3
pmap.c
View File

@ -352,6 +352,9 @@ static void print_extended_maps (FILE *f)
if (listnode == NULL) { if (listnode == NULL) {
assert(firstmapping == 2); assert(firstmapping == 2);
listnode = calloc(1, sizeof *listnode); listnode = calloc(1, sizeof *listnode);
if (listnode == NULL)
xerrx(EXIT_FAILURE, _("ERROR: memory allocation failed"));
if (listhead == NULL) { if (listhead == NULL) {
assert(listtail == NULL); assert(listtail == NULL);
listhead = listnode; listhead = listnode;

5
watch.c
View File

@ -125,8 +125,6 @@ static void reset_ansi(void)
static void init_ansi_colors(void) static void init_ansi_colors(void)
{ {
int color;
short ncurses_colors[] = { short ncurses_colors[] = {
-1, COLOR_BLACK, COLOR_RED, COLOR_GREEN, COLOR_YELLOW, -1, COLOR_BLACK, COLOR_RED, COLOR_GREEN, COLOR_YELLOW,
COLOR_BLUE, COLOR_MAGENTA, COLOR_CYAN, COLOR_WHITE COLOR_BLUE, COLOR_MAGENTA, COLOR_CYAN, COLOR_WHITE
@ -173,6 +171,9 @@ static int process_ansi_color_escape_sequence(char** escape_sequence) {
// ESC[ 48;2;⟨r⟩;⟨g⟩;⟨b⟩ m Select RGB background color // ESC[ 48;2;⟨r⟩;⟨g⟩;⟨b⟩ m Select RGB background color
int num; int num;
if (!escape_sequence)
return 0; /* avoid NULLPTR dereference, return "not understood" */
if ((*escape_sequence)[0] != ';') if ((*escape_sequence)[0] != ';')
return 0; /* not understood */ return 0; /* not understood */