b159c198c9
When the globbing update was put into sysctl, you could no longer
simply use the keys because one key could potentially be
multiple paths once the glob expansion occured. Using the path
instead gave a unique output.
Except certain programs, such as salt, expected the output to use
the dotted path "kernel.hostname" and not "kernel/hostname".
We can no longer use the original key, so now for each path:
Copy the path
strip off /proc/
convert all / to .
The sysctl testsuite was also updated to check for a few different
types of conversion failures.
References:
commit
|
||
---|---|---|
.. | ||
config | ||
free.test | ||
kill.test | ||
lib.test | ||
pgrep.test | ||
pkill.test | ||
pmap.test | ||
ps.test | ||
pwait.test | ||
pwdx.test | ||
slabtop.test | ||
sysctl.test | ||
uptime.test | ||
vmstat.test | ||
w.test | ||
.gitignore | ||
Makefile.am | ||
README | ||
sysctl_glob_test.conf | ||
sysctl_slash_test.conf |
How to use check suite ---------------------- You need DejaGNU package. Assuming you have it all you need to do is make check Something failed now what ------------------------- First determine what did not work. If only one check failed you can run it individually in debugging mode. For example runtest -a -de -v w.test/w.exp Expect binary is /usr/bin/expect Using /usr/share/dejagnu/runtest.exp as main test driver [...] Do not bother capturing screen output, it is in testrun.log which test suite generated. $ ls testrun.* dbg.log dbg.log testrun.log testrun.sum The reason why test failed should be in dbg.log. Assuming you figured out the reason you could write a patch fixing w.test/w.exp and send it to upstream. If you do not know how, or have time, to fix the issue create tar.gz file containing test run logs and submit it to upstream maintainers. Notice that in later case upstream sometimes has to ask clarifying questions about environment where problem occurred.