procps/testsuite
dmarc-noreply@freelists.org e40b0060c2 tests: slabinfo should not be too strict about slab names
Before this commit, the test checking `vmstat -m` (slabinfo) output uses
a fairly strict regular expression that only allows alphanumeric
characters and a few exceptions such as "_", "-", "(" and ")".

However, recent kernels use a wider range of characters, such as ">".
For instance, see this Linux commit which creates a "page->ptl" slab:
  https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/mm/memory.c?id=b35f1819acd9243a3ff7ad25b1fa8bd6bfe80fb2#n4283

Other patches for reporting slab usage per memcg include the names of
the cgroup in the slabinfo output, which can include additional
characters and use dots for abbreviation.

The check should not be so string, instead it could simply look for a
chain of non-whitespace characters and that should be enough.

Tested that `make check` is still working, including in some of the
environments where features that enable the additional slabinfo names.

Signed-off-by: Filipe Brandenburger <filbranden@google.com>
Signed-off-by: Craig Small <csmall@enc.com.au>
2015-05-10 15:05:28 +10:00
..
config Fix some sched and tty tests 2015-05-09 17:48:12 +10:00
free.test free: Use IEC units 2015-04-03 19:18:58 +11:00
kill.test skip kill test too if running runtest 2013-05-26 07:25:55 +10:00
lib.test lib: add fileutils file with stream error checking facility 2012-03-23 15:57:41 +01:00
pgrep.test pgrep SID=1 is valid 2015-05-09 17:53:08 +10:00
pkill.test Fix some sched and tty tests 2015-05-09 17:48:12 +10:00
pmap.test Update help files 2014-02-02 18:13:01 +11:00
ps.test tests: fix regexp in ps_sched_batch.exp to match in first line 2015-05-10 15:05:02 +10:00
pwdx.test tests: fix dejagnu pwdx and vmstat checks 2012-02-11 21:42:21 +01:00
slabtop.test Updated testsuite files for new NLS output 2012-01-02 17:39:41 +11:00
sysctl.test Updated testsuite files for new NLS output 2012-01-02 17:39:41 +11:00
uptime.test test for previous commit 2012-12-26 23:21:44 +11:00
vmstat.test tests: slabinfo should not be too strict about slab names 2015-05-10 15:05:28 +10:00
w.test Fix w tests when no user is logged in 2012-05-08 22:51:19 +10:00
.gitignore tests: add SCHED_BATCH test 2012-01-09 21:37:41 +01:00
Makefile.am procps-ng testsuite : simplify DEJAGNU workaround 2013-05-26 07:32:02 +10:00
README docs: add testsuite readme file 2012-03-03 18:36:29 +11:00

How to use check suite
----------------------

You need DejaGNU package.  Assuming you have it all you need to do is

make check


Something failed now what
-------------------------

First determine what did not work.  If only one check failed you can
run it individually in debugging mode.  For example

runtest -a -de -v w.test/w.exp
Expect binary is /usr/bin/expect
Using /usr/share/dejagnu/runtest.exp as main test driver
[...]

Do not bother capturing screen output, it is in testrun.log which
test suite generated.

$ ls  testrun.* dbg.log
dbg.log  testrun.log  testrun.sum

The reason why test failed should be in dbg.log.  Assuming you
figured out the reason you could write a patch fixing w.test/w.exp
and send it to upstream.

If you do not know how, or have time, to fix the issue create tar.gz
file containing test run logs and submit it to upstream maintainers.
Notice that in later case upstream sometimes has to ask clarifying
questions about environment where problem occurred.