emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

open with O_CREAT when lock path does not exist

Browse Source 
Reported in #686, by wyj611 when trying to lock a file that is not
present

Lock method should be F_SETLKW rather than open file descriptor
This commit is contained in:
ed neville 2023-05-06 10:05:47 +01:00 committed by Serge Hallyn
parent 627631bf9a
commit 0bce9c9808
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/commonio.c
View File

@ -215,7 +215,7 @@ int do_fcntl_lock (const char *file, bool log, short type)
.l_len = 0, .l_len = 0,
}; };
fd = open (file, O_WRONLY, 0600); fd = open (file, O_WRONLY | O_CREAT, 0600);
if (-1 == fd) { if (-1 == fd) {
if (log) { if (log) {
(void) fprintf (shadow_logfd, "%s: %s: %s\n", (void) fprintf (shadow_logfd, "%s: %s: %s\n",
@ -224,8 +224,7 @@ int do_fcntl_lock (const char *file, bool log, short type)
return 0; return 0;
} }
fcntl (fd, F_OFD_SETLKW, &lck); fcntl (fd, F_SETLKW, &lck);
close(fd);
return(1); return(1);
} }