emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

* src/su.c: Do not sanitize the environment. This breaks

Browse Source 
--preserve-environment. This sanitation was disabled on Debian
	since quite some time with no reported issues, and sanitize_env()
	documentation agrees that it should be useless as all modern
	Unixes will handle setuid executables properly. This Fixes
	Alioth#312287.
This commit is contained in:
nekral-guest 2010-01-24 17:13:40 +00:00
parent 0fce70b091
commit 291b28ac52
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ChangeLog
View File

@ -1,3 +1,12 @@
2009-01-24 Nicolas François <nicolas.francois@centraliens.net>
* src/su.c: Do not sanitize the environment. This breaks
--preserve-environment. This sanitation was disabled on Debian
since quite some time with no reported issues, and sanitize_env()
documentation agrees that it should be useless as all modern
Unixes will handle setuid executables properly. This Fixes
Alioth#312287.
2009-01-24 Nicolas François <nicolas.francois@centraliens.net> 2009-01-24 Nicolas François <nicolas.francois@centraliens.net>
* libmisc/setupenv.c: Fix typo from 2009-11-01. * libmisc/setupenv.c: Fix typo from 2009-11-01.

2
src/su.c
View File

@ -409,8 +409,6 @@ int main (int argc, char **argv)
#endif #endif
#endif /* !USE_PAM */ #endif /* !USE_PAM */
sanitize_env ();
(void) setlocale (LC_ALL, ""); (void) setlocale (LC_ALL, "");
(void) bindtextdomain (PACKAGE, LOCALEDIR); (void) bindtextdomain (PACKAGE, LOCALEDIR);
(void) textdomain (PACKAGE); (void) textdomain (PACKAGE);