Have a single definition of date_to_str()
PARAMETERS: According to the C2x charter, I reordered the parameters 'size' and 'buf' from previously existing date_to_str() definitions. C2x charter: > 15. Application Programming Interfaces (APIs) should be > self-documenting when possible. In particular, the order of > parameters in function declarations should be arranged such that > the size of an array appears before the array. The purpose is to > allow Variable-Length Array (VLA) notation to be used. This not > only makes the code's purpose clearer to human readers, but also > makes static analysis easier. Any new APIs added to the Standard > should take this into consideration. I used 'long' for the date parameter, as some uses of the function need to pass a negative value meaning "never". FUNCTION BODY: I didn't check '#ifdef HAVE_STRFTIME', which old definitions did, since strftime(3) is guaranteed by the C89 standard, and all of the conversion specifiers that we use are also specified by that standard, so we don't need any extensions at all. Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
This commit is contained in:
@ -134,6 +134,9 @@ extern int copy_tree (const char *src_root, const char *dst_root,
|
||||
uid_t old_uid, uid_t new_uid,
|
||||
gid_t old_gid, gid_t new_gid);
|
||||
|
||||
/* date_to_str.c */
|
||||
extern void date_to_str (size_t size, char buf[size], long date);
|
||||
|
||||
/* encrypt.c */
|
||||
extern /*@exposed@*//*@null@*/char *pw_encrypt (const char *, const char *);
|
||||
|
||||
|
Reference in New Issue
Block a user