emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

* src/login.c: Ignore the return value of signal().

Browse Source 
* src/login.c: Use a %lu format and cast group and user IDs to
	unsigned long integers.
	* src/login.c: Ignore return value of setlocale(),
	bindtextdomain(), and textdomain().
This commit is contained in:
nekral-guest 2008-06-13 21:25:15 +00:00
parent fe753e24a3
commit 3a03794bb6
2 changed files with 22 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -1,3 +1,11 @@
2008-06-13 Nicolas François <nicolas.francois@centraliens.net>
* src/login.c: Ignore the return value of signal().
* src/login.c: Use a %lu format and cast group and user IDs to
unsigned long integers.
* src/login.c: Ignore return value of setlocale(),
bindtextdomain(), and textdomain().
2008-06-13 Nicolas François <nicolas.francois@centraliens.net> 2008-06-13 Nicolas François <nicolas.francois@centraliens.net>
* src/chage.c: Add the arguments' names in the functions * src/chage.c: Add the arguments' names in the functions

26
src/login.c
View File

@ -615,7 +615,7 @@ int main (int argc, char **argv)
top: top:
/* only allow ALARM sec. for login */ /* only allow ALARM sec. for login */
signal (SIGALRM, alarm_handler); (void) signal (SIGALRM, alarm_handler);
timeout = getdef_num ("LOGIN_TIMEOUT", ALARM); timeout = getdef_num ("LOGIN_TIMEOUT", ALARM);
if (timeout > 0) { if (timeout > 0) {
alarm (timeout); alarm (timeout);
@ -754,7 +754,8 @@ int main (int argc, char **argv)
pw = getpwnam (username); pw = getpwnam (username);
if (NULL != pw) { if (NULL != pw) {
snprintf (buf, sizeof (buf), snprintf (buf, sizeof (buf),
"uid=%d", pw->pw_uid); "uid=%lu",
(unsigned long) pw->pw_uid);
audit_log_user_message audit_log_user_message
(audit_fd, AUDIT_USER_LOGIN, (audit_fd, AUDIT_USER_LOGIN,
buf, hostname, NULL, buf, hostname, NULL,
@ -1053,7 +1054,8 @@ int main (int argc, char **argv)
char buf[32]; char buf[32];
audit_fd = audit_open (); audit_fd = audit_open ();
snprintf (buf, sizeof (buf), "uid=%d", pwd->pw_uid); snprintf (buf, sizeof (buf), "uid=%lu",
(unsigned long) pwd->pw_uid);
audit_log_user_message (audit_fd, AUDIT_USER_LOGIN, audit_log_user_message (audit_fd, AUDIT_USER_LOGIN,
buf, hostname, NULL, tty, 1); buf, hostname, NULL, tty, 1);
close (audit_fd); close (audit_fd);
@ -1093,7 +1095,7 @@ int main (int argc, char **argv)
* We must fork before setuid() because we need to call * We must fork before setuid() because we need to call
* pam_close_session() as root. * pam_close_session() as root.
*/ */
signal (SIGINT, SIG_IGN); (void) signal (SIGINT, SIG_IGN);
child = fork (); child = fork ();
if (child < 0) { if (child < 0) {
/* error in fork() */ /* error in fork() */
@ -1144,9 +1146,9 @@ int main (int argc, char **argv)
} }
#endif #endif
setlocale (LC_ALL, ""); (void) setlocale (LC_ALL, "");
bindtextdomain (PACKAGE, LOCALEDIR); (void) bindtextdomain (PACKAGE, LOCALEDIR);
textdomain (PACKAGE); (void) textdomain (PACKAGE);
if (!hushed (&pwent)) { if (!hushed (&pwent)) {
addenv ("HUSHLOGIN=FALSE", NULL); addenv ("HUSHLOGIN=FALSE", NULL);
@ -1205,11 +1207,11 @@ int main (int argc, char **argv)
ttytype (tty); ttytype (tty);
} }
signal (SIGQUIT, SIG_DFL); /* default quit signal */ (void) signal (SIGQUIT, SIG_DFL); /* default quit signal */
signal (SIGTERM, SIG_DFL); /* default terminate signal */ (void) signal (SIGTERM, SIG_DFL); /* default terminate signal */
signal (SIGALRM, SIG_DFL); /* default alarm signal */ (void) signal (SIGALRM, SIG_DFL); /* default alarm signal */
signal (SIGHUP, SIG_DFL); /* added this. --marekm */ (void) signal (SIGHUP, SIG_DFL); /* added this. --marekm */
signal (SIGINT, SIG_DFL); /* default interrupt signal */ (void) signal (SIGINT, SIG_DFL); /* default interrupt signal */
endpwent (); /* stop access to password file */ endpwent (); /* stop access to password file */
endgrent (); /* stop access to group file */ endgrent (); /* stop access to group file */