emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

Initialize local variables

Browse Source 
CWE-457 by CodeQL.

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
This commit is contained in:
Iker Pedrosa 2022-05-16 17:24:58 +02:00 committed by Serge Hallyn
parent 0c7ded471f
commit 3b89b71680
3 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/run_part.c
View File

@ -45,7 +45,7 @@ int run_parts (const char *directory, const char *name, const char *action)
struct dirent **namelist; struct dirent **namelist;
int scanlist; int scanlist;
int n; int n;
int execute_result; int execute_result = 0;
scanlist = scandir (directory, &namelist, 0, alphasort); scanlist = scandir (directory, &namelist, 0, alphasort);
if (scanlist<=0) { if (scanlist<=0) {

4
src/faillog.c
View File

@ -537,9 +537,9 @@ static void set_locktime (long locktime)
int main (int argc, char **argv) int main (int argc, char **argv)
{ {
long fail_locktime; long fail_locktime = 0;
short fail_max = 0; // initialize to silence compiler warning short fail_max = 0; // initialize to silence compiler warning
long days; long days = 0;
/* /*
* Get the program name. The program name is used as a prefix to * Get the program name. The program name is used as a prefix to

21
src/lastlog.c
View File

@ -88,7 +88,16 @@ static void print_one (/*@null@*/const struct passwd *pw)
char ptime[80]; char ptime[80];
#ifdef HAVE_LL_HOST #ifdef HAVE_LL_HOST
int maxIPv6Addrlen; /*
* ll_host is in minimized form, thus the maximum IPv6 address possible is
* 8*4+7 = 39 characters.
* RFC 4291 2.5.6 states that for LL-addresses fe80+only the interface ID is set,
* thus having a maximum size of 25+1+IFNAMSIZ.
* POSIX says IFNAMSIZ should be 16 characters long including the null byte, thus
* 25+1+IFNAMSIZ >= 42 > 39
*/
/* Link-Local address + % + Interfacename */
const int maxIPv6Addrlen = 25+1+IFNAMSIZ;
#endif #endif
if (NULL == pw) { if (NULL == pw) {
@ -132,16 +141,6 @@ static void print_one (/*@null@*/const struct passwd *pw)
/* Print the header only once */ /* Print the header only once */
if (!once) { if (!once) {
#ifdef HAVE_LL_HOST #ifdef HAVE_LL_HOST
/*
* ll_host is in minimized form, thus the maximum IPv6 address possible is
* 8*4+7 = 39 characters.
* RFC 4291 2.5.6 states that for LL-addresses fe80+only the interface ID is set,
* thus having a maximum size of 25+1+IFNAMSIZ.
* POSIX says IFNAMSIZ should be 16 characters long including the null byte, thus
* 25+1+IFNAMSIZ >= 42 > 39
*/
/* Link-Local address + % + Interfacename */
maxIPv6Addrlen = 25+1+IFNAMSIZ;
printf (_("Username Port From%*sLatest\n"), maxIPv6Addrlen-3, " "); printf (_("Username Port From%*sLatest\n"), maxIPv6Addrlen-3, " ");
#else #else
puts (_("Username Port Latest")); puts (_("Username Port Latest"));