emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

newuidmap,newgidmap: Correct the range size sanity check in get_map_ranges

Browse Source 
The number of ranges should be the ceiling of the number of arguments divided
by three.

Without this fix newuidmap and newgidmap always report and error and fail,
which is very much not what we want.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
This commit is contained in:
Eric W. Biederman 2013-09-08 02:49:52 -07:00 committed by Serge Hallyn
parent 5e87ff0615
commit 578947e661
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libmisc/idmapping.c
View File

@ -47,7 +47,7 @@ struct map_range *get_map_ranges(int ranges, int argc, char **argv)
return NULL; return NULL;
} }
if (ranges != ((argc - 2) + 2) / 3) { if (ranges != ((argc + 2) / 3)) {
fprintf(stderr, "%s: ranges: %u is wrong for argc: %d\n", Prog, ranges, argc); fprintf(stderr, "%s: ranges: %u is wrong for argc: %d\n", Prog, ranges, argc);
return NULL; return NULL;
} }