emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

Address minor compiler warnings

Browse Source 
copydir.c:666:44: warning: unsigned conversion from 'int' to '__mode_t' {aka 'unsigned int'} changes value from '-4096' to '4294963200' [-Wsign-conversion]
      666 |         if (   (mknod (dst, statp->st_mode & ~07777, statp->st_rdev) != 0)
          |                                            ^

    copydir.c:116:1: warning: missing initializer for field 'quote' of 'struct error_context' [-Wmissing-field-initializers]
      116 | };
          | ^
    In file included from copydir.c:27:
    /usr/include/attr/error_context.h:30:23: note: 'quote' declared here
       30 |         const char *(*quote) (struct error_context *, const char *);
          |                       ^~~~~
This commit is contained in:
Christian Göttsche 2022-08-05 17:57:29 +02:00 committed by Serge Hallyn
parent f606314f0c
commit 6cbec2d0aa
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libmisc/copydir.c
View File

@ -112,7 +112,7 @@ static void error_acl (unused struct error_context *ctx, const char *fmt, ...)
} }
static struct error_context ctx = { static struct error_context ctx = {
error_acl error_acl, NULL, NULL
}; };
#endif /* WITH_ACL || WITH_ATTR */ #endif /* WITH_ACL || WITH_ATTR */
@ -663,7 +663,7 @@ static int copy_special (const char *src, const char *dst,
} }
#endif /* WITH_SELINUX */ #endif /* WITH_SELINUX */
if ( (mknod (dst, statp->st_mode & ~07777, statp->st_rdev) != 0) if ( (mknod (dst, statp->st_mode & ~07777U, statp->st_rdev) != 0)
|| (chown_if_needed (dst, statp, || (chown_if_needed (dst, statp,
old_uid, new_uid, old_gid, new_gid) != 0) old_uid, new_uid, old_gid, new_gid) != 0)
#ifdef WITH_ACL #ifdef WITH_ACL