emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

* src/groupmems.c: Added function open_°files and close_files to

Browse Source 
ease the support of gshadow.
	* src/groupmems.c: Always call check_perms(). This function now
	succeed when the requested action is to list the members.
This commit is contained in:
nekral-guest 2008-08-30 18:34:43 +00:00
parent 72d75d50d9
commit 71656e3cba
2 changed files with 47 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ChangeLog
View File

@ -1,7 +1,10 @@
2008-08-27 Nicolas François <nicolas.francois@centraliens.net> 2008-08-27 Nicolas François <nicolas.francois@centraliens.net>
* src/groupmems.c: Added functions add_user(), remove_user(), and * src/groupmems.c: Added functions add_user(), remove_user(),
purge_members() to ease the support of gshadow. purge_members(), open_files, and close_files to ease the support
of gshadow.
* src/groupmems.c: Always call check_perms(). This function now
succeed when the requested action is to list the members.
2008-08-27 Nicolas François <nicolas.francois@centraliens.net> 2008-08-27 Nicolas François <nicolas.francois@centraliens.net>

62
src/groupmems.c
View File

@ -242,6 +242,10 @@ static void process_flags (int argc, char **argv)
static void check_perms (void) static void check_perms (void)
{ {
if (list) {
return;
}
#ifdef USE_PAM #ifdef USE_PAM
pam_handle_t *pamh = NULL; pam_handle_t *pamh = NULL;
int retval = PAM_SUCCESS; int retval = PAM_SUCCESS;
@ -285,6 +289,41 @@ static void fail_exit (int code)
exit (code); exit (code);
} }
static void open_files (void)
{
if (!list) {
if (gr_lock () == 0) {
fprintf (stderr,
_("%s: cannot lock %s; try again later.\n"),
Prog, gr_dbname ());
fail_exit (EXIT_GROUP_FILE);
}
gr_locked = true;
}
if (gr_open (list ? O_RDONLY : O_RDWR) == 0) {
fprintf (stderr, _("%s: cannot open %s\n"), Prog, gr_dbname ());
fail_exit (EXIT_GROUP_FILE);
}
}
static void close_files (void)
{
if (gr_close () == 0) {
fprintf (stderr, _("%s: failure while writing changes to %s\n"), Prog, gr_dbname ());
SYSLOG ((LOG_ERR, "failure while writing changes to %s", gr_dbname ()));
fail_exit (EXIT_GROUP_FILE);
}
if (gr_locked) {
if (gr_unlock () == 0) {
fprintf (stderr, _("%s: failed to unlock %s\n"), Prog, gr_dbname ());
SYSLOG ((LOG_ERR, "failed to unlock %s", gr_dbname ()));
/* continue */
}
gr_locked = false;
}
}
int main (int argc, char **argv) int main (int argc, char **argv)
{ {
char *name; char *name;
@ -317,17 +356,9 @@ int main (int argc, char **argv)
} }
} }
if (!list) { check_perms ();
check_perms ();
if (gr_lock () == 0) { open_files ();
fprintf (stderr,
_("%s: cannot lock %s; try again later.\n"),
Prog, gr_dbname ());
fail_exit (EXIT_GROUP_FILE);
}
gr_locked = true;
}
if (gr_open (list ? O_RDONLY : O_RDWR) == 0) { if (gr_open (list ? O_RDONLY : O_RDWR) == 0) {
fprintf (stderr, _("%s: cannot open %s\n"), Prog, gr_dbname ()); fprintf (stderr, _("%s: cannot open %s\n"), Prog, gr_dbname ());
@ -352,16 +383,7 @@ int main (int argc, char **argv)
purge_members (grp); purge_members (grp);
} }
if (gr_close () == 0) { close_files ();
fprintf (stderr, _("%s: failure while writing changes to %s\n"), Prog, gr_dbname ());
SYSLOG ((LOG_ERR, "failure while writing %s", gr_dbname ()));
fail_exit (EXIT_GROUP_FILE);
}
if (gr_unlock () == 0) {
fprintf (stderr, _("%s: failed to unlock %s\n"), Prog, gr_dbname ());
SYSLOG ((LOG_ERR, "failed to unlock %s", gr_dbname ()));
/* continue */
}
exit (EXIT_SUCCESS); exit (EXIT_SUCCESS);
} }