emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

Remove unnecessary NUL terminators

Browse Source 
All the string-copying functions called above do terminate the strings
they create with a NUL byte.  Writing it again at the end of the buffer
is unnecessary paranoid code.  Let's remove it.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
This commit is contained in:
Alejandro Colomar 2023-01-30 00:56:57 +01:00 committed by Iker Pedrosa
parent 46610792e9
commit 8a9285aacb
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/groupmod.c
View File

@ -627,11 +627,6 @@ static void prepare_failure_reports (void)
stpeprintf(info_passwd.action+strlen (info_passwd.action), stpeprintf(info_passwd.action+strlen (info_passwd.action),
pw_end, "%ju", (uintmax_t) group_newid); pw_end, "%ju", (uintmax_t) group_newid);
} }
info_group.audit_msg[511] = '\0';
#ifdef SHADOWGRP
info_gshadow.audit_msg[511] = '\0';
#endif
info_passwd.audit_msg[511] = '\0';
// FIXME: add a system cleanup // FIXME: add a system cleanup
add_cleanup (cleanup_report_mod_group, &info_group); add_cleanup (cleanup_report_mod_group, &info_group);